[Pywikipedia-bugs] [Maniphest] [Commented On] T209762: script_tests fails for flickrripper.py

2018-11-17 Thread Xqt
Xqt added a comment. I am wondering about this because 'flickrripper' should be part of the _expected_failures set inside TestScriptSimulate.TASK DETAILhttps://phabricator.wikimedia.org/T209762EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Dvorapa, Akl

[Pywikipedia-bugs] [Maniphest] [Closed] T209767: python 2.7 script_tests fails with unicode values in env on Windows

2018-11-17 Thread Xqt
Xqt closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T209767EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Aklapper, pywikibot-bugs-list, Dalba, jayvdb, Xqt, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Maje

[Pywikipedia-bugs] [Maniphest] [Unblock] T200955: Update pywikibot queries for MCR

2018-11-17 Thread Effeietsanders
Effeietsanders closed subtask T202378: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T200955EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, EffeietsandersCc: Xqt, MarcoAurelio, al

[Pywikipedia-bugs] [Maniphest] [Commented On] T209712: Header regex does not work if there is comment ending before the heading

2018-11-17 Thread Dvorapa
Dvorapa added a comment. In T209712#4756092, @rafidaslam wrote: No. I think it's accepted as heading 1, but the text is = Babovky =, am I right? I added: == Bábovky == Parser outputted: first level heading. Therefore it works, but partially (not as one would expect second level heading)TASK DET

[Pywikipedia-bugs] [Maniphest] [Commented On] T209712: Header regex does not work if there is comment ending before the heading

2018-11-17 Thread rafidaslam
rafidaslam added a comment. No. I think it's accepted as heading 1, but the text is = Babovky =, am I right?TASK DETAILhttps://phabricator.wikimedia.org/T209712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: rafidaslamCc: rafidaslam, Aklapper, Dalba, pywikibo

[Pywikipedia-bugs] [Maniphest] [Commented On] T209767: python 2.7 script_tests fails with unicode values in env on Windows

2018-11-17 Thread gerritbot
gerritbot added a comment. Change 474471 merged by jenkins-bot: [pywikibot/core@master] [FIX] Any environment variable added on Windows must be of type str on py 2 https://gerrit.wikimedia.org/r/474471TASK DETAILhttps://phabricator.wikimedia.org/T209767EMAIL PREFERENCEShttps://phabricator.wikimedi

[Pywikipedia-bugs] [Maniphest] [Commented On] T207836: Fix W504 issues across files in the Pywikibot repository

2018-11-17 Thread gerritbot
gerritbot added a comment. Change 474126 merged by jenkins-bot: [pywikibot/core@master] [PEP8] Fix W504 issues in four python scripts https://gerrit.wikimedia.org/r/474126TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpref

[Pywikipedia-bugs] [Maniphest] [Commented On] T207836: Fix W504 issues across files in the Pywikibot repository

2018-11-17 Thread gerritbot
gerritbot added a comment. Change 474479 had a related patch set uploaded (by Nils ANDRE; owner: Nils ANDRE): [pywikibot/core@master] [PEP8] Fix W504 errors in 3 files https://gerrit.wikimedia.org/r/474479TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wiki

[Pywikipedia-bugs] [Maniphest] [Commented On] T209762: script_tests fails for flickrripper.py

2018-11-17 Thread Dvorapa
Dvorapa added a comment. I can see a different issue (https://travis-ci.org/wikimedia/pywikibot/jobs/456314236): == FAIL: test_flickrripper (tests.script_tests.TestScriptSimulate) Test running flickrripper -simulate. -

[Pywikipedia-bugs] [Maniphest] [Commented On] T209762: script_tests fails for flickrripper.py

2018-11-17 Thread Dvorapa
Dvorapa added a comment. After https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/463455/ was merged?TASK DETAILhttps://phabricator.wikimedia.org/T209762EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, Aklapper, Xqt, pywikibot-bugs-list, We

[Pywikipedia-bugs] [Maniphest] [Commented On] T209712: Header regex does not work if there is comment ending before the heading

2018-11-17 Thread Dvorapa
Dvorapa added a comment. I don't know, but it is easy to try: F27246995: Snímek z 2018-11-17 18-00-33.png F27246997: Snímek z 2018-11-17 18-00-25.png No.TASK DETAILhttps://phabricator.wikimedia.org/T209712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dvorapa

[Pywikipedia-bugs] [Maniphest] [Updated] T209767: python 2.7 script_tests fails with unicode values in env on Windows

2018-11-17 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T209767EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, Dalba, jayvdb, Xqt, CucyNoiD, NebulousIris, Wenyi, Gabo

[Pywikipedia-bugs] [Maniphest] [Commented On] T209767: python 2.7 script_tests fails with unicode values in env on Windows

2018-11-17 Thread gerritbot
gerritbot added a comment. Change 474471 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [FIX] Any environment variable added on Windows must be of type str on py 2 https://gerrit.wikimedia.org/r/474471TASK DETAILhttps://phabricator.wikimedia.org/T209767EMAIL PREFERE

[Pywikipedia-bugs] [Maniphest] [Claimed] T209767: python 2.7 script_tests fails with unicode values in env on Windows

2018-11-17 Thread Xqt
Xqt claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T209767EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, pywikibot-bugs-list, Dalba, jayvdb, Xqt, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, Masti, Alchimista

[Pywikipedia-bugs] [Maniphest] [Commented On] T207836: Fix W504 issues across files in the Pywikibot repository

2018-11-17 Thread gerritbot
gerritbot added a comment. Change 474469 had a related patch set uploaded (by Nathan fraignt; owner: Nathan fraignt): [pywikibot/core@master] [PEP8] Fix W504 errors in tests/aspects.py, tests/dry_api_tests.py and tests/script_tests.py https://gerrit.wikimedia.org/r/474469TASK DETAILhttps://phabric

[Pywikipedia-bugs] [Maniphest] [Triaged] T209767: python 2.7 script_tests fails with unicode values in env on Windows

2018-11-17 Thread Xqt
Xqt triaged this task as "Normal" priority. TASK DETAILhttps://phabricator.wikimedia.org/T209767EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, pywikibot-bugs-list, Dalba, jayvdb, Xqt, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721

[Pywikipedia-bugs] [Maniphest] [Created] T209767: python 2.7 script_tests fails with unicode values in env on Windows

2018-11-17 Thread Xqt
Xqt created this task.Xqt added projects: Pywikibot, Pywikibot-tests.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONWhen running script tests on Python 2.7.13 every test fails with TypeError: environment can only contain strings: unicode in os.environ: [(u

[Pywikipedia-bugs] [Maniphest] [Commented On] T207836: Fix W504 issues across files in the Pywikibot repository

2018-11-17 Thread gerritbot
gerritbot added a comment. Change 474460 had a related patch set uploaded (by Nils ANDRE; owner: Nils ANDRE): [pywikibot/core@master] [PEP8] Fix W504 errors in 7 files https://gerrit.wikimedia.org/r/474460TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wiki

[Pywikipedia-bugs] [Maniphest] [Commented On] T209712: Header regex does not work if there is comment ending before the heading

2018-11-17 Thread rafidaslam
rafidaslam added a comment. Btw, @Dvorapa, is header like below is accepted also in Mediawiki? == Heading == I'm a bit doubtful about it since the current header regex catches thatTASK DETAILhttps://phabricator.wikimedia.org/T209712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Pywikipedia-bugs] [Maniphest] [Triaged] T209762: script_tests fails for flickrripper.py

2018-11-17 Thread Xqt
Xqt triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T209762EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, Xqt, pywikibot-bugs-list, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba

[Pywikipedia-bugs] [Maniphest] [Created] T209762: script_tests fails for flickrripper.py

2018-11-17 Thread Xqt
Xqt created this task.Xqt added projects: Pywikibot, Pywikibot-tests.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONscript_tests fails for flickrripper.py after this change: https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/463455/5/tests/script_tests.py

[Pywikipedia-bugs] [Maniphest] [Commented On] T209193: login.py: Assigning to function call which doesn't return

2018-11-17 Thread Zoranzoki21
Zoranzoki21 added a comment. In T209193#4751987, @Xqt wrote: @Zoranzoki21, could you check whether this patch helps. Otherwise you should ignore that test. It is more or less unclear. Helps! Thank you!TASK DETAILhttps://phabricator.wikimedia.org/T209193EMAIL PREFERENCEShttps://phabricator.wikime

[Pywikipedia-bugs] [Maniphest] [Closed] T199094: Add a wellformed help string to flickrripper.py and move todos to phabricator

2018-11-17 Thread Xqt
Xqt closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T199094EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Multichill, gerritbot, Framawiki, Aklapper, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Kieubinhtb, Gabo

[Pywikipedia-bugs] [Maniphest] [Closed] T209193: login.py: Assigning to function call which doesn't return

2018-11-17 Thread Xqt
Xqt closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T209193EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Xqt, Aklapper, Zoranzoki21, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majest

[Pywikipedia-bugs] [Maniphest] [Commented On] T191632: l10n_tests should run only once for every committed patch

2018-11-17 Thread gerritbot
gerritbot added a comment. Change 462912 merged by jenkins-bot: [pywikibot/core@master] [tests] Run L10N tests on Travis only once for each patch https://gerrit.wikimedia.org/r/462912TASK DETAILhttps://phabricator.wikimedia.org/T191632EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pan

[Pywikipedia-bugs] [Maniphest] [Closed] T191632: l10n_tests should run only once for every committed patch

2018-11-17 Thread Framawiki
Framawiki closed this task as "Resolved".Framawiki assigned this task to Xqt. TASK DETAILhttps://phabricator.wikimedia.org/T191632EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, FramawikiCc: gerritbot, Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, C

[Pywikipedia-bugs] [Maniphest] [Unblock] T186323: Travis and Appveyor: Major improvement to test time

2018-11-17 Thread Framawiki
Framawiki closed subtask T191632: l10n_tests should run only once for every committed patch as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T186323EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: gerritbot, Ladsgroup, jayvdb, Dalba, Xqt

[Pywikipedia-bugs] [Maniphest] [Commented On] T199094: Add a wellformed help string to flickrripper.py and move todos to phabricator

2018-11-17 Thread gerritbot
gerritbot added a comment. Change 463455 merged by jenkins-bot: [pywikibot/core@master] [doc] Add a common help string to flickrripper.py https://gerrit.wikimedia.org/r/463455TASK DETAILhttps://phabricator.wikimedia.org/T199094EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/email

[Pywikipedia-bugs] [Maniphest] [Commented On] T183085: [RfC] Drop compat module

2018-11-17 Thread gerritbot
gerritbot added a comment. Change 467645 merged by jenkins-bot: [pywikibot/core@master] [compat] do not actively support compat module https://gerrit.wikimedia.org/r/467645TASK DETAILhttps://phabricator.wikimedia.org/T183085EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpre

[Pywikipedia-bugs] [Maniphest] [Commented On] T207836: Fix W504 issues across files in the Pywikibot repository

2018-11-17 Thread gerritbot
gerritbot added a comment. Change 473749 merged by jenkins-bot: [pywikibot/core@master] [PEP8] Fix W504 errors in pywikibot/site.py script https://gerrit.wikimedia.org/r/473749TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emai

[Pywikipedia-bugs] [Maniphest] [Commented On] T209193: login.py: Assigning to function call which doesn't return

2018-11-17 Thread gerritbot
gerritbot added a comment. Change 473848 merged by jenkins-bot: [pywikibot/core@master] [fix] Return None in LoginManager.getCookie() https://gerrit.wikimedia.org/r/473848TASK DETAILhttps://phabricator.wikimedia.org/T209193EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpref