[Pywikipedia-bugs] [Maniphest] [Triaged] T228578: proxy in our user-config.py is throwing warning for all bots since recent parameter revomal

2019-09-23 Thread Xqt
Xqt triaged this task as "Lowest" priority. TASK DETAIL https://phabricator.wikimedia.org/T228578 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Dalba, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, Hook696, Daryl-TTMG, RomaAmorRoma, 001031840

[Pywikipedia-bugs] [Maniphest] [Commented On] T228578: proxy in our user-config.py is throwing warning for all bots since recent parameter revomal

2019-09-23 Thread Xqt
Xqt added a comment. In T228578#5351496 , @Dvorapa wrote: > Okay, so maybe remove all these deprecated, obsolete and disabled options? (there is cca 10 similar) We can add them to _deprecated_variables which gives a more specific wa

[Pywikipedia-bugs] [Maniphest] [Updated] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread revi
revi added a comment. I don't think so, P9154 logs4 P9155 logs5 TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreference

[Pywikipedia-bugs] [Maniphest] [Updated] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread Xqt
Xqt added a comment. Does it has to do something with T122705 ? TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji, Xqt Cc: Xqt, Huji, Aklapper, py

[Pywikipedia-bugs] [Maniphest] [Reassigned] T91575: Sensible error messages instead of just printing the help

2019-09-23 Thread Xqt
Xqt reassigned this task from Xqt to XZise. TASK DETAIL https://phabricator.wikimedia.org/T91575 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise, Xqt Cc: Xqt, Dvorapa, gerritbot, pywikibot-bugs-list, Aklapper, XZise, Viztor, DannyS712, Wenyi, T

[Pywikipedia-bugs] [Maniphest] [Closed] T91575: Sensible error messages instead of just printing the help

2019-09-23 Thread Xqt
Xqt closed this task as "Resolved". Xqt claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T91575 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Dvorapa, gerritbot, pywikibot-bugs-list, Aklapper, XZise, Viztor, DannyS712, Wenyi

[Pywikipedia-bugs] [Maniphest] [Updated] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread Xqt
Xqt added a project: Pywikibot-login.py. TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji, Xqt Cc: Xqt, Huji, Aklapper, pywikibot-bugs-list, revi, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400

[Pywikipedia-bugs] [Maniphest] [Updated] T233577: sysopnames are still required for tests

2019-09-23 Thread Xqt
Xqt changed the subtype of this task from "Task" to "Bug Report". TASK DETAIL https://phabricator.wikimedia.org/T233577 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Huji, Xqt, Viztor, DannyS712, Wenyi, Tbscho,

[Pywikipedia-bugs] [Maniphest] [Updated] T233577: sysopnames are still required for tests

2019-09-23 Thread Xqt
Xqt added a project: Pywikibot-login.py. TASK DETAIL https://phabricator.wikimedia.org/T233577 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Huji, Xqt, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89,

[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread Xqt
Xqt added a comment. @Huji: I think it would be important see the userinfo content at this state. Using pprint is a good tool for showing ducts: import pprint pprint(self.site.userinfo) Probably it isn’t filled. TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFER

[Pywikipedia-bugs] [Maniphest] [Updated] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread revi
revi added a comment. Huji, see below. P9153 logs3 TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji, revi Cc: Xqt, Huji, Aklapper, pywikibot-b

[Pywikipedia-bugs] [Maniphest] [Commented On] T75370: deletedrevs deprecated

2019-09-23 Thread gerritbot
gerritbot added a comment. Change 538006 **merged** by jenkins-bot: [pywikibot/core@master] [bugfix] Implement deletedrevisions api call https://gerrit.wikimedia.org/r/538006 TASK DETAIL https://phabricator.wikimedia.org/T75370 EMAIL PREFERENCES https://phabricator.wikimedia.org/se

[Pywikipedia-bugs] [Maniphest] [Closed] T75370: deletedrevs deprecated

2019-09-23 Thread Huji
Huji closed this task as "Resolved". Huji removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T75370 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Huji Cc: Anomie, IoannisKydonis, AndyTechGuy, Dufferzafar, Aklappe

[Pywikipedia-bugs] [Maniphest] [Updated] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji, gerritbot Cc: Xqt, Huji, Aklapper, pywikibot-bugs-list, revi, Hook696, Daryl-TTMG, RomaAmorRoma,

[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread gerritbot
gerritbot added a comment. Change 538724 had a related patch set uploaded (by Huji; owner: Huji): [pywikibot/core@master] Check user rights using a unicode string https://gerrit.wikimedia.org/r/538724 TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://p

[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread Huji
Huji added a comment. I was wrong about the cause, but now I know the cause. Here is the line of code that causes it to happen: https://github.com/wikimedia/pywikibot/blob/master/pywikibot/page.py#L1922 The logic `if 'delete' in self.site.userinfo['rights']:` fails because `self.site.us

[Pywikipedia-bugs] [Maniphest] [Claimed] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread Huji
Huji claimed this task. Huji added a comment. Got it. I can confirm that I can replicate it. My suspicion is that the `-user` parameter is causing it somehow. Investigating. TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Pywikipedia-bugs] [Maniphest] [Closed] T233582: assert_valid_iter_params raises AssertionError instead of pywikibot.Error

2019-09-23 Thread Xqt
Xqt closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T233582 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Mpaa, Xqt, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvora

[Pywikipedia-bugs] [Maniphest] [Updated] T233582: assert_valid_iter_params raises AssertionError instead of pywikibot.Error

2019-09-23 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233582 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Maintenance_bot Cc: Aklapper, pywikibot-bugs-list, Mpaa, Xqt, Viztor, DannyS712, Wenyi, Tbs

[Pywikipedia-bugs] [Maniphest] [Commented On] T233582: assert_valid_iter_params raises AssertionError instead of pywikibot.Error

2019-09-23 Thread gerritbot
gerritbot added a comment. Change 538570 **merged** by jenkins-bot: [pywikibot/core@master] [tests] Test for AssertionError instead of pywikibot.Error https://gerrit.wikimedia.org/r/538570 TASK DETAIL https://phabricator.wikimedia.org/T233582 EMAIL PREFERENCES https://phabricator.

[Pywikipedia-bugs] [Maniphest] [Updated] T75370: deletedrevs deprecated

2019-09-23 Thread Xqt
Xqt changed the subtype of this task from "Task" to "Bug Report". TASK DETAIL https://phabricator.wikimedia.org/T75370 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Anomie, IoannisKydonis, AndyTechGuy, Dufferzafar, Aklapper, jayvdb, pywikib

[Pywikipedia-bugs] [Maniphest] [Closed] T233619: reverse parameter in site methods must be boolean

2019-09-23 Thread Xqt
Xqt closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T233619 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Mpaa, Aklapper, pywikibot-bugs-list, Xqt, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvora

[Pywikipedia-bugs] [Maniphest] [Updated] T233619: reverse parameter in site methods must be boolean

2019-09-23 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233619 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Maintenance_bot Cc: Mpaa, Aklapper, pywikibot-bugs-list, Xqt, Viztor, DannyS712, Wenyi, Tbs

[Pywikipedia-bugs] [Maniphest] [Commented On] T233619: reverse parameter in site methods must be boolean

2019-09-23 Thread gerritbot
gerritbot added a comment. Change 538601 **merged** by jenkins-bot: [pywikibot/core@master] [bugfix] Ensure that reverse parameter is boolean https://gerrit.wikimedia.org/r/538601 TASK DETAIL https://phabricator.wikimedia.org/T233619 EMAIL PREFERENCES https://phabricator.wikimedia.

[Pywikipedia-bugs] [Maniphest] [Commented On] T75370: deletedrevs deprecated

2019-09-23 Thread Xqt
Xqt added a comment. The result of deletedrevs ListGenerator and deletedrevisions PropertyGenerator is different. **ListGenerator:** {'ns': 0, 'revisions': [{'comment': 'Framawiki moved page [[Pywikibot bad token test]] ' 'to [[User:Framawiki/pw

[Pywikipedia-bugs] [Maniphest] [Updated] T233619: reverse parameter in site methods must be boolean

2019-09-23 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233619 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, gerritbot Cc: Aklapper, pywikibot-bugs-list, Xqt, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E

[Pywikipedia-bugs] [Maniphest] [Commented On] T233619: reverse parameter in site methods must be boolean

2019-09-23 Thread gerritbot
gerritbot added a comment. Change 538601 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [bugfix] Ensure that reverse parameter is boolean https://gerrit.wikimedia.org/r/538601 TASK DETAIL https://phabricator.wikimedia.org/T233619 EMAIL PREFERENCES ht

[Pywikipedia-bugs] [Maniphest] [Triaged] T233619: reverse parameter in site methods must be boolean

2019-09-23 Thread Xqt
Xqt triaged this task as "Normal" priority. TASK DETAIL https://phabricator.wikimedia.org/T233619 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Xqt, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvo

[Pywikipedia-bugs] [Maniphest] [Created] T233619: reverse parameter in site methods must be boolean

2019-09-23 Thread Xqt
Xqt created this task. Xqt added a project: Pywikibot-tests. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. Restricted Application added a project: Pywikibot. TASK DESCRIPTION == ERROR: test_delet

[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread Xqt
Xqt added a comment. In T233608#5515701 , @Huji wrote: > @revi: Can you please provide an excerpt of the code you are using (or if it is the vanilla `delete.py`, how you are calling it)? I guess this this that listed above: `$ pyt

[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread revi
revi added a comment. It is vanilla `delete.py` within the scripts/ directory in `gerrit.wikimedia.org/r/p/pywikibot/core`. TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: revi Cc: Huji, Aklap

[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread Huji
Huji added a comment. @revi: Can you please provide an excerpt of the code you are using (or if it is the vanilla `delete.py`, how you are calling it)? TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreference

[Pywikipedia-bugs] [Maniphest] [Triaged] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread Xqt
Xqt triaged this task as "High" priority. Xqt changed the subtype of this task from "Task" to "Bug Report". Xqt added a subscriber: Huji. TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Huj

[Pywikipedia-bugs] [Maniphest] [Updated] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread revi
revi added a comment. When I commented out 'sysopnames' from the `user-config.py`... It still fails. P9150 logs2 TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpre

[Pywikipedia-bugs] [Maniphest] [Created] T233608: cannot use delete.py despite being admin on a wiki

2019-09-23 Thread revi
revi created this task. revi added projects: User-revi, Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Here's the log . I am an admin on ko.wikinews

[Pywikipedia-bugs] [Maniphest] [Updated] T233582: assert_valid_iter_params raises AssertionError instead of pywikibot.Error

2019-09-23 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233582 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, gerritbot Cc: Aklapper, pywikibot-bugs-list, Mpaa, Xqt, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318

[Pywikipedia-bugs] [Maniphest] [Claimed] T233582: assert_valid_iter_params raises AssertionError instead of pywikibot.Error

2019-09-23 Thread Xqt
Xqt claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T233582 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Mpaa, Xqt, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostrat

[Pywikipedia-bugs] [Maniphest] [Commented On] T233582: assert_valid_iter_params raises AssertionError instead of pywikibot.Error

2019-09-23 Thread gerritbot
gerritbot added a comment. Change 538570 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [tests] Test for AssertionError instead of pywikibot.Error https://gerrit.wikimedia.org/r/538570 TASK DETAIL https://phabricator.wikimedia.org/T233582 EMAIL PREFER

[Pywikipedia-bugs] [Maniphest] [Created] T233582: assert_valid_iter_params raises AssertionError instead of pywikibot.Error

2019-09-23 Thread Xqt
Xqt created this task. Xqt added a project: Pywikibot-tests. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. Restricted Application added a project: Pywikibot. TASK DESCRIPTION A lot of tests fails due to this exception change: https://travis-ci.org/wikimedia/pywiki

[Pywikipedia-bugs] [Maniphest] [Triaged] T233582: assert_valid_iter_params raises AssertionError instead of pywikibot.Error

2019-09-23 Thread Xqt
Xqt triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T233582 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Mpaa, Xqt, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89,

[Pywikipedia-bugs] [Maniphest] [Triaged] T233577: sysopnames are still required for tests

2019-09-23 Thread Xqt
Xqt triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T233577 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Huji, Xqt, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89,

[Pywikipedia-bugs] [Maniphest] [Created] T233577: sysopnames are still required for tests

2019-09-23 Thread Xqt
Xqt created this task. Xqt added a project: Pywikibot-tests. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. Restricted Application added a project: Pywikibot. TASK DESCRIPTION There is a warning that sysopnames is no longer a supported but some tests still expect it wi