[Pywikipedia-bugs] [Maniphest] [Triaged] T123888: Incorrect default month and day for WbTime

2017-12-06 Thread thiemowmde
thiemowmde triaged this task as "Lowest" priority.thiemowmde added a comment. The default really does not matter. It's actually entirely meaningless. We are using 00 for the month and the day to make it more obvious that there is no month and no day, and they should not be used for

[Pywikipedia-bugs] [Maniphest] [Commented On] T148280: WbTime comparison is incorrect

2017-12-06 Thread thiemowmde
thiemowmde added a comment. I don't know the current implementation, but I know how the datatype is meant to be used: Values that are outside of the precision should not be compared. For example, when comparing 2010-00-00 to 2010-01-01, where both have the precision "year", the co

[Pywikipedia-bugs] [Maniphest] [Triaged] T131453: Implement non-strict __cmp__ for WbTime

2017-12-06 Thread thiemowmde
thiemowmde triaged this task as "Normal" priority.thiemowmde added a comment. Isn't this a duplicate of T148280: WbTime comparison is incorrect?TASK DETAILhttps://phabricator.wikimedia.org/T131453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/T

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T107712: Use narrow API calls instead of wbeditentity in Pywikibot

2015-08-04 Thread thiemowmde
thiemowmde added subscribers: hoo, aude, Addshore. thiemowmde added a comment. I'm a Wikidata dev. What do you expect upstream to do? The wbeditentity API is, in essence, a fallback you can use when there is no specific API for a specific use case. There are several disadvantages in

[Pywikipedia-bugs] [Maniphest] [Updated] T115679: Handle property datatype changing gracefully

2016-01-14 Thread thiemowmde
thiemowmde added a subscriber: thiemowmde. thiemowmde added a project: Patch-For-Review. thiemowmde added a comment. I reworked https://gerrit.wikimedia.org/r/247080 completely. Please review. TASK DETAIL https://phabricator.wikimedia.org/T115679 EMAIL PREFERENCES https

[Pywikipedia-bugs] [Maniphest] [Updated] T115679: Handle property datatype changing gracefully

2016-01-14 Thread thiemowmde
thiemowmde added a project: Wikidata-Sprint-2015-12-01. TASK DETAIL https://phabricator.wikimedia.org/T115679 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, daniel, XZise, Ricordisamoa, hoo, Lydia_Pintscher, Multichill

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T115679: Handle property datatype changing gracefully

2016-01-14 Thread thiemowmde
thiemowmde moved this task to Review on the Wikidata-Sprint-2015-12-01 workboard. TASK DETAIL https://phabricator.wikimedia.org/T115679 WORKBOARD https://phabricator.wikimedia.org/project/board/1647/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To

[Pywikipedia-bugs] [Maniphest] [Commented On] T115679: Handle property datatype changing gracefully

2016-01-27 Thread thiemowmde
thiemowmde added a comment. Have a look into the file ApiQuerySiteinfo.php and how it works. It's impossible to inject something like `meta=wikibase`. Why do you call this "deprecated"? This never existed, as far as I can see. What we currently have in https://gerrit.wikimedia.

[Pywikipedia-bugs] [Maniphest] [Commented On] T115679: Handle property datatype changing gracefully

2016-01-27 Thread thiemowmde
thiemowmde added a comment. Sorry, I got confused. I fixed my comment above. So what you are proposing is a new ApiRepoInfo? Sure, "somebody" could do that, as said above. TASK DETAIL https://phabricator.wikimedia.org/T115679 EMAIL PREFERENCES https://phabricator.wikimedia.or

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T115679: Handle property datatype changing gracefully

2016-01-28 Thread thiemowmde
thiemowmde moved this task to Done on the Wikidata-Sprint-2016-01-19 workboard. TASK DETAIL https://phabricator.wikimedia.org/T115679 WORKBOARD https://phabricator.wikimedia.org/project/board/1710/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To

[Pywikipedia-bugs] [Maniphest] [Commented On] T119226: Very small (or very large) quantity values (represented in scientific notation) result in error in add/update via pywikibot/wikidata API

2016-07-01 Thread thiemowmde
thiemowmde added a comment. I believe what you do is constructing a JSON blob, and that is not allowed to have exponential representation, see https://github.com/DataValues/Number/blob/master/src/DataValues/DecimalValue.php#L43. When you use the parser it is allowed to have other formats, see

[Pywikipedia-bugs] [Maniphest] [Commented On] T119226: Very small (or very large) quantity values (represented in scientific notation) result in error in add/update via pywikibot/wikidata API

2016-07-04 Thread thiemowmde
thiemowmde added a comment. This limitation is not on input values. Use the wbparsevalue API, which is what the wikidata.org UI does and what https://www.wikidata.org/wiki/Help:Statements#Quantitative_values describes, and you can have all kinds of inputs. The resulting QuantityValue data

[Pywikipedia-bugs] [Maniphest] [Commented On] T119226: Very small (or very large) quantity values (represented in scientific notation) result in error in add/update via pywikibot/wikidata API

2016-07-05 Thread thiemowmde
thiemowmde added a comment. Pywikibot should not assume all QuantityValues can be casted to IEEE numbers. For example, a QuantityValue can be "100.054321". Depending on the data types you have in your programming language (if it's single, double or something else) conve

[Pywikipedia-bugs] [Maniphest] [Triaged] T144271: [feature request] DAB7A disconnect sitelinks at clients that are not disambiguations from disambiguation items at Wikidata

2016-08-31 Thread thiemowmde
thiemowmde triaged this task as "Lowest" priority.thiemowmde added projects: Need-volunteer, Pywikibot-Wikidata.Herald added a subscriber: pywikibot-bugs-list. TASK DETAILhttps://phabricator.wikimedia.org/T144271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpref

[Pywikipedia-bugs] [Maniphest] [Updated] T112140: Provide a wrapper function in pywikibot around wbparsevalue

2016-09-05 Thread thiemowmde
thiemowmde removed a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T112140EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArthurPSmith, thiemowmdeCc: Lokal_Profil, Tobias1984, ArthurPSmith, Aklapper, pywikibot-bugs-list, Multichill, Esc3300

[Pywikipedia-bugs] [Maniphest] [Block] T143594: Add unit support to WbQuantity

2016-10-13 Thread thiemowmde
thiemowmde reopened subtask T143910: Add entity_prefix/repoConceptBaseUri to siteinfo as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Multichill, ArthurPSmith, gerritbot,

[Pywikipedia-bugs] [Maniphest] [Unblock] T143594: Add unit support to WbQuantity

2016-10-13 Thread thiemowmde
thiemowmde closed subtask T143910: Add entity_prefix/repoConceptBaseUri to siteinfo as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T143594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Multichill, ArthurPSmith, gerritbot,

[Pywikipedia-bugs] [Maniphest] [Commented On] T123888: Incorrect default month and day for WbTime

2022-12-09 Thread thiemowmde
thiemowmde added a comment. > the values are //not// actually the same. They are not identical, but equal for all practical purposes. It's possible to have both concepts next to each other in the same codebase. As you suggested it's a good idea to make the distinction vis