[Pywikipedia-bugs] [Maniphest] [Commented On] T375279: unexpected root-owned files in /data/project/pywikibot/public_html

2024-09-27 Thread valhallasw
valhallasw added a comment. Moved `public_html.old` to `public_html.old.20240927` to unblock this for now, however manually moving the directory is not a sustainable solution. TASK DETAIL https://phabricator.wikimedia.org/T375279 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T375279: unexpected root-owned files in /data/project/pywikibot/public_html

2024-09-21 Thread valhallasw
valhallasw added a comment. Some more thoughts: - Files were created on Tue 17 Sept 2024 at 15:30 (latest) and Wed 4 Sept 03:00 (.old.20240907 folder). That doesn't immediately suggest a cronjob or something along those lines. - Everything worked between 7 sept and 17 sept -

[Pywikipedia-bugs] [Maniphest] [Commented On] T259702: Add version number for the 3 versions at https://pywikibot.toolforge.org/

2021-11-14 Thread valhallasw
valhallasw added a comment. The main bit of code seems to be in https://github.com/pywikibot/Pywikibot-nightly-creator It looks like the html is not actually updated in any sense -- it's just a static file. TASK DETAIL https://phabricator.wikimedia.org/T259702 EMAIL PREFER

[Pywikipedia-bugs] [Maniphest] [Commented On] T282962: ui_tests are failing on Travis

2021-05-16 Thread valhallasw
valhallasw added a comment. Ooof. That was a long time ago :-) - The job seems to have an unrelated issue wrt generating a musicbrainz family file - My hypothesis: ui_tests monkey-patches ui._print and ui._raw_input as 'lowest level' methods to capture the output. _pri

[Pywikipedia-bugs] [Maniphest] [Commented On] T282964: ui_tests TestWindowsTerminalUnicode and TestWindowsTerminalUnicode are failing on Windows

2021-05-16 Thread valhallasw
valhallasw added a comment. The main issue seems solved when replacing `connect_` by `connect`; however the tests then still fail, most likely because the font settings etc. in Windows 10 have changed significantly over where they were in Windows 7. Given that the code is largely 'b

[Pywikipedia-bugs] [Maniphest] [Commented On] T275982: i18n messages were deleted due to unknown reason

2021-02-28 Thread valhallasw
valhallasw added a comment. @Nikerabbit this is a bit confusing to me. My understanding of the linked news post is that - Outdated translations stay in place if they are in a message file together with non-outdated translations - Outdated translations are removed otherwise Am I

[Pywikipedia-bugs] [Maniphest] [Commented On] T226507: Port pywikibot-core to new pywikibot IV repository (tracking)

2019-06-25 Thread valhallasw
valhallasw added a comment. In T226507#5283832 <https://phabricator.wikimedia.org/T226507#5283832>, @Dvorapa wrote: > @valhallasw We are trying to break as little as possible. So if anyone's cron automatically updates git and it still runs under py2 (per my experienc

[Pywikipedia-bugs] [Maniphest] [Commented On] T226507: Port pywikibot-core to new pywikibot IV repository (tracking)

2019-06-25 Thread valhallasw
valhallasw added a comment. Based on the experience we had with moving from compat to core, I would advice against a new repository for the continued development. I'm afraid it will lead to a slow death of v3 (with lots of people not moving, and then once they move it becomes very pa

[Pywikipedia-bugs] [Maniphest] [Commented On] T137805: API action=login is deprecated

2019-06-11 Thread valhallasw
valhallasw added a comment. In T137805#5248010 <https://phabricator.wikimedia.org/T137805#5248010>, @Dvorapa wrote: > Of course, but still we have different Botpassword for Beta Cluster and different for wikis, which is a thing we need to overcome somehow. I suggested t

[Pywikipedia-bugs] [Maniphest] [Commented On] T137805: API action=login is deprecated

2019-05-31 Thread valhallasw
valhallasw added a comment. - Wouldnt `("en", "wikipedia", "my_username", BotPassword("botpassword suffix", "bot password"))` work in the password file? See `LoginManager.readPassword` in `login.py`. - If not, that sounds like

[Pywikipedia-bugs] [Maniphest] [Unassigned] T143217: archivebot.py exception: ValueError: unsupported format character '|' (0x7c) at index 43

2019-03-19 Thread valhallasw
valhallasw removed valhallasw as the assignee of this task. valhallasw added a comment. Restricted Application added a subscriber: Liuxinyu970226. Apparently I was still assigned to this; unassigning. (or we could close this -- maybe crashing isn't so bad, as this did lead to the issue

[Pywikipedia-bugs] [Maniphest] [Edited] T217513: bug in newitem.py

2019-03-03 Thread valhallasw
valhallasw updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T217513 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: Aklapper, pywikibot-bugs-list, Steenth, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis

[Pywikipedia-bugs] [Maniphest] [Updated] T122091: fixing_redirects.py / replace_links fails on links such as [[{{2001}}]]

2019-01-20 Thread valhallasw
valhallasw added a comment. Looking at the stack trace, the user is running a very old version of pywikibot; the use of textlib.replace_links was removed in november 2015 (8a7c42f5). The fix looks OK, but the issue is likely also present in the textlib.replace_links implementation; it might make

[Pywikipedia-bugs] [Maniphest] [Commented On] T208463: _tkinter in PAWS

2018-10-31 Thread valhallasw
valhallasw added a comment. imagecopy.py displays a graphical interface to verify which images should be transferred. As PAWS is a web based environment, this interface cannot be displayed. imagecopy.py does have a mode where no verification is requested (using the -always flag). If you pre

[Pywikipedia-bugs] [Maniphest] [Commented On] T188231: listpages logging fails with UnicodeEncodeError

2018-06-20 Thread valhallasw
valhallasw added a comment. @Xqt: could you add a breakpoint/print statement to File "C:\Program Files (x86)\Python36-32\lib\logging\__init__.py", line 994, in emit stream.write(msg) to figure out which stream this is going to? Is this the console or is it trying to log to a

[Pywikipedia-bugs] [Maniphest] [Commented On] T196548: generate_user_files always sets en.wikipedia as default family/code

2018-06-06 Thread valhallasw
valhallasw added a comment. Did some debugging; the issue seems that we always set family=wikipedia and code=en in generate_user_files.py; see the updated description.TASK DETAILhttps://phabricator.wikimedia.org/T196548EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Pywikipedia-bugs] [Maniphest] [Retitled] T196548: generate_user_files always sets en.wikipedia as default family/code

2018-06-06 Thread valhallasw
valhallasw renamed this task from "Creating new family creates inappropriate user_config file" to "generate_user_files always sets en.wikipedia as default family/code".valhallasw edited projects, added Pywikibot-core; removed pywikibot-bots-FLOSSbot.valhallasw updated the tas

[Pywikipedia-bugs] [Maniphest] [Commented On] T187008: Pywikibot documentation on readthedocs is horribly outdated

2018-06-06 Thread valhallasw
valhallasw added a comment. You should have access now.TASK DETAILhttps://phabricator.wikimedia.org/T187008EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: zhuyifei1999, XZise, Lahi, Dalba, Framawiki, Xqt, Aklapper, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Commented On] T187008: Pywikibot documentation on readthedocs is horribly outdated

2018-06-05 Thread valhallasw
valhallasw added a comment. I couldn't get the redirects to work, but you're more than welcome to fiddle with the settings yourself. What is your readthedocs username?TASK DETAILhttps://phabricator.wikimedia.org/T187008EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett

[Pywikipedia-bugs] [Maniphest] [Commented On] T133445: All pywikibot logging seems to be dumped in pwb-bot.log instead of different files

2018-06-04 Thread valhallasw
valhallasw added a comment. Maybe it makes more sense in a table: python script.pypython pwb.py script.py script calls handle_argsscript-bot.logscript-bot.log script only calls pywikibot.logscript-bot.logpwb-bot.log so if a script doesn't call handle_args, the behavior differs between ca

[Pywikipedia-bugs] [Maniphest] [Commented On] T133445: All pywikibot logging seems to be dumped in pwb-bot.log instead of different files

2018-06-04 Thread valhallasw
valhallasw added a comment. In T133445#4251388, @Dvorapa wrote: I thought this is called automatically when running bot.py (so every time when running any class built on Bot class)? Yes, I believe the Bot class will call handle_args. I think Maarten's point is that pwb.py should be transp

[Pywikipedia-bugs] [Maniphest] [Commented On] T187008: Pywikibot documentation on readthedocs is horribly outdated

2018-06-04 Thread valhallasw
valhallasw added a comment. (I did not delete the project to prevent namejacking)TASK DETAILhttps://phabricator.wikimedia.org/T187008EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: zhuyifei1999, XZise, Lahi, Dalba, Framawiki, Xqt, Aklapper

[Pywikipedia-bugs] [Maniphest] [Commented On] T187008: Pywikibot documentation on readthedocs is horribly outdated

2018-06-04 Thread valhallasw
valhallasw added a comment. Sorry for the slow response! I found a 'hide' button and the readthedocs now return an error. Is there anyone I can add to the maintainers list? Currently only jayvdb and myself are on it.TASK DETAILhttps://phabricator.wikimedia.org/T187008EMAIL PREFER

[Pywikipedia-bugs] [Maniphest] [Commented On] T192732: Rename pywikipedia to pywikibot on Toolforge

2018-04-23 Thread valhallasw
valhallasw added a comment. I've symlinked /shared/pywikibot/core to /data/project/pywikibot/public_html/core, as we might want to add other linked folders at some point as well.TASK DETAILhttps://phabricator.wikimedia.org/T192732EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/

[Pywikipedia-bugs] [Maniphest] [Commented On] T187737: Use path in Python script calling

2018-02-19 Thread valhallasw
valhallasw added a comment. You can pass the full path of the file to pwb.py, so python pwb.py projects/wikidatafix/fix_everything_in_wikidata.py (or pwb.py projects\wikidatafix\fix_everything_in_wikidata.py on Windows) should work.TASK DETAILhttps://phabricator.wikimedia.org/T187737EMAIL

[Pywikipedia-bugs] [Maniphest] [Closed] T57145: weblinkchecker.LinkChecker URL unicode problems

2017-11-03 Thread valhallasw
valhallasw closed this task as "Invalid".valhallasw added a comment. Given that weblinkchecker no longer uses LinkChecker. It exists only for backwards compatibility, and is deprecated. and we're talking about a 4.5 year old bug, I think closing makes sense. @Cyberpower678:

[Pywikipedia-bugs] [Maniphest] [Commented On] T178777: Pywikibot is not installable on Ubuntu Precise without updating system site packages

2017-10-22 Thread valhallasw
valhallasw added a comment. I'm confused -- in that log file, the pip install --upgrade pip setuptools happens even later (after building user-config.py), not before the other pip installs? I would think that upgrading pip should be the first thing travis does after activating the virtualenv

[Pywikipedia-bugs] [Maniphest] [Commented On] T178777: Pywikibot is not installable on Ubuntu Precise without updating system site packages

2017-10-22 Thread valhallasw
valhallasw added a comment. That's... odd. Could it be because the pip and setuptools upgrade happens after installing pytest-httpbin? I.e, should the script maybe do $ if [[ "$DIST" == "precise-sudo" ]]; then pip install --upgrade pip setuptools; fi $ pip install -r dev-

[Pywikipedia-bugs] [Maniphest] [Commented On] T178777: Pywikibot is not installable on Ubuntu Precise without updating system site packages

2017-10-22 Thread valhallasw
valhallasw added a comment. pip install --upgrade pip setuptools in the travis script (after the venv is activated) should help to get them updated.TASK DETAILhttps://phabricator.wikimedia.org/T178777EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To

[Pywikipedia-bugs] [Maniphest] [Closed] T178067: Make L10n-bot update commit hash in scripts/i18n again

2017-10-14 Thread valhallasw
valhallasw closed this task as "Resolved".valhallasw claimed this task.valhallasw added a comment. Thank you for your help, @Paladox! https://github.com/wikimedia/pywikibot-core/commit/474c081e2f0f69b01dd6098d92ee15808134ca76TASK DETAILhttps://phabricator.wikimedia.org/T1

[Pywikipedia-bugs] [Maniphest] [Commented On] T178067: Make L10n-bot update commit hash in scripts/i18n again

2017-10-14 Thread valhallasw
valhallasw added a comment. I believe Gerrit automatically updates the references based on .gitmodules (https://github.com/wikimedia/pywikibot-core/blob/master/.gitmodules). See https://gerrit-review.googlesource.com/Documentation/user-submodules.html for documentation; it's also use

[Pywikipedia-bugs] [Maniphest] [Updated] T173498: Travis jobs with OAuth wait for password input and get terminated

2017-09-03 Thread valhallasw
valhallasw added subscribers: jayvdb, valhallasw.valhallasw added a comment. I don't know how exactly travis is configured -- I vaguely remember @jayvdb set this up (T104306 is vaguely related). Given that the Travis account is 'https://travis-ci.org/wikimedia/pywikibot-core', I

[Pywikipedia-bugs] [Maniphest] [Closed] T171886: installing pywikibot with pip fails because the package isn't a git repository; setup.py is unable to find the version of pywikibot

2017-08-01 Thread valhallasw
valhallasw closed this task as "Resolved".valhallasw claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T171886EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: valhallasw, zhuyifei1999, Framawiki, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Commented On] T171886: installing pywikibot with pip fails because the package isn't a git repository; setup.py is unable to find the version of pywikibot

2017-08-01 Thread valhallasw
valhallasw added a comment. The last upload contained some local changes that caused this exception to bubble up (rather than being ignored). I've uploaded a new version, and everything should be OK again :-)TASK DETAILhttps://phabricator.wikimedia.org/T171886EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T169734: Kill branch 2.0

2017-07-15 Thread valhallasw
valhallasw added a comment. Done!TASK DETAILhttps://phabricator.wikimedia.org/T169734EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, valhallaswCc: Ladsgroup, zhuyifei1999, Dvorapa, Multichill, valhallasw, MarcoAurelio, Aklapper, Xqt, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Commented On] T163349: makecat.py fails under python 3: TypeError: can't concat bytes to str

2017-07-14 Thread valhallasw
valhallasw added a comment. workingcatname.encode('ascii', 'xmlcharrefreplace') + '_exclude.txt') This is wrong -- workingcatname.encode('ascii', 'xmlcharrefreplace') will create a bytes object, and this cannot be concatenated with the &#

[Pywikipedia-bugs] [Maniphest] [Created] T168210: ItemPage.set_redirect_target should throw an Exception on error

2017-06-18 Thread valhallasw
valhallasw created this task.valhallasw added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONCurrently errors are silently ignored: if data.get('success', 0): del self.latest_revision_id self._isredir = True self._r

[Pywikipedia-bugs] [Maniphest] [Closed] T159029: test_newpages_default sometimes fails on beta sites due to lack of new pages

2017-06-17 Thread valhallasw
valhallasw closed this task as "Resolved".valhallasw added a comment. Added a new page on zh.wp.beta; this resolved the issue: https://travis-ci.org/magul/pywikibot-core/jobs/244040241#L1134TASK DETAILhttps://phabricator.wikimedia.org/T159029EMAIL PREFERENCEShttps://phabricator.wik

[Pywikipedia-bugs] [Maniphest] [Unblock] T151145: Make Travis (and Appveyor) pass again

2017-06-17 Thread valhallasw
valhallasw closed subtask T159029: test_newpages_default sometimes fails on beta sites due to lack of new pages as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T151145EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, valhallaswCc:

[Pywikipedia-bugs] [Maniphest] [Reopened] T159029: test_newpages_default sometimes fails on beta sites due to lack of new pages

2017-06-17 Thread valhallasw
valhallasw reopened this task as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T159029EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, valhallaswCc: gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, MayS, Mdupo

[Pywikipedia-bugs] [Maniphest] [Block] T151145: Make Travis (and Appveyor) pass again

2017-06-17 Thread valhallasw
valhallasw reopened subtask T159029: test_newpages_default sometimes fails on beta sites due to lack of new pages as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T151145EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, valhallaswCc:

[Pywikipedia-bugs] [Maniphest] [Retitled] T159029: test_newpages_default sometimes fails on beta sites due to lack of new pages

2017-06-17 Thread valhallasw
valhallasw renamed this task from "test_newpages_default is failing on beta wikisource" to "test_newpages_default sometimes fails on beta sites due to lack of new pages".valhallasw removed a project: Patch-For-Review.valhallasw updated the task description. (Show Deta

[Pywikipedia-bugs] [Maniphest] [Commented On] T167463: weblinkchecker: Use https instead of http for web.archive.org

2017-06-13 Thread valhallasw
valhallasw added a comment. Aha. It seems getInternetArchiveURL uses https://archive.org/wayback/available?url="">, which also still returns an http link. So the search-and-replace should be moved to setLinkDead.TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PRE

[Pywikipedia-bugs] [Maniphest] [Commented On] T166950: Reduce the number of stylistic checks

2017-06-13 Thread valhallasw
valhallasw added a comment. Another annoyance: being forced to add 'documentation' to functions in test suites. In general, we should keep in mind that requiring documentation pushes towards longer functions (because splitting up a function becomes tedious). At the same time, I think i

[Pywikipedia-bugs] [Maniphest] [Commented On] T167463: weblinkchecker: Use https instead of http for web.archive.org

2017-06-13 Thread valhallasw
valhallasw added a comment. What are we supposed to see there? There doesn't seem to be a web.archive.org link there?TASK DETAILhttps://phabricator.wikimedia.org/T167463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: valhallasw, gerr

[Pywikipedia-bugs] [Maniphest] [Created] T167726: test_imageharness breaks tests

2017-06-12 Thread valhallasw
valhallasw created this task.valhallasw added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONhttps://travis-ci.org/wikimedia/pywikibot-core/jobs/241804531TASK DETAILhttps://phabricator.wikimedia.org/T167726EMAIL PREFERENCEShttps

[Pywikipedia-bugs] [Maniphest] [Unblock] T75704: Python 3 library support

2017-06-11 Thread valhallasw
valhallasw closed subtask T115428: imageharvest and panoramiopicker uses BeautifulSoup version 3 instead of bs4 as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T75704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: Abbe98

[Pywikipedia-bugs] [Maniphest] [Closed] T115428: imageharvest and panoramiopicker uses BeautifulSoup version 3 instead of bs4

2017-06-11 Thread valhallasw
valhallasw closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T115428EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: darthbhyrava, valhallaswCc: Spaceman5, TerraCodes, gerritbot, AbdealiJK, darthbhyrava, StudiesWorld, XZise

[Pywikipedia-bugs] [Maniphest] [Commented On] T57078: replace.py -match option

2017-06-10 Thread valhallasw
valhallasw added a comment. In T57078#3337396, @Dvorapa wrote: -grep matches regex in page title No, -grep matches the page contents. -titleregex matches the page title. This is clearly documented (https://github.com/wikimedia/pywikibot-core/blob/master/pywikibot/pagegenerators.py#L307, https

[Pywikipedia-bugs] [Maniphest] [Commented On] T153501: TestSiteGenerators.testLinkMethods is failing on Travis CI

2017-06-06 Thread valhallasw
valhallasw added a comment. No, of course it's not about the lines in between, but the time in between. And time does depend on the code executed, mostly because that code typically also performs more API requests. In this specific case it won't help much (because the different pag

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T153501: TestSiteGenerators.testLinkMethods is failing on Travis CI

2017-06-06 Thread valhallasw
valhallasw added subscribers: Dalba, valhallasw.valhallasw added a comment. @Dalba Is this patch supposed to resolve T92856/T153501 or is it a WIP? Because I do not see how disabling the cache will resolve the issue. Here is what is happening in T153501: The test suite fetches the list of main

[Pywikipedia-bugs] [Maniphest] [Created] T166950: Reduce the number of stylistic checks

2017-06-03 Thread valhallasw
valhallasw created this task.valhallasw added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONCurrently, we have a large number of flake8 checks: flake8 (pep8) pydocstyle https://pypi.python.org/pypi/pydocstyle OpenStack style guidelines (https

[Pywikipedia-bugs] [Maniphest] [Closed] T166484: IndexError when showing a diff

2017-05-30 Thread valhallasw
valhallasw closed this task as "Resolved".valhallasw added a comment. Luckily Mpaa is better at reading source code than I am :D. Thanks for the patch!TASK DETAILhttps://phabricator.wikimedia.org/T166484EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreference

[Pywikipedia-bugs] [Maniphest] [Closed] T166484: IndexError when showing a diff

2017-05-29 Thread valhallasw
valhallasw closed this task as "Resolved".valhallasw claimed this task.valhallasw added a comment. As far as I can see, inspect.stack is no longer used anywhere, so this issue should be resolved.TASK DETAILhttps://phabricator.wikimedia.org/T166484EMAIL PREFERENCEShttps://phabricator.wik

[Pywikipedia-bugs] [Maniphest] [Closed] T130568: Pywikibot 3.0

2017-05-28 Thread valhallasw
valhallasw closed this task as "Resolved".valhallasw claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T130568EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, jayvdb, Magul, Tb

[Pywikipedia-bugs] [Maniphest] [Changed Status] T72936: Important tasks to be solved (tracking)

2017-05-28 Thread valhallasw
valhallasw changed the task status from "Declined" to "Invalid".valhallasw added a comment. @Xqt prioritized the tasks, and as we are back to a rolling release schedule, this task no longer serves its original purpose.TASK DETAILhttps://phabricator.wikimedia.org/T72936EM

[Pywikipedia-bugs] [Maniphest] [Commented On] T165911: Get the u'' to '' string conversion over with in Pywikibot

2017-05-28 Thread valhallasw
valhallasw added a comment. In T165911#3296939, @binbot wrote: Us will always cause problem in Python 3000. Not, they don't. The u'' prefix has been allowed since Python 3.3, which was released in 2012. Official support for Python 3.2 was dropped in Feb 2016. There is absolute

[Pywikipedia-bugs] [Maniphest] [Updated] T164095: pypi package does not contain scripts folder

2017-05-28 Thread valhallasw
valhallasw added a comment. We have packages that contain scripts, but they are not the PyPI packages. Those can be found at https://tools.wmflabs.org/pywikibot/ . See also: T57584: Don't clutter /usr/lib/python2.7/site-packages/ T115784: pip install . in pywikibot should install script

[Pywikipedia-bugs] [Maniphest] [Closed] T67176: pip install pywikibot is not straightforward

2017-05-28 Thread valhallasw
valhallasw closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T67176EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jayvdb, valhallaswCc: DrTrigon, AbdealiJK, Ash_Crow, Negative24, JeanFred, Fhocutt, Aklapper, noirbiza

[Pywikipedia-bugs] [Maniphest] [Unblock] T72936: Important tasks to be solved (tracking)

2017-05-28 Thread valhallasw
valhallasw closed subtask T67176: pip install pywikibot is not straightforward as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T72936EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: Multichill, Edgars2007, Mpaa, Aklapper, X

[Pywikipedia-bugs] [Maniphest] [Commented On] T155356: Make -notitle the default behavior in pagefromfile.py

2017-05-28 Thread valhallasw
valhallasw added a comment. I think the reasoning is that, especially for new articles, the page title is generally part of the first sentence of an article, e.g., '''Wikipedia''' is a free [[online encyclopedia]] with the aim to allow anyone to edit in which case

[Pywikipedia-bugs] [Maniphest] [Commented On] T166362: wbGeoShape.fromWikibase() and WbTabularData.fromWikibase() broken

2017-05-26 Thread valhallasw
valhallasw added a comment. From https://github.com/wikimedia/pywikibot-core/commit/ee30a681c2b6d389bdbfc01933b73ac052590b55#diff-9d6a0f7bf454d9a42f89a92d169bf96bR1007 , I think the parameter data_site in fromWikibase can just be dropped.TASK DETAILhttps://phabricator.wikimedia.org/T166362EMAIL

[Pywikipedia-bugs] [Maniphest] [Updated] T67161: PreloadingPageGenerator should allow specifying parameters to preload

2017-05-25 Thread valhallasw
valhallasw removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T67161EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: valhallasw, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, jayvdb

[Pywikipedia-bugs] [Maniphest] [Commented On] T164095: pypi package does not contain scripts folder

2017-04-28 Thread valhallasw
valhallasw added a comment. This is supposed to be the case, as the pypi package is supposed to be used as library, not as command line tool. If we want to support this, we should: make sure pwb.py is deployed in a /bin/ directory make sure scripts/ is deployed under e.g. site-packages

[Pywikipedia-bugs] [Maniphest] [Created] T162560: Update nightlies with prepackaged 3.x releases

2017-04-09 Thread valhallasw
valhallasw created this task.valhallasw added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONhttp://tools.wmflabs.org/pywikibot/core_stable.zip is a one-download package, which includes httplib2, so that users just have to unpack it (and no

[Pywikipedia-bugs] [Maniphest] [Commented On] T152907: Release a new version of pywikibot

2017-04-04 Thread valhallasw
valhallasw added a comment. I have pushed pywikibot-3.0.20170403.tar.gz to PyPI.TASK DETAILhttps://phabricator.wikimedia.org/T152907EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: gerritbot, zhuyifei1999, Wesalius, Dalba, MZMcBride, Xqt, jayvdb

[Pywikipedia-bugs] [Maniphest] [Commented On] T153308: Install requests_oauthlib at Toollabs exec nodes

2016-12-17 Thread valhallasw
valhallasw added a comment. It is installed, just not on precise nodes, as ubuntu does not package python-requests-oauthlib for precise.TASK DETAILhttps://phabricator.wikimedia.org/T153308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: bd808

[Pywikipedia-bugs] [Maniphest] [Merged] T130529: Install python-requests-oauthlib on labs

2016-12-17 Thread valhallasw
valhallasw added subscribers: Urbanecm, bd808, Zppix, valhallasw, pywikibot-bugs-list.valhallasw merged a task: T153308: Install requests_oauthlib at Toollabs exec nodes. TASK DETAILhttps://phabricator.wikimedia.org/T130529EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Pywikipedia-bugs] [Maniphest] [Updated] T153308: Install requests_oauthlib at Toollabs exec nodes

2016-12-17 Thread valhallasw
valhallasw closed this task as a duplicate of T130529: Install python-requests-oauthlib on labs. TASK DETAILhttps://phabricator.wikimedia.org/T153308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: bd808, zhuyifei1999, Zppix, yuvipanda

[Pywikipedia-bugs] [Maniphest] [Edited] T152350: Weblinkchecker should throttle connections to the same host

2016-12-04 Thread valhallasw
valhallasw edited the task description. (Show Details) EDIT DETAILS...Access log from external site: {F4978348} (only visible to selected users)TASK DETAILhttps://phabricator.wikimedia.org/T152350EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc

[Pywikipedia-bugs] [Maniphest] [Created] T152350: Weblinkchecker should throttle connections to the same host

2016-12-04 Thread valhallasw
valhallasw created this task.valhallasw added projects: Pywikibot-weblinkchecker.py, Tool-Labs.Herald added subscribers: pywikibot-bugs-list, Aklapper.Herald added a project: Labs. TASK DESCRIPTION(and probably listen to robots.txt in most cases as well) In November 2016, a weblinkchecker bot on

[Pywikipedia-bugs] [Maniphest] [Commented On] T148321: "UnicodeDecodeError: 'ascii' codec can't decode byte 0xff in position 2361: ordinal not in range(128)" on flickrripper

2016-10-17 Thread valhallasw
valhallasw added a comment. I think this might just be another version of T148321: "UnicodeDecodeError: 'ascii' codec can't decode byte 0xff in position 2361: ordinal not in range(128)" on flickrripper. The solution is fixing the bytes/unicode mess in our comms layer, bu

[Pywikipedia-bugs] [Maniphest] [Commented On] T147654: win32_unicode does not correctly handle different console configurations under Python 3

2016-10-16 Thread valhallasw
valhallasw added a comment. IDLE on Python 3.5 reports: Cannot find buffer interface for stdout, stderr or stdin. Using (incorrect) text interfaces instead. This is likely to break on non-ascii text. (i.e. 'hey, I'm not patching your stdout and just passing it through without looking&#

[Pywikipedia-bugs] [Maniphest] [Retitled] T147654: win32_unicode does not correctly handle different console configurations under Python 3

2016-10-16 Thread valhallasw
valhallasw changed the title from "TypeError when redirecting output of listpages.py to file" to "win32_unicode does not correctly handle different console configurations under Python 3". TASK DETAILhttps://phabricator.wikimedia.org/T147654EMAIL PREFERENCEShttps://phabr

[Pywikipedia-bugs] [Maniphest] [Updated] T147654: TypeError when redirecting output of listpages.py to file

2016-10-16 Thread valhallasw
valhallasw added a subscriber: Dalba.valhallasw merged a task: T148318: pywikibot.output raises TypeError in PyCharm's console. TASK DETAILhttps://phabricator.wikimedia.org/T147654EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc:

[Pywikipedia-bugs] [Maniphest] [Merged] T148318: pywikibot.output raises TypeError in PyCharm's console

2016-10-16 Thread valhallasw
valhallasw closed this task as a duplicate of T147654: TypeError when redirecting output of listpages.py to file. TASK DETAILhttps://phabricator.wikimedia.org/T148318EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: valhallasw, Aklapper, pywikibot

[Pywikipedia-bugs] [Maniphest] [Commented On] T147654: TypeError when redirecting output of listpages.py to file

2016-10-16 Thread valhallasw
valhallasw added a comment. Bah. The issue is that there are too many different situations that are subtly different, but that breaks everything. the user uses the standard windows console. Here, we want to wrap stdout etc and use the unicode console output functions the user redirects the

[Pywikipedia-bugs] [Maniphest] [Commented On] T134563: Implement 'mark for deletion' for ItemPage

2016-10-04 Thread valhallasw
valhallasw added a comment. I think this issue may have solved itself (sort of): valhallasw@maeglin:pywikibot-core$ python pwb.py shell Welcome to the Pywikibot interactive shell! >>> from pywikibot import ItemPage >>> from pywikibot import Site >>> p = pywikibot.It

[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception

2016-10-04 Thread valhallasw
valhallasw added a comment. I clearly should have written a better bug report, because I can't reproduce the exact point ;-) This is about the functions 'error' and 'exception' in https://github.com/wikimedia/pywikibot-core/blob/master/pywikibot/logging.py. def output

[Pywikipedia-bugs] [Maniphest] [Commented On] T145372: generate_user_files.py is no longer able to create a small user-config-py

2016-09-12 Thread valhallasw
valhallasw added a comment. I think we should copy all settings, but we should probably not actually set them. In other words, one should get a file ## This is mainly intended to support setting the ## X-Wikimedia-Debug header, which is sometimes ## needed to debug issues with Wikimedia sites

[Pywikipedia-bugs] [Maniphest] [Commented On] T145273: Weblinkchecker: Can't start new thread

2016-09-10 Thread valhallasw
valhallasw added a comment. Ah, I had not realized weblinkchecker creates 50 threads (for 50 pages at a time). Good to hear that it's working correctly now!TASK DETAILhttps://phabricator.wikimedia.org/T145273EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferenc

[Pywikipedia-bugs] [Maniphest] [Commented On] T145273: Weblinkchecker: Can't start new thread

2016-09-10 Thread valhallasw
valhallasw added a comment. Right, so a shared webhost. I'm not surprised that they provide you with severely limited SSH access -- that access is meant for deployments and debugging, not for running tools like Pywikibot. Pywikibot uses threads in more places, so it's unlikely that y

[Pywikipedia-bugs] [Maniphest] [Commented On] T145273: Weblinkchecker: Can't start new thread

2016-09-10 Thread valhallasw
valhallasw added a comment. File "/chroot/python27/lib/python2.7/threading.py", line 743, in start What kind of host are you running this on? Are you allowed to run more than a single thread/process?TASK DETAILhttps://phabricator.wikimedia.org/T145273EMAIL PREFER

[Pywikipedia-bugs] [Maniphest] [Commented On] T67176: pip install pywikibot is not straightforward

2016-09-04 Thread valhallasw
valhallasw added a comment. In T67176#2398705, @DrTrigon wrote: So we have 2 different kinds of "packages"? 1 containing pywikibot-core/pywikibot/ and 1 containing pywikibot-core/ and pywikibot-core/scripts/ etc.? More or less, yes. One which you pip install (for use in 3rd par

[Pywikipedia-bugs] [Maniphest] [Commented On] T144692: Port saving options from compat

2016-09-04 Thread valhallasw
valhallasw added a comment. In T144692#2607590, @binbot wrote: I don't know listpages as I always used compat. Then could you please set up core and test whether listpages solves this use case? -save/savenew (with flush() after every save) works reliably even for very slow, long search

[Pywikipedia-bugs] [Maniphest] [Updated] T144692: Port saving options from compat

2016-09-04 Thread valhallasw
valhallasw added a comment. I've merged T57689: Implement -save option on replace.py core here because this is a more general task (not just -save). -save was implemented in https://phabricator.wikimedia.org/rSVNP8700 -saveexc was implemented in https://phabricator.wikimedia.org/rSVN

[Pywikipedia-bugs] [Maniphest] [Merged] T57689: Implement -save option on replace.py core

2016-09-04 Thread valhallasw
valhallasw closed this task as a duplicate of T144692: Port saving options from compat. TASK DETAILhttps://phabricator.wikimedia.org/T57689EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Omegat, valhallaswCc: 4nn1l2, Thibaut120094, Dvorapa, binbot, Vituzzu

[Pywikipedia-bugs] [Maniphest] [Updated] T144692: Port saving options from compat

2016-09-04 Thread valhallasw
valhallasw added subscribers: bzimport, Omegat, 4nn1l2, Thibaut120094, Dvorapa, Vituzzu, XZise, gerritbot, Ricordisamoa, Ninovolador, Xqt, jayvdb.valhallasw merged a task: T57689: Implement -save option on replace.py core. TASK DETAILhttps://phabricator.wikimedia.org/T144692EMAIL PREFERENCEShttps

[Pywikipedia-bugs] [Maniphest] [Commented On] T144694: Port -first from compat

2016-09-04 Thread valhallasw
valhallasw added a comment. This is a modifier for the -page: and -file: pagegenerators?TASK DETAILhttps://phabricator.wikimedia.org/T144694EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: valhallasw, Aklapper, pywikibot-bugs-list, binbot

[Pywikipedia-bugs] [Maniphest] [Commented On] T57078: replace.py -match option

2016-09-04 Thread valhallasw
valhallasw added a comment. As far as I can see, the -grep option provides this: -grep A regular _expression_ that needs to match the article otherwise the page won't be returned. Multiple -grep:regexpr can be provided and the page

[Pywikipedia-bugs] [Maniphest] [Commented On] T144157: Pywikibot should create *.lwp files with 600 mode so nobody except its owner is able to read it

2016-09-03 Thread valhallasw
valhallasw added a comment. Alternatively, we could try to support Windows ACLs (see e.g. http://stackoverflow.com/a/27500472/118671 ) , but ACLs are complicated, and I think all of our windows users are on (effectively) single-user systems, where files that are readable for all is less of an

[Pywikipedia-bugs] [Maniphest] [Commented On] T144157: Pywikibot should create *.lwp files with 600 mode so nobody except its owner is able to read it

2016-09-03 Thread valhallasw
valhallasw added a comment. Windows likely doesn't support os.chmod(). We can just remove the warning -- that's what we do for passwordfile.TASK DETAILhttps://phabricator.wikimedia.org/T144157EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: va

[Pywikipedia-bugs] [Maniphest] [Commented On] T143937: site.unblockuser sends malformed/misencoded api request

2016-08-28 Thread valhallasw
valhallasw added a comment. I assume that where the code ran a .decode('latin-1') for DekelE, it runs a .decode('utf-8') for you. It's not clear to me whether that's related to the wiki or to some environmental setting (e.g. the console/windows encoding?). Neverthe

[Pywikipedia-bugs] [Maniphest] [Commented On] T144023: Maxlag lag incorrectly causing bot to crash with pywikibot.data.api.APIError

2016-08-28 Thread valhallasw
valhallasw added a comment. With r307119 and 120 merged, this should be resolved for now, but the 'how long should we wait' issue remains. In T144023#2588523, @Xqt wrote: I don't think that it is fundamentally incorrect. The maxlag parameter is a good enough prediction what w

[Pywikipedia-bugs] [Maniphest] [Commented On] T143217: archivebot.py exception: ValueError: unsupported format character '|' (0x7c) at index 43

2016-08-26 Thread valhallasw
valhallasw added a comment. Old checkout of the i18n files? The (broken) translation was added at the end of july.TASK DETAILhttps://phabricator.wikimedia.org/T143217EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: Mpaa, Xqt, valhallasw, Aklapper

[Pywikipedia-bugs] [Maniphest] [Reopened] T143217: archivebot.py exception: ValueError: unsupported format character '|' (0x7c) at index 43

2016-08-26 Thread valhallasw
valhallasw reopened this task as "Open".valhallasw added a comment. The i18n changes are merged every now and then to the repository, and the labs files are then automatically updated a few hours afterwards. I'm also reopening this issue -- I just realized that the issue is no

[Pywikipedia-bugs] [Maniphest] [Commented On] T144023: Maxlag lag incorrectly causing bot to crash with pywikibot.data.api.APIError

2016-08-26 Thread valhallasw
valhallasw added a comment. I think using the maxlag data is fundamentally incorrect: having N seconds lag does not imply that the lag will be resolved in N seconds: if there are no edits, the replag will likely be resolved much quicker, and if there is massive congestion, it could take much

[Pywikipedia-bugs] [Maniphest] [Closed] T143217: archivebot.py exception: ValueError: unsupported format character '|' (0x7c) at index 43

2016-08-26 Thread valhallasw
valhallasw closed this task as "Resolved".valhallasw claimed this task.valhallasw added a comment. valhallasw@maeglin:i18n$ gr

[Pywikipedia-bugs] [Maniphest] [Commented On] T96241: pwb deadlocks when quitting

2016-08-26 Thread valhallasw
valhallasw added a comment. Could you try the following: https://wiki.python.org/moin/DebuggingWithGdb Specifically the 'To see Python code positions for all threads, use' part. If we know where pywikibot is hanging, it's easier to understand what's going on. Another option i

[Pywikipedia-bugs] [Maniphest] [Created] T143937: site.unblockuser sends malformed/misencoded api request

2016-08-25 Thread valhallasw
valhallasw created this task.valhallasw added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONTest code: import pywikibot from pywikibot.page import User from pywikibot.site import APISite site = pywikibot.Site() summary = 'בדיקת בוט'

  1   2   3   >