jayvdb added a comment.
During code review I noticed that `watchpage` was issuing an 'error' level
logging message when the API result did not contain the expected data element
`watch`. IMO this should be an exception (even an assertion), not a UI error
message.
e.g. editpage does
assert
jayvdb added a comment.
As I mentioned on the code review, I would prefer that mw <1.23 supports
multiple titles by iterating over the list of titles and watching each one.
Thoughts on this?
TASK DETAIL
https://phabricator.wikimedia.org/T103736
EMAIL PREFERENCES
Dalba added a comment.
Wouldn't that cause sending multiple web requests and making the script slower?
TASK DETAIL
https://phabricator.wikimedia.org/T103736
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Dalba
Cc: Dalba, gerritbot, StudiesWorld,
gerritbot added a comment.
Change 261903 abandoned by Dalba:
site.py:Support titles parameter in watch action
Reason:
This one has been committed by mistake (don't know how).
https://gerrit.wikimedia.org/r/261903
TASK DETAIL
https://phabricator.wikimedia.org/T103736
EMAIL PREFERENCES
gerritbot added a comment.
Change 261904 had a related patch set uploaded (by Dalba):
site.py:Support titles parameter in watch action
https://gerrit.wikimedia.org/r/261904
TASK DETAIL
https://phabricator.wikimedia.org/T103736
EMAIL PREFERENCES
