[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Xqt added a comment. In T106121#6975274 , @Ladsgroup wrote: > I'm not sure having a never ending task is a good idea. You can create a ticket for specific clean ups (python2) or you can use gerrit hashtags if you want to have a way to

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Ladsgroup added a comment. I'm not sure having a never ending task is a good idea. You can create a ticket for specific clean ups (python2) or you can use gerrit hashtags if you want to have a way to find patch. You can also create a ticket for cleanups doable after a release maybe? (for

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Xqt added a comment. In T106121#6967520 , @Aklapper wrote: > @Xqt: Hi, all related patches in Gerrit have been merged. Can this task be resolved (via Add Action... > Change Status in the dropdown menu), or is there more to do in this

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 630638 **merged** by jenkins-bot: [pywikibot/core@master] [cleanup] Show a FutureWarning for methods which are deprecated for 5 years https://gerrit.wikimedia.org/r/630638 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 630638 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [cleanup] Show a FutureWarning for methods which are deprecated for 5 years https://gerrit.wikimedia.org/r/630638 TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 616219 **merged** by jenkins-bot: [pywikibot/core@master] [cleanup] Remove outdated Python 2.6 backports from tools https://gerrit.wikimedia.org/r/616219 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 616219 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [cleanup] Remove outdated tools https://gerrit.wikimedia.org/r/616219 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 612544 **merged** by jenkins-bot: [pywikibot/core@master] [cleanup] Use FutureWarning for methods deprecated for 6 years https://gerrit.wikimedia.org/r/612544 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 612544 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [cleanup] Use FutureWarning for methods deprecated for 6 years https://gerrit.wikimedia.org/r/612544 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 409823 **merged** by jenkins-bot: [pywikibot/core@master] [IMPR] Use one central point for framework version https://gerrit.wikimedia.org/r/409823 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 606438 **merged** by jenkins-bot: [pywikibot/core@master] [cleanup] Cleanup getFilesFromAnHash and getImagesFromAnHash https://gerrit.wikimedia.org/r/606438 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 606438 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [cleanup] Cleanup getFilesFromAnHash and getImagesFromAnHash https://gerrit.wikimedia.org/r/606438 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 409823 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [IMPR] Use one central point for framework version https://gerrit.wikimedia.org/r/409823 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 585904 **merged** by jenkins-bot: [pywikibot/core@master] [cleanup] Desupport old deprecated methods https://gerrit.wikimedia.org/r/585904 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 585904 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [cleanup] Desupport old deprecated methods https://gerrit.wikimedia.org/r/585904 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 577598 **merged** by jenkins-bot: [pywikibot/core@master] [cleanup] Remove outdated has_api method https://gerrit.wikimedia.org/r/577598 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 577598 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [cleanup] Remove outdated has_api method https://gerrit.wikimedia.org/r/577598 TASK DETAIL https://phabricator.wikimedia.org/T106121 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 463775 merged by jenkins-bot: [pywikibot/core@master] [cleanup] remove pre mw 1.14 code https://gerrit.wikimedia.org/r/463775TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 463775 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [cleanup] remove pre mw 1.14 code https://gerrit.wikimedia.org/r/463775TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 449025 merged by Mpaa: [pywikibot/core@master] [cleanup] Remove unsupported removeImage and placeImage Page methods https://gerrit.wikimedia.org/r/449025TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 449026 merged by jenkins-bot: [pywikibot/core@master] [cleanup] Remove getParsedString Site method https://gerrit.wikimedia.org/r/449026TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Xqt added a comment. In T106121#4445145, @Dvorapa wrote: Okay, now we can remove deprecations older than 2 ( ? 3? ) years! I started to remove unsupported code. See related patches.TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 449026 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [cleanup] Remove getParsedString Site method https://gerrit.wikimedia.org/r/449026TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 449025 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [cleanup] Remove unsupported removeImage and placeImage Page methods https://gerrit.wikimedia.org/r/449025TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dvorapa added a comment. Okay, now we can remove deprecations older than 2 ( ? 3? ) years!TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, DvorapaCc: Zoranzoki21, Dvorapa, gerritbot, zhuyifei1999,

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 399755 merged by jenkins-bot: [pywikibot/core@master] [IMPR] Introduce a timestamp in deprecated decorator https://gerrit.wikimedia.org/r/399755TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dvorapa added a comment. What about SemVer version for framework and for each script its own SemVer version?TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, DvorapaCc: Zoranzoki21, Dvorapa, gerritbot,

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Xqt added a comment. I'm confused, there already are some deprecations in 7 scripts. So we just need to start deprecating in scripts? I would support to finish https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/399755/ ASAP for this. Personally I never was a friend of deprecation script parts

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dvorapa added a comment. In T106121#4430116, @Xqt wrote: In T106121#4430075, @Dvorapa wrote: Personally I would continue to deprecate parts of scripts as before. We also omitted deprecating of script parts in past. Scripts are ready to use and I mean it is in the scope of bot operators if they

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Xqt added a comment. Maybe we should move scripts directory to _scripts to make this more explicit? The archive folde would be a place for older scripts if necessary. And we also have the monthly updated repository tags to easily went back to an older implementation.TASK

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dvorapa added a comment. Personally I would continue to deprecate parts of scripts as before.TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, DvorapaCc: Zoranzoki21, Dvorapa, gerritbot, zhuyifei1999,

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dvorapa added a comment. In T106121#4429964, @Dalba wrote: Maybe we should move scripts directory to _scripts to make this more explicit? I don't support this idea, _scripts could possibly break too many things.TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dalba added a comment. In T106121#2820403, @Xqt wrote: Any script parts except the are reused by other scripts; on the other hand this should not be done, see T60942. Does everyone agree on this one? I plan to fix all pep8-naming errors within scripts, which will require renaming some

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dvorapa added a comment. In https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/399755/ there can also be found multiple code blocks deprecated for even 4 or 5 years. I think that these deprecated for more than 2 years should be removed as such a long time with deprecation warning seems enough to

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Xqt added a comment. In T106121#4045429, @Dalba wrote: That's a good point. I also would like to add that we might not always agree on what is and what is not a breaking change and how often we should bump the version (another source of arguing). For example I consider changing requests

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dalba added a comment.Herald added a subscriber: Zoranzoki21. In T106121#3968993, @Lokal_Profil wrote: In T106121#3968520, @Dalba wrote: The person who is going to update the changelog and do the release, should look at the changes since the last release and bump the version accordingly. Do we

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Xqt added a comment. In T106121#3968993, @Lokal_Profil wrote: Do we have anyone/anyones willing to take that on? I did it several times in past and it is very easy to do it with master branch in opposite to the previous so called stable release 2.0. If I understand the pywikibot history

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Lokal_Profil added a comment. In T106121#3968520, @Dalba wrote: The person who is going to update the changelog and do the release, should look at the changes since the last release and bump the version accordingly. Do we have anyone/anyones willing to take that on? If I understand the

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dalba added a comment. In T106121#3967489, @Dvorapa wrote: Will we require to increment PATCH number for every bugfix made and MINOR for every improvement? Based on our current release cycle, I presume that we can keep developing on the dev (pre-release) version. The person who is going to

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dvorapa added a comment. OK. I'm not against semver, I used it a lot in some of my older projects so I can see some serious questions we should solve before presenting this change: How this change will affect the developers? Will we require to increment PATCH number for every bugfix made and MINOR

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Xqt added a comment. I agree with Dalba. I've no idea for what the major release stands except 1.0 means trunk, 2.0 means the interim rewrite stable branch and 3 the current master which never will change in future except we have a complete code redesign. I think semver release counting is

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dalba added a comment. In T106121#3962754, @Dvorapa wrote: But I personally more like 3.1.20180212 (major.incompatibility.stamp). Under semver any incompatibility in API is considered a major change. In a major.incompatibility.stamp scheme, what kind of change will be associated with major

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dvorapa added a comment. Well, per semver backwards incompatibility should be noted as 4.0.0 (major,minor,patch). But I personally more like 3.1.20180212 (major.incompatibility.stamp).TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 409823 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [PEP440] Enable semver versioning for pywikibot https://gerrit.wikimedia.org/r/409823TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Xqt added a comment. Increasing minor version for backward incompatibility? Is there any package that does that? I think it'll confuse users. pywikibot was preparing to do it with 2.1 I personally prefer a full semver system, no dates. I believe it has a well understood meaning. However, a

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dalba added a comment. In T106121#3883666, @Xqt wrote: I propose to increase the minor release for backward incompatibility e.g. remove older depecated parts. Increasing minor version for backward incompatibility? Is there any package that does that? I think it'll confuse users. I personally

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Xqt added a comment. In T106121#3858860, @Dalba wrote: In T106121#3858703, @Lokal_Profil wrote: The problem with that is that versioning is today done separately from doing a deprecating commit and to the one doing the commit the current version isn't necessarily clear. I suppose we could

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Lokal_Profil added a comment. In T106121#3858860, @Dalba wrote: ... if deprecated code removal is going to be date-based only, e.g. after 1 year of deprecation as some have suggested, then a timestamp looks more appropriate. Since regular releases was a problem in the past I would probably go

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Dalba added a comment. In T106121#3858703, @Lokal_Profil wrote: In T106121#3856550, @Dalba wrote: The problem with that is that versioning is today done separately from doing a deprecating commit and to the one doing the commit the current version isn't necessarily clear. I suppose we could

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Lokal_Profil added a comment. In T106121#3856550, @Dalba wrote: I'd suggest using the version number instead of timestamp. The problem with that is that versioning is today done separately from doing a deprecating commit and to the one doing the commit the current version isn't necessarily

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

gerritbot added a comment. Change 399755 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [IMPR] Introduce a timestamp in deprecated decorator https://gerrit.wikimedia.org/r/399755TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Lokal_Profil added a comment. I agree with @Magul that the time sink aspects should not be very pronounced with the proposed scheme of releases since we will not be trying to maintain multiple releases. Pip install is by far the most common way of consuming python libraries. Requiring that

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Magul added a comment. Great, thank You!TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, MagulCc: Ladsgroup, Magul, TerraCodes, Legoktm, Luke081515, hashar, Jay8g, Dalba, Lokal_Profil, StudiesWorld,

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Ladsgroup added a comment. I added you as owner. I don't know if others have account in the test pypi. Tell me if you know anyone.TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, LadsgroupCc: Ladsgroup,

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Magul added a comment. In T106121#2892478, @Multichill wrote: I don't agree. The whole thing with releases is just a giant time sink. We just killed off compat to not have to worry about multiple versions any more. I'd rather have people spend time on improving Pywikibot and fixing bugs, than

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Ladsgroup added a comment. (I was subscribed so I make a note) Release engineering for pywikibot needs some work. We have three options here: Going after semver (See http://semver.org/). So only major version change when there is a breaking change and minor change for minor ones. It's PEP440

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Multichill added a comment. In T106121#2890974, @Lokal_Profil wrote: Do we want to handle a change of release model/plan in this RFC or should that be a separate one with this one on hold until that is resolved? I don't agree. The whole thing with releases is just a giant time sink. We just

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Lokal_Profil added a comment. Do we want to handle a change of release model/plan in this RFC or should that be a separate one with this one on hold until that is resolved?TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Lokal_Profil added a comment. In T106121#2863447, @Magul wrote: @Lokal_Profil Maybe it wasn't clear in my previous comments - I'm advocating for frequent releases (like in constant interval of one month). It will provide current features in commonly used format. I'm also agruing for abandoning

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Lokal_Profil added a comment. In T106121#2802405, @Magul wrote: I Your case if You don't want to maintain Your code, You can pin to particular version/pypi release of library, and if You want to use new features You can just use virtualenvs to execute particular code with particular library's

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Magul added a comment. Hi @Multichill, first of all thank You for such warm greeting. As I wrote already here I believe that is one of the most important questions that we need to answer here. I made really simple test and right now we have around 1400 instances of "deprec" in source code. I

[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

Ricordisamoa added a subscriber: Ricordisamoa. Ricordisamoa added a comment. 1 year of deprecation seems enough to me. When releases are established, master will be able to advance even faster. Or should it always be kept? That's what compat ended up doing, I think? TASK DETAIL