[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

gerritbot added a comment. Change 264251 merged by jenkins-bot: Set user-agent and convert reflinks.py to use requests https://gerrit.wikimedia.org/r/264251 TASK DETAIL https://phabricator.wikimedia.org/T113596 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefere

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

jayvdb added a comment. In https://phabricator.wikimedia.org/T113596#1938143, @jayvdb wrote: > Note that `fake-useragent` is unusable at the moment on Python 2.7; see > https://github.com/hellysmile/fake-useragent/issues/14 Re-installing the package fixed my problem. Quite strange, but anyway

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

jayvdb added a comment. @MtDu, As it seems you are investigating using `requests`, please discuss that problem on T111300: Convert reflinks to requests . It is a separate task. It is not a mandatory part of the solution to this user-agent bug. TASK

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

MtDu added a comment. @jayvdb, So... Is switching to requests a good idea? Now, when I'm testing I'm getting errors like this. https://dpaste.de/Tdio#L552,555,557,648 On line 552, it says str does no have decode attr. When I delete that, it says On line 648, does not have attr close, When I d

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

jayvdb added a comment. Note that `fake-useragent` is unusable at the moment on Python 2.7; see https://github.com/hellysmile/fake-useragent/issues/14 TASK DETAIL https://phabricator.wikimedia.org/T113596 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

jayvdb added a comment. In https://phabricator.wikimedia.org/T113596#1937895, @MtDu wrote: > @jayvdb, > Could you guide me on how to test it? > Thanks, > MtDu I've added a way to test it in this task's description. TASK DETAIL https://phabricator.wikimedia.org/T113596 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

MtDu added a comment. @jayvdb, Could you guide me on how to test it? Thanks, MtDu TASK DETAIL https://phabricator.wikimedia.org/T113596 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MtDu Cc: gerritbot, MtDu, Nemo_bis, 8ohit.dua, jayvdb, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

jayvdb added a comment. @MtDu, how are you testing your code? Could you describe your test sequence here please. Then reviewers can 1. comment on whether the test sequence is good 2. use the test sequence to confirm your solution is fixing the problem. TASK DETAIL https://phabricator.wikim

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

8ohit.dua added a comment. jayvdb: I am available on IRC mostly after 8pm IST(UTC+5:30). I'll be there at # pywikibot channel. TASK DETAIL https://phabricator.wikimedia.org/T113596 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MtDu, 8ohit.dua Cc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 264251 had a related patch set uploaded (by MtDu): [WIP] Set user-agent in reflinks.py https://gerrit.wikimedia.org/r/264251 TASK DETAIL https://phabricator.wikimedia.org/T113596 EMAIL PREFERENCES https://phabricato

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

MtDu added a comment. @jayvdb, Thanks for clarifying my questions. I will get to work later. Thanks, MtDu TASK DETAIL https://phabricator.wikimedia.org/T113596 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MtDu Cc: MtDu, Nemo_bis, 8ohit.dua, jayv

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

jayvdb added a comment. In https://phabricator.wikimedia.org/T113596#1935212, @MtDu wrote: > I have claimed this task on GCI. I will have some questions, so what time is > best for me to get on IRC? I am available on IRC mostly during the day and evening Australian Eastern time. @8ohit.dua ,

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

jayvdb added a comment. https://dpaste.de/aq6u is `weblinkchecker.py`, which is a separate but related bug : https://phabricator.wikimedia.org/T71204. Each script in `scripts/` is separate from the others. This task is about `scripts/reflinks.py`, which does not set a user agent at all. To ch

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

MtDu added a comment. Hello! I'm kind of confused on the general bug. Here are my questions: 1. Where does the user-agent need to actually be added? I looked around pywikibot, and found this. https://dpaste.de/aq6u Is this similar to what I need to do here? (I know there needs to be some logic

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

8ohit.dua added a subscriber: 8ohit.dua. 8ohit.dua added a comment. https://codein.withgoogle.com/dashboard/tasks/5077814600531968/ TASK DETAIL https://phabricator.wikimedia.org/T113596 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: 8ohit.dua Cc: 8

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

Rubin16 added a comment. https://ru.wikipedia.org/w/index.php?diff=72816694&oldid=72804830 https://ru.wikipedia.org/w/index.php?diff=73531250&oldid=73527279 "Устаревший или неподдерживаемый веб-обозреватель" in Russian means "outdated browser" TASK DETAIL https://phabricator.wikimedia.org/T1

[Pywikipedia-bugs] [Maniphest] [Commented On] T113596: reflinks.py work with old user agent

jayvdb added a comment. @Rubin16, can you give an example of where that page title appeared? TASK DETAIL https://phabricator.wikimedia.org/T113596 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: jayvdb, Aklapper, pywikibot-bugs-list, Rubi