gerritbot added a comment.
Change 265899 merged by jenkins-bot:
Add deprecation notice (if necessary) to docstring of @deprecated functions
https://gerrit.wikimedia.org/r/265899
TASK DETAIL
https://phabricator.wikimedia.org/T121366
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settin
gerritbot added a comment.
Change 265902 abandoned by Sn1per:
[WIP] Remove unnecessary DEPRECATED notices from docstrings
Reason:
Per https://phabricator.wikimedia.org/T121366#1958826
https://gerrit.wikimedia.org/r/265902
TASK DETAIL
https://phabricator.wikimedia.org/T121366
EMAIL PREFERENC
Xqt added a comment.
@jayvdb any idea how to implement a hook for additional test stuff?
TASK DETAIL
https://phabricator.wikimedia.org/T121366
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sn1per, Xqt
Cc: Xqt, gerritbot, Sn1per, pywikibot-bugs-lis
jayvdb added a comment.
The `@deprecated` is also human readable. The 'problem' with adding
'Deprecated' to the docstring is they are not kept in sync with `@deprecated`.
We have so many instances where this hasnt been done; it slips through code
review, as we dont have a code style checker f
Xqt added a subscriber: Xqt.
Xqt added a comment.
What is wrong keeping "Deprecated" in doc string? Please keep in mind doc
strings are comments for human readability to explain a method inside the code.
But it would be wrong to have access to those comments via post-processors on
an external s
gerritbot added a comment.
Change 265902 had a related patch set uploaded (by Sn1per):
[WIP]Remove unnecessary DEPRECATED notices from docstrings
https://gerrit.wikimedia.org/r/265902
TASK DETAIL
https://phabricator.wikimedia.org/T121366
EMAIL PREFERENCES
https://phabricator.wikimedia.org/
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 265899 had a related patch set uploaded (by Sn1per):
Add deprecation notice to docstring in @deprecated decorator
https://gerrit.wikimedia.org/r/265899
TASK DETAIL
https://phabricator.wikimedia.org/T121366
EMAIL PREFE
Sn1per added a comment.
I imagine a regex could be used to make @deprecate_arg do something similar.
TASK DETAIL
https://phabricator.wikimedia.org/T121366
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sn1per
Cc: Sn1per, pywikibot-bugs-list, jayvdb
jayvdb added a comment.
As decorators are fairly 'advanced Python', and are complex to
build/modify/test, this would be a good
https://phabricator.wikimedia.org/tag/google-code-in-2015/ project for someone
wanting to increase their Python skills.
TASK DETAIL
https://phabricator.wikimedia.or
