[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

gerritbot added a comment. Change 312721 abandoned by Xqt: pywikibot.Page.put: checking the changes before saving Reason: per T122715 https://gerrit.wikimedia.org/r/312721TASK DETAILhttps://phabricator.wikimedia.org/T122715EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

AbdealiJK added a comment. @Vyeshwant123 Sorry about that! I'd recommend you go ahead and find another bug to solve :)TASK DETAILhttps://phabricator.wikimedia.org/T122715EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Vyeshwanth123, AbdealiJKCc: AbdealiJK,

[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

Xqt added a comment. Some notes of my pov as Ricordisamoa mentioned this would be a breaking change and unables null-edits we would have a different behaviour for put() put_async() and save() but we should avoid this user messages should be avoided in library parts except they are exceptions

[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

gerritbot added a comment. Change 312721 had a related patch set uploaded (by Vyeshwanth): pywikibot.Page.put: checking the changes before saving https://gerrit.wikimedia.org/r/312721TASK DETAILhttps://phabricator.wikimedia.org/T122715EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

Ricordisamoa added a comment. BasePage.purge() with `forcerecursivelinkupdate` should be preferred but some users may still be using `BasePage.put()` for the purpose. Although I'm not dismissing the proposed change at first glance, I don't think the framework should get in its users' way.

[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

Dalba added a comment. Oh, good point! Even in that case, `forcerecursivelinkupdate` seems a better choice to me, but maybe it's not worth it anymore. Should I mark this task as declined? TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

Ricordisamoa added a subscriber: Ricordisamoa. Ricordisamoa added a comment. This is a breaking change. Some users may send intentionally null edits to refresh server caches. TASK DETAIL https://phabricator.wikimedia.org/T122715 EMAIL PREFERENCES