[Pywikipedia-bugs] [Maniphest] [Commented On] T144157: Pywikibot should create *.lwp files with 600 mode so nobody except its owner is able to read it

2016-09-03 Thread gerritbot
gerritbot added a comment. Change 308335 merged by jenkins-bot: [bugfix] omit mode 600 warning for non-unix platforms https://gerrit.wikimedia.org/r/308335TASK DETAILhttps://phabricator.wikimedia.org/T144157EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerr

[Pywikipedia-bugs] [Maniphest] [Commented On] T144157: Pywikibot should create *.lwp files with 600 mode so nobody except its owner is able to read it

2016-09-03 Thread gerritbot
gerritbot added a comment. Change 308335 had a related patch set uploaded (by Xqt): [bugfix] omit mode 600 warning for non-linux platforms https://gerrit.wikimedia.org/r/308335TASK DETAILhttps://phabricator.wikimedia.org/T144157EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emai

[Pywikipedia-bugs] [Maniphest] [Commented On] T144157: Pywikibot should create *.lwp files with 600 mode so nobody except its owner is able to read it

2016-09-03 Thread Mpaa
Mpaa added a comment. In T144157#2606810, @valhallasw wrote: Windows likely doesn't support os.chmod(). We can just remove the warning -- that's what we do for passwordfile. Or as config is anyhow imported, we can just display it if not OSWIN32?TASK DETAILhttps://phabricator.wikimedia.org/T14415

[Pywikipedia-bugs] [Maniphest] [Commented On] T144157: Pywikibot should create *.lwp files with 600 mode so nobody except its owner is able to read it

2016-09-03 Thread valhallasw
valhallasw added a comment. Alternatively, we could try to support Windows ACLs (see e.g. http://stackoverflow.com/a/27500472/118671 ) , but ACLs are complicated, and I think all of our windows users are on (effectively) single-user systems, where files that are readable for all is less of an issue

[Pywikipedia-bugs] [Maniphest] [Commented On] T144157: Pywikibot should create *.lwp files with 600 mode so nobody except its owner is able to read it

2016-09-03 Thread valhallasw
valhallasw added a comment. Windows likely doesn't support os.chmod(). We can just remove the warning -- that's what we do for passwordfile.TASK DETAILhttps://phabricator.wikimedia.org/T144157EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: valhal

[Pywikipedia-bugs] [Maniphest] [Commented On] T144157: Pywikibot should create *.lwp files with 600 mode so nobody except its owner is able to read it

2016-09-03 Thread Xqt
Xqt added a comment. On windows I always get this warning now: WARNING: File C:\pwb\GIT\core\pywikibot.lwp had no 600 mode; converted to 600 modeTASK DETAILhttps://phabricator.wikimedia.org/T144157EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Xqt, ge

[Pywikipedia-bugs] [Maniphest] [Commented On] T144157: Pywikibot should create *.lwp files with 600 mode so nobody except its owner is able to read it

2016-09-03 Thread gerritbot
gerritbot added a comment. Change 308225 merged by jenkins-bot: http.py: create/convert pywikibot.lwp file to 600 https://gerrit.wikimedia.org/r/308225TASK DETAILhttps://phabricator.wikimedia.org/T144157EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbo

[Pywikipedia-bugs] [Maniphest] [Commented On] T144157: Pywikibot should create *.lwp files with 600 mode so nobody except its owner is able to read it

2016-09-02 Thread gerritbot
gerritbot added a comment. Change 308225 had a related patch set uploaded (by Mpaa): http.py: create/convert pywikibot.lwp file to 600 https://gerrit.wikimedia.org/r/308225TASK DETAILhttps://phabricator.wikimedia.org/T144157EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpre