gerritbot added a comment.
Change 481275 **abandoned** by Xqt:
[pywikibot/core@master] [bugfix] Fix Tkdialog
Reason:
no longer maintained
https://gerrit.wikimedia.org/r/481275
TASK DETAIL
https://phabricator.wikimedia.org/T207579
EMAIL PREFERENCES
gerritbot added a comment.
Change 481275 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Fix Tkdialog
https://gerrit.wikimedia.org/r/481275TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL
gerritbot added a comment.
Change 469049 merged by jenkins-bot:
[pywikibot/core@master] [test] Temporary accept imagecopy_tests.py failing
https://gerrit.wikimedia.org/r/469049TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL
Dvorapa added a comment.
@Xqt I thought Magnus will be faster (he was for the first problem), the test disabling patch would be useless for one day, but now I think we can disable the tests until Magnus will have the time to fix the tool properly.TASK
Xqt added a comment.
@Dvorapa: why shouldn't we disable thoses tests temporarily with that patch committed in https://gerrit.wikimedia.org/r/469049? The problem is noted here and it seems not easy to solve. All further travis and appveyor tests are failing now and there is no focus to other tests
Dvorapa added a comment.
@Magnus Is there any progress in fixing the tool?TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, gerritbot, Magnus, D3r1ck01, Aklapper, Dalba, Xqt,
Dvorapa added a comment.
Also we will need to change the file in our tests, because the current file has been transferred to Commons lately.TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa,
Dvorapa added a comment.
In T207579#4690879, @Dalba wrote:
The test is looking for in the returned value of pageTextPost which does not have it. I've created a paste of the actual retrieved data at P7716. This might be a UI change and in which case we might need to update some parts of the
Dvorapa added a comment.
In T207579#4689654, @Magnus wrote:
Try it now please.
On my machine, sometimes I get a correct response from the tools and sometimes I get Fatal error: Class 'Template' not found in /data/project/commonshelper/public_html/index.php on line 317
On Travis machine the
Magnus added a comment.
Try it now please.TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagnusCc: Dvorapa, gerritbot, Magnus, D3r1ck01, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris,
Dvorapa added a comment.
> Therefore it seems the tool is still broken. It makes the same response for Pywikibot and Pywikibot's example image (also claimed not to exist by CommonsHelper even if it exists actually)TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL
Dvorapa added a comment.
In T207579#4686746, @Magnus wrote:
This should be fixed now in CommonsHelper.
I've tried some enwiki images and each of them does not exist according to CommonsHelper.TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL
Xqt added a comment.
In T207579#4687091, @Dvorapa wrote:
Still failing, but hopefully only due to the cache.
No. I committed a new patch which also failedTASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Dvorapa added a comment.
Still failing, but hopefully only due to the cache.TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, gerritbot, Magnus, D3r1ck01, Aklapper, Dalba, Xqt,
Xqt added a comment.
I‘ll restart last testsTASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Magnus, D3r1ck01, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi,
D3r1ck01 added a comment.
Yay \o/. Thanks @Magnus. Over to you @Xqt :)TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01Cc: gerritbot, Magnus, D3r1ck01, Aklapper, Dalba, Xqt, pywikibot-bugs-list,
Magnus added a comment.
This should be fixed now in CommonsHelper.TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagnusCc: gerritbot, Magnus, D3r1ck01, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD,
gerritbot added a comment.
Change 469049 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [test] Temporary accept imagecopy_tests.py failing
https://gerrit.wikimedia.org/r/469049TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL
D3r1ck01 added a comment.
@Xqt, as a confirmation, when I try to print out the value of commons_helper on L36, I get the same output as on my web browser;
Fatal error: Call to undefined function getSubResults() in /data/project/magnustools/public_html/php/wikiquery.php on line 98TASK
D3r1ck01 added a comment.
While trying to track where the problem comes from, I don't think it's Pywikibot related. There is an issue with the tool, I tried making a request via web browser and I get this error;
Fatal error: Call to undefined function getSubResults() in
20 matches
Mail list logo
