[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 663573 **merged** by jenkins-bot: [pywikibot/core@master] [bugfix] Do not attemp to login over and over again https://gerrit.wikimedia.org/r/663573 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 663573 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [bugfix] Do not attemp to login over and over again https://gerrit.wikimedia.org/r/663573 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 513555 abandoned by Xqt: [login] Do not attempt to login over and over again Reason: Seems mainly solved https://gerrit.wikimedia.org/r/513555 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Anomie added a comment. No need IMO. T145545 exists for the WMF side of things. TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa, Anomie Cc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 585333 **merged** by jenkins-bot: [pywikibot/core@master] [bugfix] Clear second level domain cookies after logout https://gerrit.wikimedia.org/r/585333 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. You can read detailed explanation and several solutions for bot client/library and cookie handling client/library above. For Python there is perhaps an issue with basic cookie handling library, which we will overcome in Pywikibot with a simple yet effective

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

PeterBowman added a comment. In T224712#5920479 , @Dvorapa wrote: > After some other tests: > zh.wikisource.org API sometimes generates invalid new token (using action=query=tokens). This token gives login response of `NeedToken` with

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 585522 abandoned by Dvorapa: [bugfix] Clear second level domain cookies after "badtoken" response Reason: Merged https://gerrit.wikimedia.org/r/585522 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 585522 had a related patch set uploaded (by Dvorapa; owner: Dvorapa): [pywikibot/core@master] [bugfix] Logout also from second level domain if it is wiki https://gerrit.wikimedia.org/r/585522 TASK DETAIL https://phabricator.wikimedia.org/T224712

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. Reported to py-requests: https://github.com/psf/requests/issues/5411 Minimal reproducible test case: https://repl.it/repls/HarmfulBiodegradableExperiments Pastebin (just in case): https://pastebin.com/7d7Dn9p1 TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 585333 had a related patch set uploaded (by Dvorapa; owner: Dvorapa): [pywikibot/core@master] [bugfix] Clear second level domain cookies after logout https://gerrit.wikimedia.org/r/585333 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. > otherwise flushing cookies Currently working on this. Anyway, thank you for your insight! TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa Cc: Reedy,

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Anomie added a comment. In general, Wikimedia should probably figure out some way to reconfigure things so it doesn't wind up trying to set both cookies with domain=.wikisource.org and domainless cookies for wikisource.org. It's probably best to use T145545

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. This behavior looks full of misunderstandings between all parties (ws, zhws, pwb, py-requests), but none of them behaves completely wrong. Now the questions is, what to fix and where in the whole process ( I'm so much glad @Urbanecm helped with his MITM/proxy

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. OK, to sum it up for #Pywikibot people: When you/Pywikibot interact with any wiki, you only have one centralauth session cookie. But when you visit wikisource.org after you visited *.wikisource.org (zh) (i.e.

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Anomie added a comment. It's hard to copy-paste from screenshots... Hopefully the OCR doesn't mangle things too badly. In T224712#6018928 , @Urbanecm wrote: > F31719968: image.png

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Urbanecm added a comment. I was discussing this issue with @Dvorapa privately, and I've decided to try to run Pywikibot tests via a proxy which allows me to view the request and response in full (I've used mitmproxy). Those are raw data with necessary redactions. F31719962: image.png

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. In T224712#6018769 , @Anomie wrote: > Where is this news? All I see is a giant paste showing pywikibot caught in some sort of loop. I see no MediaWiki requests/responses that claim to be showing incorrect

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Reedy added a comment. In T224712#6012922 , @Dvorapa wrote: > Okay, still failing to get valid login token from zh:wikisource. No other wiki failing. Can we try to test different Wikisource? fr:ws? de:ws? In T224712#6018706

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. Reverting, there are some news from proxy test about zh:wikisource session handling! TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa Cc: Urbanecm,

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. Okay, still failing to get valid login token from zh:wikisource. No other wiki failing. I think we can try to use different Wikisource? fr:ws? de:ws? TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. Last endless loop issue should be caused by loop 1 or 2. I suspect there are more hidden loops and this needs to be investigated properly. I also suspect userinfo <-> _userinfo and user() <-> username() are switched in wrong places producing these loops. TASK

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 583711 **merged** by jenkins-bot: [pywikibot/core@master] [IMPR] Don't trust token from NeedToken response https://gerrit.wikimedia.org/r/583711 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. Any pair of eye to identify issues in this traceback are welcome. If you find a loop, please create a subtask for it :) TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 583711 had a related patch set uploaded (by Dvorapa; owner: Dvorapa): [pywikibot/core@master] [IMPR] Don't trust token from NeedToken response https://gerrit.wikimedia.org/r/583711 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 584195 **merged** by jenkins-bot: [pywikibot/core@master] [bugfix] Fix handling of badtoken response for login actions https://gerrit.wikimedia.org/r/584195 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 584195 had a related patch set uploaded (by Dvorapa; owner: Dvorapa): [pywikibot/core@master] [bugfix] Fix handling of badtoken response for login actions https://gerrit.wikimedia.org/r/584195 TASK DETAIL https://phabricator.wikimedia.org/T224712

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 584091 abandoned by Dvorapa: [test] Enable some sort of APIError logging Reason: No longer relevant https://gerrit.wikimedia.org/r/584091 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 584091 had a related patch set uploaded (by Dvorapa; owner: Dvorapa): [pywikibot/core@master] [test] Enable some sort of APIError logging https://gerrit.wikimedia.org/r/584091 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 584017 **merged** by jenkins-bot: [pywikibot/core@master] [bugfix] Resolve action=login deprecation warning https://gerrit.wikimedia.org/r/584017 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 584017 had a related patch set uploaded (by Dvorapa; owner: Dvorapa): [pywikibot/core@master] [bugfix] Resolve action=login deprecation warning https://gerrit.wikimedia.org/r/584017 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. The patch just partially workarounds one loop. But does not resolve anything TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pchelolo, Dvorapa Cc: Jdforrester-WMF,

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 575038 **merged** by jenkins-bot: [pywikibot/core@master] [IMPR] Don't trust token from NeedToken response https://gerrit.wikimedia.org/r/575038 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. It first failed in May 29th after https://github.com/wikimedia/pywikibot/commit/893d03f87ff8e4d1d4db4b4838bec176cd97a338 (no code change in session cookie part) TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. Also this happens sometimes for lgtoken, sometimes for username and sometimes for password, another weird thing TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. Weird is this happens only for zh.wikisource, not for enwiki, not for wikidata, commons, testwiki, testwikidata, arwiktionary and not for Beta Cluster. I am not sure, how to get the whole HTTP request with headers. TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Anomie added a comment. In T224712#5920305 , @Dvorapa wrote: > @Anomie @Jdforrester-WMF I broke Pywikibot login loop and found out the issue with zh.wikisource.org. It seems API sometimes reacts weirdly to action=login requests. For

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 575038 had a related patch set uploaded (by Dvorapa; owner: Dvorapa): [pywikibot/core@master] [IMPR] Don't trust token from NeedToken response https://gerrit.wikimedia.org/r/575038 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. After some other tests: zh.wikisource.org API sometimes generates invalid new token (using action=query=tokens). This token gives login response of `NeedToken` with another invalid token generated. This token gives login response of `NeedToken` with yet another

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. In T224712#5917361 , @Anomie wrote: > In T224712#5913343 , @Dvorapa wrote: > >> Beta Cluster is fixed, but still fails for zh.wikisource.org, see: > >

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. The loop in line 3148 does seem correct to me TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pchelolo, Dvorapa Cc: Jdforrester-WMF, Pchelolo, Anomie, Dvorapa,

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Xqt added a comment. In T224712#5721064 , @Xqt wrote: > Again in https://api.travis-ci.org/v3/job/621982242/log.txt Don't think that the patch above solves this. it may solve the first issue of

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. Fails also for zh.wikisource.org TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pchelolo, Dvorapa Cc: Jdforrester-WMF, Pchelolo, Anomie, Dvorapa, Framawiki, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. Waiting for tests to complete TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pchelolo, Dvorapa Cc: Jdforrester-WMF, Pchelolo, Anomie, Dvorapa, Framawiki, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Jdforrester-WMF added a comment. https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/574034 has now been deployed; is this still an issue? TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 574034 **merged** by jenkins-bot: [operations/mediawiki-config@master] Beta sessionstore: don't use TLS https://gerrit.wikimedia.org/r/574034 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 574034 had a related patch set uploaded (by Ppchelko; owner: Ppchelko): [operations/mediawiki-config@master] Beta sessionstore: don't use TLS https://gerrit.wikimedia.org/r/574034 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. Seems like an #upstream issue, compare: en.wikipedia.beta.wmflabs.org F31625062: Snímek z 2020-02-21 05-44-20.png en.wikisource.beta.wmflabs.org F31625063: Snímek

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Xqt added a comment. Again in https://api.travis-ci.org/v3/job/621982242/log.txt TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Dvorapa, Framawiki, Aklapper, pywikibot-bugs-list,

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. 1. BotPassword should be the same for enwiki + testwiki + commons (and maybe for testwd too). Anyway this should definitely work, yes TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dalba added a comment. Maybe switching to bot passwords will resolve this issue. I would suggest doing so. `action=login` has been long deprecated anyway. Switching to bot password requires: 1. access to test account to generate a password for the test sites (currently

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

gerritbot added a comment. Change 513555 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [login] Do not attempt to login over and over again https://gerrit.wikimedia.org/r/513555 TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. The same with long-running bot tasks. My bot tasks sometimes stops in the middle and asks for password instead of automatic relogging TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times

Dvorapa added a comment. If I run `python setup.py test` on my computer, at one point it asks for password even if I it is already stored in pywikibot.lwp: ... test_extensions (tests.site_tests.TestSiteExtensions) Test Extensions. ... ERROR: Logged in as