[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

zhuyifei1999 added a comment. In T228322#5344565 , @Xqt wrote: > lang property must be resolved from siteinfo whereas code property is already given when instantiating the site object. I think

[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

Dvorapa added a comment. Is this still an issue? Or at least does this need to be solved to make Travis and AppVeyor pass again? TASK DETAIL https://phabricator.wikimedia.org/T228322 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa Cc:

[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

Xqt added a comment. lang property must be resolved from siteinfo whereas code property is already given when instantiating the site object. I think TestAPIMWException.test_API_error_encoding_ASCII uses a fake http request and the siteinfo is never retrieved - am I right? TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

Xqt added a comment. There is an infinite loop in this part of code: File "C:\pwb\GIT\core\pywikibot\site.py", line 1672, in get preloaded = self._get_general(key, expiry) File "C:\pwb\GIT\core\pywikibot\site.py", line 1618, in _get_general default_info =

[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

Xqt added a comment. Maybe this gives any hint? C:\pwb\GIT\core>py -2 pwb.py api_tests -v TestAPIMWException.test_API_error_enco ding_ASCII WARNING: C:\pwb\GIT\core\pywikibot\tools\ip.py:71: ImportWarning: Importing ipad dr.IPAddress failed: No module named ipaddr

[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

gerritbot added a comment. Change 523985 **merged** by jenkins-bot: [pywikibot/core@master] Revert "[bugfix] site.lang is different from site.code" https://gerrit.wikimedia.org/r/523985 TASK DETAIL https://phabricator.wikimedia.org/T228322 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

gerritbot added a comment. Change 523985 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] Revert "[bugfix] site.lang is different from site.code" https://gerrit.wikimedia.org/r/523985 TASK DETAIL https://phabricator.wikimedia.org/T228322 EMAIL