[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

Mpaa added a comment. @OlehOnyshchcak, thanks for the clarification. Appreciated! TASK DETAIL https://phabricator.wikimedia.org/T236614 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa, Mpaa Cc: srishakatux, Dvorapa, HAKSOAT, Mpaa,

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

gerritbot added a comment. Change 570867 **merged** by jenkins-bot: [pywikibot/core@master] [bugfix] Fix as_filename for Windows https://gerrit.wikimedia.org/r/570867 TASK DETAIL https://phabricator.wikimedia.org/T236614 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

Dvorapa added a comment. `"` is the last character added to the list. Be aware, that Pywikibot's aim is not to produce filenames adjusted for your OS and your filesystem needs - this is your own responsibility. So if your OS or filesystem has got some additional rules, you would still have

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

Dvorapa added a comment. In my opinion, POSIX compliant filenames would be too much there as modern OSes and software can handle Unicode filenames just well TASK DETAIL https://phabricator.wikimedia.org/T236614 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

Dvorapa added a comment. I did some research and it's correct: Only one Windows illegal filename character (") has been missing from our list. I fixed it then with detailed explanation. TASK DETAIL https://phabricator.wikimedia.org/T236614 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

gerritbot added a comment. Change 570867 had a related patch set uploaded (by Dvorapa; owner: Dvorapa): [pywikibot/core@master] [bugfix] Fix as_filename for Windows https://gerrit.wikimedia.org/r/570867 TASK DETAIL https://phabricator.wikimedia.org/T236614 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

OlehOnyshchcak added a comment. In T236614#5858056 , @Mpaa wrote: >> and also wasted me a lot of time in the process of realizing that I need to implement this and re-download data. > > Obviously developers and maintainers are not

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

Mpaa added a comment. > and also wasted me a lot of time in the process of realizing that I need to implement this and re-download data. Obviously developers and maintainers are not happy when bugs slip-through and users are annoyed. Anyhow, it does not seem right to me that you are

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

srishakatux added a comment. I'm being bold and removing the #good_first_task tag; it can be put back when there is more clarity on the next steps :) TASK DETAIL https://phabricator.wikimedia.org/T236614 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

OlehOnyshchcak added a comment. I just want to give my perspective on an issue in order for it to be better triaged: 1. pywikibot claims to support both Windows and Linux systems, so functionality must have a common denominator of "what is acceptable on all systems". If pywikibot

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

HAKSOAT added a comment. Thanks TASK DETAIL https://phabricator.wikimedia.org/T236614 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HAKSOAT Cc: Dvorapa, HAKSOAT, Mpaa, Aklapper, pywikibot-bugs-list, Miriam, OlehOnyshchcak, AndreasTraut,

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

Dvorapa added a comment. Hello @HAKSOAT! I'm unsure if this task is ready to be fixed as @Mpaa had a valid argument above to be discussed before. TASK DETAIL https://phabricator.wikimedia.org/T236614 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

HAKSOAT added a comment. I'd like to work on this. TASK DETAIL https://phabricator.wikimedia.org/T236614 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HAKSOAT Cc: HAKSOAT, Mpaa, Aklapper, pywikibot-bugs-list, Miriam, OlehOnyshchcak,

[Pywikipedia-bugs] [Maniphest] [Commented On] T236614: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character

Mpaa added a comment. This is OS dependent, on Linux it is acceptable. TASK DETAIL https://phabricator.wikimedia.org/T236614 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Mpaa, Aklapper, pywikibot-bugs-list, Miriam, OlehOnyshchcak,