[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

matej_suchanek added a comment. F31854753: obrazek.png This is justified for syntaxhighlight/source but actually not for nowiki, pre, code. TASK DETAIL https://phabricator.wikimedia.org/T254350 EMAIL PREFERENCES https://phabricator.wikim

[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

matej_suchanek added a comment. The screenshot does not demonstrate what replacements bots do but how MediaWiki treats HTML entities inside these tags. I believe `'code'` was a mistake and should have originally been `'source'`. TASK DETAIL https://phabricator.wikimedia.org/T254350 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

Dvorapa added a comment. @matej_suchanek Could you try a different character and post results? Ampersand might be an exception on both sides (both PWB and MW) TASK DETAIL https://phabricator.wikimedia.org/T254350 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpre

[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

matej_suchanek added a comment. ndash and szlig: F31854933: obrazek.png F31854935: obrazek.png TASK DETAIL https://phabricator.wikimedia.org/T254350 EMAIL PREFERENCES https://phabricator.wikime

[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

Dvorapa added a comment. And numerical (unicode, hex-unicode)? TASK DETAIL https://phabricator.wikimedia.org/T254350 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa Cc: Dvorapa, matej_suchanek, Tractopelle-jaune, Aklapper, jeblad, pywikib

[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

Dvorapa added a comment. Yeah, numerical work the same, just tested. Okay, that means only syntaxhighlight needs to have exception TASK DETAIL https://phabricator.wikimedia.org/T254350 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa Cc: D

[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

Tractopelle-jaune added a comment. Remember that the following code is sometimes used: ` ` in `` or similar tags, to intentionally display an HTML entity code ` `. This is sometimes used in documentation in code to copy, or to explain behavior. The bot should not modify in this

[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

matej_suchanek added a comment. This is avoided by blacklisting `&` and others such as `>` or `<` from replacement. TASK DETAIL https://phabricator.wikimedia.org/T254350 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: Dvorapa,

[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

gerritbot added a comment. Change 609297 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek): [pywikibot/core@master] [bugfix] Avoid HTML entity substitution in https://gerrit.wikimedia.org/r/609297 TASK DETAIL https://phabricator.wikimedia.org/T254350 EMAI

[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

matej_suchanek added a comment. Well, I have already demonstrated how MediaWiki behaves. If you take a look at the diffs in that task description, you will see the bot also replaced `&` -> `&`. That is certainly unwanted and there is a regression test which guards against this. But `...` doe

[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

Dvorapa added a comment. Good point TASK DETAIL https://phabricator.wikimedia.org/T254350 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa Cc: Dvorapa, matej_suchanek, Tractopelle-jaune, Aklapper, jeblad, pywikibot-bugs-list, Xqt, JohnsonL

[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

Xqt added a comment. I see, the point is that `ignore` list prevents from replacing already. TASK DETAIL https://phabricator.wikimedia.org/T254350 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Dvorapa, matej_suchanek, Tractopelle-jaune,

[Pywikipedia-bugs] [Maniphest] [Commented On] T254350: cc.resolveHtmlEntities() should be excluded inside tag

gerritbot added a comment. Change 609297 **merged** by jenkins-bot: [pywikibot/core@master] [bugfix] Avoid HTML entity substitution in https://gerrit.wikimedia.org/r/609297 TASK DETAIL https://phabricator.wikimedia.org/T254350 EMAIL PREFERENCES https://phabricator.wikimedia.org/s