[Pywikipedia-bugs] [Maniphest] [Commented On] T278040: reflinks.py work with quotes

gerritbot added a comment. Change 674613 **merged** by jenkins-bot: [pywikibot/core@master] [bugfix] Avoid dupliate reference names https://gerrit.wikimedia.org/r/674613 TASK DETAIL https://phabricator.wikimedia.org/T278040 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T278040: reflinks.py work with quotes

Xqt added a comment. In T278040#6944570 , @Rubin16 wrote: > @Xqt > seems to be working, thanks a lot. Let's merge and I will do a more continuous run to test it more. > > PS: Just for my self-education (you can ignore it, if you

[Pywikipedia-bugs] [Maniphest] [Commented On] T278040: reflinks.py work with quotes

Rubin16 added a comment. @Xqt seems to be working, thanks a lot. Let's merge and I will do a more continuous run to test it more. PS: Just for my self-education (you can ignore it, if you want): - I see that you have changed the logic from adding +1 to the existing ref names

[Pywikipedia-bugs] [Maniphest] [Commented On] T278040: reflinks.py work with quotes

Xqt added a comment. In T278040#6941703 , @Rubin16 wrote: > Seems to have the same result Found that bug and solved it with the last

[Pywikipedia-bugs] [Maniphest] [Commented On] T278040: reflinks.py work with quotes

Xqt added a comment. Found that bug which was there since 2008! Patch comming soon. TASK DETAIL https://phabricator.wikimedia.org/T278040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Xqt, Aklapper, pywikibot-bugs-list, Rubin16,

[Pywikipedia-bugs] [Maniphest] [Commented On] T278040: reflinks.py work with quotes

Rubin16 added a comment. Seems to have the same result TASK DETAIL https://phabricator.wikimedia.org/T278040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Pywikipedia-bugs] [Maniphest] [Commented On] T278040: reflinks.py work with quotes

Xqt added a comment. In T278040#6941547 , @Rubin16 wrote: > @Xqt thank you, it seems to be editing correctly now. > > But it still makes

[Pywikipedia-bugs] [Maniphest] [Commented On] T278040: reflinks.py work with quotes

Rubin16 added a comment. @Xqt thank you, it seems to be editing correctly now. But it still makes some mistakes, creating "autogenerated7" while we had 'autogenerated7'. So, it works

[Pywikipedia-bugs] [Maniphest] [Commented On] T278040: reflinks.py work with quotes

Xqt added a comment. @rubin16: Can you review my patch? TASK DETAIL https://phabricator.wikimedia.org/T278040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Xqt, Aklapper, pywikibot-bugs-list, Rubin16, Jyoo1011, JohnsonLee01, SHEKH,

[Pywikipedia-bugs] [Maniphest] [Commented On] T278040: reflinks.py work with quotes

gerritbot added a comment. Change 674613 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [bugfix] Always use double quotes with references https://gerrit.wikimedia.org/r/674613 TASK DETAIL https://phabricator.wikimedia.org/T278040 EMAIL PREFERENCES