[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

gerritbot added a comment. Change 721574 **merged** by jenkins-bot: [pywikibot/core@master] [cleanup] Remove deprecated pywikibot.Error exceptions.py https://gerrit.wikimedia.org/r/721574 TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

gerritbot added a comment. Change 721574 had a related patch set uploaded (by Xqt; author: Xqt): [pywikibot/core@master] [cleanup] Remove deprcated pywikibot.Error exceptions.py https://gerrit.wikimedia.org/r/721574 TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

gerritbot added a comment. Change 683913 **merged** by jenkins-bot: [pywikibot/core@master] [Error] use exceptions.Error instead of pywikibot.Error https://gerrit.wikimedia.org/r/683913 TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

gerritbot added a comment. Change 683913 had a related patch set uploaded (by Xqt; author: Xqt): [pywikibot/core@master] [Error] use exceptions.Error instead of pywikibot.Error https://gerrit.wikimedia.org/r/683913 TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

Xqt added a comment. In T280227#7044684 , @atagar wrote: > There seems to be a Python 3.5 issue regarding ModuleDeprecationWrapper. Would you like for me to install Python 3.5 to troubleshoot or should we continue with this? > >

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

gerritbot added a comment. Change 682277 **merged** by jenkins-bot: [pywikibot/core@master] [cleanup] Suffix exceptions with 'Error' https://gerrit.wikimedia.org/r/682277 TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

atagar added a comment. There seems to be a Python 3.5 issue regarding ModuleDeprecationWrapper. Would you like for me to install Python 3.5 to troubleshoot or should we continue with this? Personally I think we should deprecate Python 3.5 support since it reached EoL in September

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

JJMC89 added a comment. Not sure. It isn't just these new deprecations though. I also don't get a warning for pywikibot.MediaWikiVersion with Python 3.5.3 but do with 3.7.3. TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

atagar added a comment. That's... really odd. I have Python 3.8 and unfortunately installing a deprecated 3.5 interpreter would be a pita. Do you have any idea what's going on or should I try to get one working? TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

JJMC89 added a comment. I get the warning with Python 3.7.3 but not with 3.5.3. TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar, JJMC89 Cc: JJMC89, pywikibot-bugs-list, Xqt, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

atagar added a comment. That's odd. I do get it... % cat demo.py import pywikibot from pywikibot import NoPage # same behavior if imported from pywikibot.exceptions from pywikibot.exceptions import NoPageError pywikibot.handle_args() site = pywikibot.Site()

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

JJMC89 added a comment. I still don't see a warning on PS6. I do get one if `NoPage` is imported from `pywikibot.exceptions`. TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar, JJMC89

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

atagar added a comment. Thanks @JJMC89! Great point. Code review updated with a better approach which fixes that. TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: JJMC89,

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

JJMC89 added a comment. @atagar: When I run the below code with your patch (PS4), I don't see any warnings for using `NoPage`. name=t.py import pywikibot from pywikibot import NoPage # same behavior if imported from pywikibot.exceptions from pywikibot.exceptions import

[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8

gerritbot added a comment. Change 682277 had a related patch set uploaded (by Damian; author: Damian): [pywikibot/core@master] [cleanup] Suffix all exceptions with 'Error' https://gerrit.wikimedia.org/r/682277 TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL