Huji added a comment.
Once https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/532473/ is merged,
we are all clear (given the exclusions we have specified in tox.ini of course)
and we can close this task. CI already takes care of the rest.
TASK DETAIL
https://phabricator.wikimedia.org/T853
Huji added a comment.
@Magul I am not familiar with Wikimedia CI so I am afraid I cannot help. What I can tell you for sure is that we do not check PEP8 compliance right now; I checked a number of our existing scripts and they failed for reasons like having lines longer than 80 characters, having i
Huji added a comment.
@Magul I also agree that we shouldn't do like one big commit that only consists of adding blank lines to the end of files.
But perhaps to ensure that this change actually does happen over time, can we modify our test scripts on Jenkins to enforce this rule? This way, every ti
Magul added a comment.
Hi @Huji I don't remember if it is actually pointed out in original PEP-8 document but it was introduced in pycodestyle (formerly known as pep8, changed on direct Guido's requests as warning W292.
My linter in editor point this issue every time and as I don't see any argumen
Huji added a comment.
Question for the team: I check PEP8 compliance using http://pep8online.com/ and one of the rules it enforces is that the file must end with a newline (i.e. one blank line at the very end is required). I cannot find that recommendation on python.org's PEP8 documentation but it
