[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

gerritbot added a comment. Change 430608 merged by jenkins-bot: [pywikibot/core@master] tox.ini: Enable E402 and disable I201 checks https://gerrit.wikimedia.org/r/430608TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefer

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

gerritbot added a comment. Change 430608 had a related patch set uploaded (by Dalba; owner: Dalba): [pywikibot/core@master] tox.ini: Enable E402 and disable I201 checks https://gerrit.wikimedia.org/r/430608TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wiki

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

Dvorapa added a comment. Mostly broken on constructs like this: import os os.environ['PYWIKIBOT2_NO_USER_CONFIG'] = 2 import config os.environ['PYWIKIBOT2_NO_USER_CONFIG'] = 0 if sys.version_info[0] > 2: import python3lib else: import python2lib try: import lib except: print(

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

gerritbot added a comment. Change 406406 abandoned by Xqt: [style] Re-enable E402 check https://gerrit.wikimedia.org/r/406406TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc: Dvorapa, Dalba, R

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

gerritbot added a comment. Change 406406 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [style] Re-enable E402 check https://gerrit.wikimedia.org/r/406406TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/p

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

Dvorapa added a comment. @Xqt Should we revert this change which disabled PEP8 checking for import-on-top?TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, DvorapaCc: Dvorapa, Dalba, Ricordisamoa, gerritbot

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

gerritbot added a comment. Change 403608 merged by jenkins-bot: [pywikibot/core@master] [cleanup] remove __version__ string from pywikibot framework scripts https://gerrit.wikimedia.org/r/403608TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/se

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

gerritbot added a comment. Change 403608 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [cleanup] remove __version__ string from pywikibot framework scripts https://gerrit.wikimedia.org/r/403608TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttp

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

gerritbot added a comment. Change 403599 merged by jenkins-bot: [pywikibot/core@master] [cleanup] Remove version string from scripts https://gerrit.wikimedia.org/r/403599TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefer

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

gerritbot added a comment. Change 403599 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [cleanup] Remove version string from scripts/archive/featured.py https://gerrit.wikimedia.org/r/403599TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

gerritbot added a comment. Change 363210 merged by jenkins-bot: [pywikibot/core@master] Remove version string from scripts https://gerrit.wikimedia.org/r/363210TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

gerritbot added a comment. Change 363210 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] Remove __version string from scripts https://gerrit.wikimedia.org/r/363210TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/se

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

gerritbot added a comment. Change 348942 merged by jenkins-bot: [pywikibot/core@master] Remove version variable from the modules of the test package https://gerrit.wikimedia.org/r/348942TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/p

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

gerritbot added a comment. Change 348942 had a related patch set uploaded (by Dalba): [pywikibot/core@master] Remove version variable from the modules of the test package https://gerrit.wikimedia.org/r/348942TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wi

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

Dalba added a comment. In T87409#2189435, @Xqt wrote: imho this could be removed or it should be replaced by a more informative value. +1. There are only a few scripts that actually use __version__ : bot.py: handle_args prints out module versions in verbose mode version.py: A few functions,

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

jayvdb added a comment. Note that the pep8 has been adjusted to match our use of `__version__`, and this will be changing soon in the pep8 checker (now called pycodestyle) - patch at https://github.com/PyCQA/pycodestyle/pull/523. TASK DETAIL https://pha

[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

Xqt added a comment. In https://phabricator.wikimedia.org/T87409#1039982, @jayvdb wrote: > As a start, we can at least remove `__version__` from the tests. Does __version__ contain any usefull information anymore. Other than svn where we got a consecutive number which identified t