ElSeiver created this task. ElSeiver added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION `xmlreader.XmlDump` has a boolean parameter `allrevisions` that states "If True, parse all revisions instead of only the latest one." If False, it calls the function `._parse_only_latest()` in `.parse()`. However, two issues arise: 1. As written, `._parse_only_latest()` yields the first matching revision found without comparing `revisionid` to other candidates. In the case of the test suite and my own separate wikidump, this returns the //earliest// revision of the page, not the latest. 2. The accompanying test, `tests.xml_reader_tests.test_XmlDumpFirstRev()`, specifies that it indeed tests loading the first revision. While the test is currently passing, it would be more helpful to match the function and instead check that it returns the //latest// revision. PR to follow shortly! TASK DETAIL https://phabricator.wikimedia.org/T340804 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ElSeiver Cc: Aklapper, pywikibot-bugs-list, ElSeiver, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, Xqt, jayvdb, Masti, Alchimista
_______________________________________________ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
