jenkins-bot has submitted this change and it was merged.
Change subject: Re-enable site tests commented out due to old bugs
......................................................................
Re-enable site tests commented out due to old bugs
allcategories and allimages tests commented out due to bug 15985, now fixed.
Bug: T60941
Change-Id: I13be662e1be1f90109c8a19e6e9b13d65419255a
---
M tests/site_tests.py
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Merlijn van Deen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index f0e8468..918dc3f 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -478,10 +478,10 @@
for cat in mysite.allcategories(total=5, prefix="Def"):
self.assertIsInstance(cat, pywikibot.Category)
self.assertTrue(cat.title(withNamespace=False).startswith("Def"))
-# # Bug # 15985
-# for cat in mysite.allcategories(total=5, start="Hij", reverse=True):
-# self.assertIsInstance(cat, pywikibot.Category)
-# self.assertLessEqual(cat.title(withNamespace=False), "Hij")
+ # Bug # 15985 - reverse and start combined; fixed in v 1.14
+ for cat in mysite.allcategories(total=5, start="Hij", reverse=True):
+ self.assertIsInstance(cat, pywikibot.Category)
+ self.assertLessEqual(cat.title(withNamespace=False), "Hij")
def test_allusers(self):
"""Test the site.allusers() method."""
@@ -536,11 +536,11 @@
self.assertIsInstance(impage, pywikibot.FilePage)
self.assertTrue(mysite.page_exists(impage))
self.assertGreaterEqual(impage.title(withNamespace=False), "Ba")
-# # Bug # 15985
-# for impage in mysite.allimages(start="Da", reverse=True, total=5):
-# self.assertIsInstance(impage, pywikibot.FilePage)
-# self.assertTrue(mysite.page_exists(impage))
-# self.assertLessEqual(impage.title(), "Da")
+ # Bug # 15985 - reverse and start combined; fixed in v 1.14
+ for impage in mysite.allimages(start="Da", reverse=True, total=5):
+ self.assertIsInstance(impage, pywikibot.FilePage)
+ self.assertTrue(mysite.page_exists(impage))
+ self.assertLessEqual(impage.title(withNamespace=False), "Da")
for impage in mysite.allimages(prefix="Ch", total=5):
self.assertIsInstance(impage, pywikibot.FilePage)
self.assertTrue(mysite.page_exists(impage))
--
To view, visit https://gerrit.wikimedia.org/r/179124
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13be662e1be1f90109c8a19e6e9b13d65419255a
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhall...@arctus.nl>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
Pywikibot-commits mailing list
Pywikibot-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
