Build Update for wikimedia/pywikibot-core
-------------------------------------

Build: #2370
Status: Passed

Duration: 25 minutes and 6 seconds
Commit: cf4e8aa (master)
Author: Fabian Neundorf
Message: [FIX] upload: Use correct offset

When a warning occurs and there is no offset in the request it either means
that this is not a chunked upload or that it's the first chunk. If it's not a
chunked upload it should select the offset 'False' and otherwise '0'. The patch
introducing finishing/continuing uploads (d0d1c830) always uses '0' which means
that after a warning with an unchunked upload it'll use a chunked upload (which
does not work for URL uploads).

Using an offset of '0' is in theory wasting the first chunk which may have been
uploaded successfully but unfortunately it might be that not the entire chunk
was transmitted. (There are cases where the returned offset did not match with
the old offset + chunk size)

Change-Id: Ic1e5cb8fee9d4d8ead591947f36c8436540e1b73

View the changeset: 
https://github.com/wikimedia/pywikibot-core/compare/978a935b5a73...cf4e8aa729e8

View the full build log and details: 
https://travis-ci.org/wikimedia/pywikibot-core/builds/66662736

--

You can configure recipients for build notifications in your .travis.yml file. 
See http://docs.travis-ci.com/user/notifications


_______________________________________________
Pywikibot-commits mailing list
Pywikibot-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits

Reply via email to