Re: [Pywikipedia-l] reflinks.py under GPL?

2014-08-01 Thread Liangent
cc'ing shizhao. On Aug 1, 2014 8:58 AM, John Mark Vandenberg jay...@gmail.com wrote: On Fri, Jun 13, 2014 at 10:10 AM, Ricordisamoa ricordisa...@openmailbox.org wrote: Please sign off a Code-Review+1 for https://gerrit.wikimedia.org/r/#/c/139294/. Thanks in advance. Il 09/06/2014

Re: [Pywikipedia-l] The build is broken

2014-08-01 Thread Mpaa
From my understanding (I have not tried, just looked at the code), archivebot.py allows a timestamp to be None. See def should_be_archived(). In that case the thread is not added to the list of threads to be archived but it is left on the talk page. So technically it is not 100% correct to test

Re: [Pywikipedia-l] The build is broken

2014-08-01 Thread Amir Ladsgroup
I disagree because maybe someone breaks the regex of detecting signature date and the test should be able to detect that. The best solution IMHO is to find sections via their revision timestamp but Flow will come and everything will be solved YA Best On 8/2/14, Mpaa mpaa.w...@gmail.com