Re: [Pywikipedia-l] The build is broken

2014-08-02 Thread John Mark Vandenberg
Recently we had a few cases of code that didnt compile getting merged (I have +2 some of them.. :/), so I have fast tracked the addition of a set of tests which run every script with -help , and with -simulate. These new tests add about 3 minutes to the test suite execution, and add basic

Re: [Pywikipedia-l] The build is broken

2014-08-02 Thread Mpaa
@Amir If a section is unsigned and there is no timestamp, how can you find sections via their revision timestamp? And expect that the timestamp is a datetime object? Mpaa On Sat, Aug 2, 2014 at 8:57 AM, John Mark Vandenberg jay...@gmail.com wrote: Recently we had a few cases of code that

Re: [Pywikipedia-l] The build is broken

2014-08-02 Thread Amir Ladsgroup
Mpaa: I meant getting section date by getting history and analyzing revisions instead of checking signature on them. Best On 8/2/14, Mpaa mpaa.w...@gmail.com wrote: @Amir If a section is unsigned and there is no timestamp, how can you find sections via their revision timestamp? And expect

Re: [Pywikipedia-l] The build is broken

2014-08-02 Thread Jonathan Goble
Analyzing history instead of parsing timestamps from wikitext won't work because it will catch things like {{resolved}} tags that shouldn't delay archiving. It also will keep the common hack of adding a timestamp far in the future to prevent premature archiving from working. On Aug 2, 2014 10:26

Re: [Pywikipedia-l] The build is broken

2014-08-01 Thread Mpaa
: 26.07.2014 23:22 An: Pywikibot discussion list Betreff: Re: [Pywikipedia-l] The build is broken it was another bug that John and Ricordisamoa are talking about. On 7/27/14, i...@gno.de i...@gno.de wrote: This is not a bug in testing. The test detects a bug for archivebot.py which fails

Re: [Pywikipedia-l] The build is broken

2014-08-01 Thread Amir Ladsgroup
Gesendet: 26.07.2014 23:22 An: Pywikibot discussion list Betreff: Re: [Pywikipedia-l] The build is broken it was another bug that John and Ricordisamoa are talking about. On 7/27/14, i...@gno.de i...@gno.de wrote: This is not a bug in testing. The test detects a bug for archivebot.py

Re: [Pywikipedia-l] The build is broken

2014-07-26 Thread info
This is not a bug in testing. The test detects a bug for archivebot.py which fails for unsigned threads. xqt - Ursprüngliche Nachricht - Von: John Mark Vandenberg Gesendet: 26.07.2014 18:21 An: Pywikibot discussion list Betreff: Re: [Pywikipedia-l] The build is broken On Sat, Jul 26

Re: [Pywikipedia-l] The build is broken

2014-07-26 Thread Amir Ladsgroup
: 26.07.2014 18:21 An: Pywikibot discussion list Betreff: Re: [Pywikipedia-l] The build is broken On Sat, Jul 26, 2014 at 10:39 PM, Ricordisamoa ricordisa...@openmailbox.org wrote: The build is still broken, but because of this edit, that breaks the timestamp detection of the ArchiveBot

Re: [Pywikipedia-l] The build is broken

2014-07-26 Thread info
Ah, maybe. I just saw your fixes at my Talk page(s). xqt - Ursprüngliche Nachricht - Von: Amir Ladsgroup Gesendet: 26.07.2014 23:22 An: Pywikibot discussion list Betreff: Re: [Pywikipedia-l] The build is broken it was another bug that John and Ricordisamoa are talking about. On 7/27/14

Re: [Pywikipedia-l] The build is broken

2014-07-26 Thread Amir Ladsgroup
, maybe. I just saw your fixes at my Talk page(s). xqt - Ursprüngliche Nachricht - Von: Amir Ladsgroup Gesendet: 26.07.2014 23:22 An: Pywikibot discussion list Betreff: Re: [Pywikipedia-l] The build is broken it was another bug that John and Ricordisamoa are talking about. On 7/27/14

[Pywikipedia-l] The build is broken

2014-07-25 Thread John Mark Vandenberg
The build was repeatedly broken over the last week. Two of the build breakages have been fixed. I think one was caused by changes to WMF site configuration. https://travis-ci.org/wikimedia/pywikibot-core/builds/30824554 And the other caused by merging a fix without checking the tests worked