Re: Exit status for runtask should be 1 if task outcome is FAILED?

2015-04-01 Thread Kamil Paral
> Sounds good to me. I only wonder if we simply fall back to the current > state (exit 0) if the precondition (last tap result outcome) and > --make-fatal is not given. That was the idea. If you specify --make-fatal, we return exit code 0 or 100 based on the outcome of the last TAP entry. If you

Re: Exit status for runtask should be 1 if task outcome is FAILED?

2015-03-30 Thread Róman Joost
Dear Kamil, sorry for the delay. On Wed, Mar 25, 2015 at 08:51:29AM -0400, Kamil Paral wrote: > > That's exactly why I thought about runtask. To be more precise, we're > > currently working on rpmgrill. It ships it's own fetch-build script > > which is currently tied to Fedoras Koji. > > Just a

Re: Exit status for runtask should be 1 if task outcome is FAILED?

2015-03-25 Thread Kamil Paral
> That's exactly why I thought about runtask. To be more precise, we're > currently working on rpmgrill. It ships it's own fetch-build script > which is currently tied to Fedoras Koji. Just a note, IIRC you don't need just all the rpms, but also the build log for certain subtests. That's currentl

Re: Exit status for runtask should be 1 if task outcome is FAILED?

2015-03-24 Thread Róman Joost
Dear Kamil, thanks for your prompt reply. On Tue, Mar 24, 2015 at 05:21:44AM -0400, Kamil Paral wrote: > > Hi, > > > > I'd like to enquire if it's desired to let runtask exit with '1' if the > > task in question has a 'FAILED' outcome. > > > > Maybe there was a conscious decision of not providi

Re: Exit status for runtask should be 1 if task outcome is FAILED?

2015-03-24 Thread Kamil Paral
> Hi, > > I'd like to enquire if it's desired to let runtask exit with '1' if the > task in question has a 'FAILED' outcome. > > Maybe there was a conscious decision of not providing this feature and > I'd like to hear about it. > > I've joined Taskotron on phabricator. If there are no obvious >

Exit status for runtask should be 1 if task outcome is FAILED?

2015-03-22 Thread Róman Joost
Hi, I'd like to enquire if it's desired to let runtask exit with '1' if the task in question has a 'FAILED' outcome. Maybe there was a conscious decision of not providing this feature and I'd like to hear about it. I've joined Taskotron on phabricator. If there are no obvious resentments against