Re: [Qemu-block] [Qemu-devel] [PATCH v3 04/13] netmap: Drop netmap_can_send

2015-05-24 Thread Fam Zheng
On Tue, 05/19 15:54, Stefan Hajnoczi wrote: > On Tue, May 19, 2015 at 10:51:01AM +, Fam Zheng wrote: > > This callback is called by main loop before polling s->fd, if it returns > > false, the fd will not be polled in this iteration. > > > > This is redundant with checks inside read callback.

Re: [Qemu-block] [PATCH v6 12/13] block: Block "device IO" during bdrv_drain and bdrv_drain_all

2015-05-24 Thread Fam Zheng
On Sat, 05/23 19:11, Max Reitz wrote: > On 21.05.2015 08:43, Fam Zheng wrote: > >We don't want new requests from guest, so block the operation around the > >nested poll. > > > >It also avoids looping forever when iothread is submitting a lot of requests. > > > >Signed-off-by: Fam Zheng > >--- > >

Re: [Qemu-block] [Qemu-devel] [PATCH v6 01/13] block: Add op blocker type "device IO"

2015-05-24 Thread Fam Zheng
On Sat, 05/23 18:51, Max Reitz wrote: > On 22.05.2015 06:54, Fam Zheng wrote: > >On Thu, 05/21 15:32, Fam Zheng wrote: > >>On Thu, 05/21 15:06, Wen Congyang wrote: > >>>On 05/21/2015 02:42 PM, Fam Zheng wrote: > It blocks device IO. > > All bdrv_op_block_all/blk_op_block_all callers ar