Re: [Qemu-block] RFC cdrom in own thread?

2015-06-17 Thread Paolo Bonzini
On 18/06/2015 08:39, Peter Lieven wrote: > > It seems like the mainloop is waiting here: > > #0 0x7606c89c in __lll_lock_wait () >from /lib/x86_64-linux-gnu/libpthread.so.0 > No symbol table info available. > #1 0x76068065 in _L_lock_858 () >from /lib/x86_64-linux-gnu/

Re: [Qemu-block] [Qemu-devel] RFC cdrom in own thread?

2015-06-17 Thread Markus Armbruster
Peter Lieven writes: > Am 17.06.2015 um 10:35 schrieb Kevin Wolf: >> Am 16.06.2015 um 17:34 hat Stefan Hajnoczi geschrieben: >>> On Tue, Jun 16, 2015 at 3:44 PM, Peter Lieven wrote: I wonder how difficult it would be to have the IDE CDROM run in its own thread? We usually have ISO

Re: [Qemu-block] RFC cdrom in own thread?

2015-06-17 Thread Peter Lieven
Am 17.06.2015 um 10:35 schrieb Kevin Wolf: Am 16.06.2015 um 17:34 hat Stefan Hajnoczi geschrieben: On Tue, Jun 16, 2015 at 3:44 PM, Peter Lieven wrote: I wonder how difficult it would be to have the IDE CDROM run in its own thread? We usually have ISOs mounted on an NFS share as CDROM. Problem

Re: [Qemu-block] RFC cdrom in own thread?

2015-06-17 Thread Peter Lieven
Am 17.06.2015 um 10:35 schrieb Kevin Wolf: Am 16.06.2015 um 17:34 hat Stefan Hajnoczi geschrieben: On Tue, Jun 16, 2015 at 3:44 PM, Peter Lieven wrote: I wonder how difficult it would be to have the IDE CDROM run in its own thread? We usually have ISOs mounted on an NFS share as CDROM. Problem

[Qemu-block] [PULL 09/10] pci: Don't register a specialized 'config_write' if default behavior is intended

2015-06-17 Thread Michael S. Tsirkin
From: Shmulik Ladkani Few devices have their specialized 'config_write' methods which simply call 'pci_default_write_config' followed by a 'msix_write_config' or 'msi_write_config' calls, using exact same arguments. This is unnecessary as 'pci_default_write_config' already invokes 'msi_write_con

Re: [Qemu-block] [PATCH v2 3/3] block/nfs: switch to error_init_local

2015-06-17 Thread Eric Blake
On 06/17/2015 01:24 AM, Michael S. Tsirkin wrote: > We probably should just switch everyone, this is > just to demonstrate the API usage. > > Signed-off-by: Michael S. Tsirkin > --- > block/nfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/nfs.c b/block/nfs.c

Re: [Qemu-block] [PATCH 1/2] nvme: implement the Flush command

2015-06-17 Thread Busch, Keith
> Implement a real flush instead of faking it. This is especially important > as Qemu assume Write back cashing by default and thus requires a working > cache flush operation for data integrity. Thanks, LGTM Acked-by: Keith Busch > > Signed-off-by: Christoph Hellwig

Re: [Qemu-block] NVMe volatile write cache fixes

2015-06-17 Thread Kevin Wolf
Am 17.06.2015 um 13:59 hat Christoph Hellwig geschrieben: > Thank Eric. > > Kevin, > > do you want me to resend the series with these cover letter/cc fixes or > is it okay this time? It's not worth a respin. I'm just waiting for an Acked-by (or whatever other outcome of a review) from Keith befo

Re: [Qemu-block] NVMe volatile write cache fixes

2015-06-17 Thread Christoph Hellwig
Thank Eric. Kevin, do you want me to resend the series with these cover letter/cc fixes or is it okay this time?

[Qemu-block] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests

2015-06-17 Thread Alexander Yarygin
Each call of the virtio_blk_reset() function calls blk_drain_all(), which works for all existing BlockDriverStates, while draining only one is needed. This patch replaces blk_drain_all() by blk_drain() in virtio_blk_reset(). virtio_blk_data_plane_stop() should be called after draining because it r

[Qemu-block] [PATCH v3 1/2] block-backend: Introduce blk_drain()

2015-06-17 Thread Alexander Yarygin
This patch introduces the blk_drain() function which allows to replace blk_drain_all() when only one BlockDriverState needs to be drained. Cc: Christian Borntraeger Cc: Cornelia Huck Cc: Kevin Wolf Cc: Paolo Bonzini Cc: Stefan Hajnoczi Signed-off-by: Alexander Yarygin Reviewed-by: Paolo Bonz

[Qemu-block] [PATCH v3 0/2] Fix slow startup with many disks

2015-06-17 Thread Alexander Yarygin
Changes in v3: - Added aio_context_acquire/aio_context_release around blk_drain() in "virtio-blk: Use blk_drain() to drain IO requests" + updated commit description Please update Cc: qemu-stable@ if it necessarily. Changes in v2: - Patch "block-backend: Introduce blk_drain() and

Re: [Qemu-block] [PATCH v2 3/6] opts: do not print separator before first item in qemu_opts_print

2015-06-17 Thread Kevin Wolf
Am 16.06.2015 um 14:49 hat Kővágó, Zoltán geschrieben: > This allows to print options in a format that the user would actually write it > on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious > comma at the beginning of the list. Note that if you really want to produce a val

Re: [Qemu-block] [PATCH v3 07/38] block/quorum: Implement bdrv_is_inserted()

2015-06-17 Thread Alberto Garcia
On Wed 03 Jun 2015 09:43:48 PM CEST, Max Reitz wrote: > bdrv_is_inserted() should be invoked recursively on the children of > quorum. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Berto

Re: [Qemu-block] RFC cdrom in own thread?

2015-06-17 Thread Kevin Wolf
Am 16.06.2015 um 17:34 hat Stefan Hajnoczi geschrieben: > On Tue, Jun 16, 2015 at 3:44 PM, Peter Lieven wrote: > > I wonder how difficult it would be to have the IDE CDROM run in its own > > thread? > > We usually have ISOs mounted on an NFS share as CDROM. Problem: If the NFS > > Share > > goes d

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/6] opts: do not print separator before first item in qemu_opts_print

2015-06-17 Thread Markus Armbruster
"Kővágó, Zoltán" writes: > This allows to print options in a format that the user would actually write it > on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious > comma at the beginning of the list. Suggest: This will let us print... > Only block.c depended on the old be

[Qemu-block] [PATCH v2 3/3] block/nfs: switch to error_init_local

2015-06-17 Thread Michael S. Tsirkin
We probably should just switch everyone, this is just to demonstrate the API usage. Signed-off-by: Michael S. Tsirkin --- block/nfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nfs.c b/block/nfs.c index ca9e24e..de4b8c3 100644 --- a/block/nfs.c +++ b/block/nfs.c @@