Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 05:38:53PM +0200, Cornelia Huck wrote: > On Wed, 15 Jul 2015 17:39:18 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 15, 2015 at 04:30:51PM +0200, Cornelia Huck wrote: > > > On Wed, 15 Jul 2015 17:11:57 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > > > > >

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Cornelia Huck
On Wed, 15 Jul 2015 17:39:18 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 15, 2015 at 04:30:51PM +0200, Cornelia Huck wrote: > > On Wed, 15 Jul 2015 17:11:57 +0300 > > "Michael S. Tsirkin" wrote: > > > > > > > > > Fine, but revision is negotiated way before features are > > > > > > > probed

Re: [Qemu-block] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-15 Thread Paolo Bonzini
On 15/07/2015 16:28, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2015 at 04:18:49PM +0200, Paolo Bonzini wrote: >> >> >> On 15/07/2015 16:14, Michael S. Tsirkin wrote: >>> On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini wrote: On 15/07/2015 14:21, Michael S. Tsirkin wrote:

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 04:30:51PM +0200, Cornelia Huck wrote: > On Wed, 15 Jul 2015 17:11:57 +0300 > "Michael S. Tsirkin" wrote: > > > > > > > Fine, but revision is negotiated way before features are > > > > > > probed so why does it make a practical difference? > > > > > > > > > > Legacy drive

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Cornelia Huck
On Wed, 15 Jul 2015 17:11:57 +0300 "Michael S. Tsirkin" wrote: > > > > > Fine, but revision is negotiated way before features are > > > > > probed so why does it make a practical difference? > > > > > > > > Legacy drivers (that don't know about the set-revision command) will > > > > read feature

Re: [Qemu-block] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 04:18:49PM +0200, Paolo Bonzini wrote: > > > On 15/07/2015 16:14, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 15/07/2015 14:21, Michael S. Tsirkin wrote: > > Disable scsi passthrough by default since it

Re: [Qemu-block] [Qemu-devel] [PULL for-2.4 0/5] Block layer patches for 2.4.0-rc1

2015-07-15 Thread Peter Maydell
On 15 July 2015 at 03:26, Jeff Cody wrote: > The following changes since commit 661725da09f47eb92d356fac10a4cf3b7ad1f61d: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20150714' into > staging (2015-07-14 18:50:17 +0100) > > are available in the git repository at: > > > g...@git

Re: [Qemu-block] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-15 Thread Paolo Bonzini
On 15/07/2015 16:14, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini wrote: >> >> >> On 15/07/2015 14:21, Michael S. Tsirkin wrote: > Disable scsi passthrough by default since it was incompatible with > virtio 1.0. For legacy machine types, keep this on

Re: [Qemu-block] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini wrote: > > > On 15/07/2015 14:21, Michael S. Tsirkin wrote: > >> > Disable scsi passthrough by default since it was incompatible with > >> > virtio 1.0. For legacy machine types, keep this on by default. > >> > > >> > Cc: Stefan Hajnoczi >

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 03:40:22PM +0200, Cornelia Huck wrote: > On Wed, 15 Jul 2015 16:16:07 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 15, 2015 at 02:43:51PM +0200, Cornelia Huck wrote: > > > On Wed, 15 Jul 2015 15:01:01 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed,

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Cornelia Huck
On Wed, 15 Jul 2015 16:16:07 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 15, 2015 at 02:43:51PM +0200, Cornelia Huck wrote: > > On Wed, 15 Jul 2015 15:01:01 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jul 15, 2015 at 01:46:38PM +0200, Cornelia Huck wrote: > > > > On Wed, 15 Jul

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 02:43:51PM +0200, Cornelia Huck wrote: > On Wed, 15 Jul 2015 15:01:01 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 15, 2015 at 01:46:38PM +0200, Cornelia Huck wrote: > > > On Wed, 15 Jul 2015 13:59:00 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Tue,

Re: [Qemu-block] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-15 Thread Paolo Bonzini
On 15/07/2015 14:21, Michael S. Tsirkin wrote: >> > Disable scsi passthrough by default since it was incompatible with >> > virtio 1.0. For legacy machine types, keep this on by default. >> > >> > Cc: Stefan Hajnoczi >> > Cc: Kevin Wolf >> > Cc: qemu-block@nongnu.org >> > Signed-off-by: Jason

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Cornelia Huck
On Wed, 15 Jul 2015 15:01:01 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 15, 2015 at 01:46:38PM +0200, Cornelia Huck wrote: > > On Wed, 15 Jul 2015 13:59:00 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Jul 14, 2015 at 07:43:44PM +0200, Cornelia Huck wrote: > > > > > Yes, and that

Re: [Qemu-block] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 01:29:59PM +0800, Jason Wang wrote: > Disable scsi passthrough by default since it was incompatible with > virtio 1.0. For legacy machine types, keep this on by default. > > Cc: Stefan Hajnoczi > Cc: Kevin Wolf > Cc: qemu-block@nongnu.org > Signed-off-by: Jason Wang See

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 01:46:38PM +0200, Cornelia Huck wrote: > On Wed, 15 Jul 2015 13:59:00 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Jul 14, 2015 at 07:43:44PM +0200, Cornelia Huck wrote: > > > > Yes, and that's because as written, transitional devices must set > > > > ANY_LAYOUT, but

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Cornelia Huck
On Wed, 15 Jul 2015 13:59:00 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jul 14, 2015 at 07:43:44PM +0200, Cornelia Huck wrote: > > > Yes, and that's because as written, transitional devices must set > > > ANY_LAYOUT, but that's incompatible with scsi. > > > > Hm, I had a patch before that dynam

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Michael S. Tsirkin
On Tue, Jul 14, 2015 at 07:43:44PM +0200, Cornelia Huck wrote: > > Yes, and that's because as written, transitional devices must set > > ANY_LAYOUT, but that's incompatible with scsi. > > Hm, I had a patch before that dynamically allowed different feature > sets for legacy or modern, not only a su

Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] blockjob: Introduce block_job_relax_cpu

2015-07-15 Thread Fam Zheng
On Tue, 07/14 13:31, Stefan Hajnoczi wrote: > On Fri, Jul 10, 2015 at 05:42:48AM +0200, Alexandre DERUMIER wrote: > > >>By the way, why did you choose 10 milliseconds? That is quite long. > > >> > > >>If this function is called once per 10 ms disk I/O operations then we > > >>lose 50% utilization.

Re: [Qemu-block] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set

2015-07-15 Thread Jason Wang
On 07/15/2015 03:57 PM, Paolo Bonzini wrote: > > On 15/07/2015 07:29, Jason Wang wrote: >> Cc: Stefan Hajnoczi >> Cc: Kevin Wolf >> Cc: qemu-block@nongnu.org >> Signed-off-by: Jason Wang >> --- >> hw/block/virtio-blk.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --g

Re: [Qemu-block] [Qemu-devel][PATCH]block/truncate: qcow2’s resize status is not showed to

2015-07-15 Thread Kevin Wolf
Am 15.07.2015 um 03:57 hat 김태하 geschrieben: > To put it briefly, when resize qcow2 image, the "file" tool detected increased > size. However, the "ls", “stat”, and “du” utility still don't know increased > size. The following patch enables to let userland tools - ls, du, stat - know > and apply cha

Re: [Qemu-block] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set

2015-07-15 Thread Paolo Bonzini
On 15/07/2015 10:31, Jason Wang wrote: > > This must only be done for newer machine types only, or you change guest > > ABI for scsi=off. Effectively you have to split it in two properties, > > "scsi" and "always_set_f_scsi". > > And always_set_f_scsi is true only for legacy machine types? s/le

Re: [Qemu-block] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set

2015-07-15 Thread Paolo Bonzini
On 15/07/2015 07:29, Jason Wang wrote: > Cc: Stefan Hajnoczi > Cc: Kevin Wolf > Cc: qemu-block@nongnu.org > Signed-off-by: Jason Wang > --- > hw/block/virtio-blk.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > inde