On Wed, Jul 22, 2015 at 02:27:46PM +0100, Richard W.M. Jones wrote:
> v3:
> Same as v2 but set the return value to -EIO.
>
Thanks, applied to my block tree:
https://github.com/codyprime/qemu-kvm-jtc/tree/block
Thanks,
Jeff
From: Hitoshi Mitake
Current sheepdog driver only serializes create requests in oid
unit. This mechanism isn't enough for handling requests to
overwrapping area spanning multiple oids, so it can result bugs like
below:
https://bugs.launchpad.net/sheepdog-project/+bug/1456421
This patch adds a ne
The following changes since commit f8787f8723eaca1be99e3b1873e54de163fffa93:
Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150727' into
staging (2015-07-27 19:37:09 +0100)
are available in the git repository at:
g...@github.com:codyprime/qemu-kvm-jtc.git tags/jtc-fo
From: "Richard W.M. Jones"
On some (but not all) systems:
$ qemu-img create -f qcow2 overlay -b ssh://xen/
Segmentation fault
It turns out this happens when inet_connect returns -1 in the
following code, but errno == 0.
s->sock = inet_connect(s->hostport, errp);
if (s->sock < 0) {
On Mon, Jul 27, 2015 at 11:21:42AM -0400, Jeff Cody wrote:
> The following changes since commit f793d97e454a56d17e404004867985622ca1a63b:
>
> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
> staging (2015-07-24 13:07:10 +0100)
>
> are available in the git repository at:
Ping...
Does anyone have time to review this patchset? The block replication is not
only for COLO. All
other HA/FT can reuse it(for example, microcheckpoint).
Thanks
Wen Congyang
On 07/07/2015 04:42 PM, Wen Congyang wrote:
> Block replication is a very important feature which is used for
> cont
There's no need for blk to set ANY_LAYOUT, it's
done by virtio core as necessary.
Signed-off-by: Michael S. Tsirkin
---
hw/block/virtio-blk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 44f9b8e..1556c9c 100644
--- a/hw/block/virtio-blk.c
On 07/27/2015 11:30 AM, Eric Blake wrote:
> When dealing with simple qapi unions, the code was generating a
> discriminator field of 'kind' even though the discriminator is
> sent as 'type' over QMP. Renaming things to match gets us one
> step closer to reusing common generator code for both simpl
Expose the two new options for controlling the memory usage of the
overlap check implementation via QAPI.
Signed-off-by: Max Reitz
---
qapi/block-core.json | 31 +++
1 file changed, 31 insertions(+)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 7b2ef
Keep track of the inactive L2 tables in the metadata list to protect
them against accidental modifications.
Signed-off-by: Max Reitz
---
block/qcow2-refcount.c | 20
block/qcow2-snapshot.c | 43 ---
2 files changed, 60 insertions(+), 3
Later, a mechanism to set a limit on how much memory may be used for the
overlap prevention structures will be introduced. If that limit is about
to be exceeded, a QMP event should be emitted. This very event is
specified by this patch.
Signed-off-by: Max Reitz
---
docs/qmp/qmp-events.txt | 27 +
Make the static new overlap check function global and drop the old
function.
Signed-off-by: Max Reitz
---
block/qcow2-overlap.c | 8 +---
block/qcow2-refcount.c | 120 -
2 files changed, 2 insertions(+), 126 deletions(-)
diff --git a/block/qcow
Keep track of the inactive L1 tables in the metadata list to protect
them against accidental modifications.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2-snapshot.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/block/qcow2-snapshot.c b/block/q
Keep track of the snapshot table in the metadata list to protect it
against accidental modifications.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2-snapshot.c | 10 ++
block/qcow2.c | 6 ++
2 files changed, 16 insertions(+)
diff --git a/block/qcow2-snap
Keep track of the refcount table in the metadata list to protect it
against accidental modifications.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2-refcount.c | 18 ++
block/qcow2.c | 4
2 files changed, 22 insertions(+)
diff --git a/block/qcow
Add runtime options to qcow2 to control the size of the structures used
for metadata overlap prevention (one option to control the size of the
bitmap cache, another one to control the total memory size limit).
Signed-off-by: Max Reitz
---
block/qcow2.c | 35 +--
b
Keep track of the active L1 table in the metadata list to protect it
against accidental modifications.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2-cluster.c | 11 +++
block/qcow2-snapshot.c | 10 ++
block/qcow2.c | 4
3 files changed, 25 inse
Keep track of the active L2 tables in the metadata list to protect them
against accidental modifications.
Signed-off-by: Max Reitz
---
block/qcow2-cluster.c | 2 ++
block/qcow2-refcount.c | 6 ++
block/qcow2-snapshot.c | 21 +
block/qcow2.c | 8 +++-
4 fi
Keep track of the refcount blocks in the metadata list to protect them
against accidental modifications.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2-refcount.c | 38 +-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/block/q
This patch adds some test cases for the memory limit concerning the
in-memory structures used to detect and prevent accidental metadata
overlaps.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/060 | 222 +
tests/qemu-iotests/060.out | 47
This adds an adjustable limit for the total memory usage of the overlap
prevention structures.
Signed-off-by: Max Reitz
---
block/qcow2-overlap.c | 183 +++---
block/qcow2.c | 2 +-
block/qcow2.h | 2 +-
3 files changed, 177 inserti
Create and destroy the metadata list on creation and destruction of a
qcow2 BDS, respectively. Skip creation if no overlap checks should be
performed.
Signed-off-by: Max Reitz
---
block/qcow2.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index 9
Pull up the absorption of the qcow2-relevant command line options and
the evaluation of the overlap check options in qcow2_open().
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2.c | 96 +--
1 file changed, 48 insertions(+
This is a continuation of previous versions of this series. v2's cover
letter was the most elaborate, which you can find here (includes
benchmarks):
http://lists.nongnu.org/archive/html/qemu-devel/2014-11/msg03430.html
See patch 1 for an explanation of why this series exists and what it
does. Patc
Enter the image header into the metadata list to protect it against
accidental modifications.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index d30d008..9815325 100644
--- a/block/qcow2.c
The existing qcow2 metadata overlap detection function used existing
structures to determine the location of the image metadata, from plain
fields such as l1_table_offset and l1_size in the BDRVQcowState, over
image structures in memory such as the L1 table for the L2 tables'
positions, or it even
When dealing with simple qapi unions, the code was generating a
discriminator field of 'kind' even though the discriminator is
sent as 'type' over QMP. Renaming things to match gets us one
step closer to reusing common generator code for both simple and
flat unions, without having to special case
Mac OS X can be picky when it comes to allowing the user to use physical devices
in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is
detected, a message is displayed showing the user how to unmount a volume.
Signed-off-by: John Arbuckle
---
Removed changes to GetBSDPath
Add a function qcow2_change_refcount_order() which allows changing the
refcount order of a qcow2 image.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2-refcount.c | 447 +
block/qcow2.h | 4 +
2 files changed, 451 inser
If the image version should be upgraded, that is the first we should do;
if it should be downgraded, that is the last we should do. So split the
version change block into an upgrade part at the start and a downgrade
part at the end.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: S
Add an opaque value which is to be passed to the bdrv_amend_options()
status callback.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
---
block.c | 4 ++--
block/qcow2-cluster.c | 14 --
block/qcow2.c | 9 +
From: Jeff Cody
This checks that VPC is able to successfully fail (without segfault)
on an image file with a max_table_entries that exceeds 0x4000.
This table entry is within the valid range for VPC (although too large
for this sample image).
Cc: qemu-sta...@nongnu.org
Signed-off-by: Jeff C
Add support for caching options that can be specified from
the command line.
Signed-off-by: John Arbuckle
---
block/raw-posix.c | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index cbe6574..67d1d48 100644
--- a/block
If there is more than one time-consuming operation to be performed for
qcow2_amend_options(), we need an intermediate CB which coordinates the
progress of the individual operations and passes the result to the
original status callback.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 14 ++
tests/qemu-iotests/061.out | 14 +++---
2 files changed, 13 insertions(+), 15 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 4051fdd..3bcb96e
On 07/27/2015 09:51 AM, Max Reitz wrote:
> Make use of qcow2_change_refcount_order() to support changing the
> refcount order with qemu-img amend.
>
> Signed-off-by: Max Reitz
> ---
> block/qcow2.c | 44 +++-
> 1 file changed, 35 insertions(+), 9 deletions
Add tests for conversion between different refcount widths.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
tests/qemu-iotests/112 | 109 +
tests/qemu-iotests/112.out | 71 +
2 files changed, 180 insertions(+)
di
If a reference count is not representable with the current refcount
order, the image check should point to qemu-img amend for increasing the
refcount order. However, qemu-img amend needs write access to the image
which cannot be provided if the image is marked corrupt; and the image
check will not
Make use of qcow2_change_refcount_order() to support changing the
refcount order with qemu-img amend.
Signed-off-by: Max Reitz
---
block/qcow2.c | 44 +++-
1 file changed, 35 insertions(+), 9 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 8
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 3bcb96e..a7f50db 100644
--- a/block/qcow2.c
+++ b/block/qcow2.
(v1..v7 were named "qcow2: Support refcount orders != 4")
This series contains the final 10 patches of my qcow2 refcount order
series, which add refcount order amendment functionality to qemu-img.
v9:
- Rebase on master
- Patch 8: s/qerror_report_err/error_report_err/
git backport-diff against
Progress may regress; this should be displayed correctly by
qemu_progress_print().
While touching that area of code, drop the redundant parentheses in the
same condition.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
---
util/qemu-progress.c | 3 ++-
1 file cha
From: Jeff Cody
When we allocate the pagetable based on max_table_entries, we multiply
the max table entry value by 4 to accomodate a table of 32-bit integers.
However, max_table_entries is a uint32_t, and the VPC driver accepts
ranges for that entry over 0x4000. So during this allocation:
The following changes since commit 122e7dab8ac549c8c5a9e1e13aa2464190e888de:
Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into
staging (2015-07-27 14:53:42 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to
On Mon, Jul 27, 2015 at 03:28:51PM +0200, Cornelia Huck wrote:
> On Mon, 27 Jul 2015 14:22:37 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Mon, Jul 27, 2015 at 12:30:19PM +0200, Paolo Bonzini wrote:
> > >
> > >
> > > On 27/07/2015 11:49, Jason Wang wrote:
> > > > So this patch only clear VIRTIO
The following changes since commit f793d97e454a56d17e404004867985622ca1a63b:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
(2015-07-24 13:07:10 +0100)
are available in the git repository at:
https://github.com/codyprime/qemu-kvm-jtc.git
tags/jtc-for-upstrea
From: Hitoshi Mitake
Current sheepdog driver only serializes create requests in oid
unit. This mechanism isn't enough for handling requests to
overwrapping area spanning multiple oids, so it can result bugs like
below:
https://bugs.launchpad.net/sheepdog-project/+bug/1456421
This patch adds a ne
On 07/02/2015 09:21 AM, Alberto Garcia wrote:
>
>>> 3) I don't think it's necessary to set to NULL the pointers in
>>> s->bs[i] when i >= num_children. There's no way to access those
>>> pointers anyway. Same for the ' s->bs[s->num_children] = NULL; ' bit
>>> in quorum_del_child(). I also think t
On Mon, Jul 27, 2015 at 2:58 PM, Peter Lieven wrote:
> I was experimenting a little with optimized zlib versions (like zlib-ng) to
> optimize the speed of compressed qcow2 generation.
>
> I found out that chaning the windowBits from -12 to -15 alone increases
> compression speed by about 15% while
Hi,
I was experimenting a little with optimized zlib versions (like zlib-ng) to
optimize the speed of compressed qcow2 generation.
I found out that chaning the windowBits from -12 to -15 alone increases
compression speed by about 15% while lowering
the compressed size by about 6%. As a test ca
On Mon, 27 Jul 2015 14:22:37 +0300
"Michael S. Tsirkin" wrote:
> On Mon, Jul 27, 2015 at 12:30:19PM +0200, Paolo Bonzini wrote:
> >
> >
> > On 27/07/2015 11:49, Jason Wang wrote:
> > > So this patch only clear VIRTIO_F_LAYOUT for legacy device.
> > >
> > > Cc: Stefan Hajnoczi
> > > Cc: Kevin
On 27/07/2015 08:55, Fam Zheng wrote:
> On Fri, 07/24 09:35, Paolo Bonzini wrote:
>>> That way, aio_context_acquire can be dropped by:
>>>
>>> /* @pause_owner_thread: a callback which will be called when _main
>>> thread_
>>> * wants exclusively operate on the AioContext, for example wi
On 27/07/2015 13:22, Michael S. Tsirkin wrote:
> > This patch is unnecessary, since the feature is added back below under
> > "if (__virtio_has_feature(features, VIRTIO_F_VERSION_1))".
>
> It's needed so we can apply
> virtio: set any_layout in virtio core
Ah, okay.
Paolo
On Mon, Jul 27, 2015 at 12:30:19PM +0200, Paolo Bonzini wrote:
>
>
> On 27/07/2015 11:49, Jason Wang wrote:
> > So this patch only clear VIRTIO_F_LAYOUT for legacy device.
> >
> > Cc: Stefan Hajnoczi
> > Cc: Kevin Wolf
> > Cc: qemu-block@nongnu.org
> > Signed-off-by: Jason Wang
> > ---
> > h
On 27/07/2015 11:49, Jason Wang wrote:
> So this patch only clear VIRTIO_F_LAYOUT for legacy device.
>
> Cc: Stefan Hajnoczi
> Cc: Kevin Wolf
> Cc: qemu-block@nongnu.org
> Signed-off-by: Jason Wang
> ---
> hw/block/virtio-blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> dif
On Fri, Jul 24, 2015 at 11:37:50AM -0400, Programmingkid wrote:
>
> On Jul 24, 2015, at 11:00 AM, Stefan Hajnoczi wrote:
>
> > On Fri, Jul 17, 2015 at 08:19:16PM -0400, Programmingkid wrote:
> >> @@ -2014,7 +2015,9 @@ kern_return_t GetBSDPath( io_iterator_t
> >> mediaIterator, char *bsdPath, CFI
On 27/07/2015 10:57, Hannes Reinecke wrote:
> Acked-by: Hannes Reinecke
Thanks, applied for 2.4.
Paolo
Chapter 6.3 of spec said
"
Transitional devices MUST offer, and if offered by the device
transitional drivers MUST accept the following:
VIRTIO_F_ANY_LAYOUT (27)
"
So this patch only clear VIRTIO_F_LAYOUT for legacy device.
Cc: Stefan Hajnoczi
Cc: Kevin Wolf
Cc: qemu-block@nongnu.org
Signed-o
On 07/27/2015 10:51 AM, Salva Peiró wrote:
> This patch fixes a QEMU SEGFAULT when a write operation is performed on
> the memory region of the PCI BAR 3 (base address space).
> When a writeb(0xe000) is performed the .write function is invoked to
> handle the write access, however, since the .w
This patch fixes a QEMU SEGFAULT when a write operation is performed on
the memory region of the PCI BAR 3 (base address space).
When a writeb(0xe000) is performed the .write function is invoked to
handle the write access, however, since the .write is not initialised,
the call to 0, causes QEMU
60 matches
Mail list logo
