Re: [Qemu-block] [PATCH] iotests: Fix test 128 for password-less sudo

2015-09-25 Thread Eric Blake
On 09/25/2015 11:19 AM, Max Reitz wrote: > As of 934659c460d46c948cf348822fda1d38556ed9a4, $QEMU_IO is generally no > longer a program name, and therefore "sudo -n $QEMU_IO" will no longer > work. > > Fix this by copying the qemu-io invocation function from common.config, > making it use $sudo for

Re: [Qemu-block] ide-test fails on PPC64 big-endian host

2015-09-25 Thread John Snow
On 09/25/2015 03:20 PM, Peter Maydell wrote: > Hi. I was looking at adding ppc64be to the set of machines I do build > tests on before merging patches, but right now "make check" fails on > this host. > > ERROR:/home/pm215/qemu/tests/ide-test.c:721:cdrom_pio_impl: assertion > failed ((data) & (D

Re: [Qemu-block] [PULL 0/7] Block patches

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 08:50, Jeff Cody wrote: > The following changes since commit eb9d0ea063fc7bdfab76b84085602a9e48d13ec7: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20150924' into staging (2015-09-24 > 01:32:11 +0100) > > are available in the git repository

[Qemu-block] ide-test fails on PPC64 big-endian host

2015-09-25 Thread Peter Maydell
Hi. I was looking at adding ppc64be to the set of machines I do build tests on before merging patches, but right now "make check" fails on this host. ERROR:/home/pm215/qemu/tests/ide-test.c:721:cdrom_pio_impl: assertion failed ((data) & (DRQ | DRDY) == (DRQ | DRDY)): (0x0040 == 0x0048) GTe

[Qemu-block] [PATCH] iotests: Fix test 128 for password-less sudo

2015-09-25 Thread Max Reitz
As of 934659c460d46c948cf348822fda1d38556ed9a4, $QEMU_IO is generally no longer a program name, and therefore "sudo -n $QEMU_IO" will no longer work. Fix this by copying the qemu-io invocation function from common.config, making it use $sudo for invoking $QEMU_IO_PROG, and then use that function i

[Qemu-block] [PULL 2/7] block/nfs: cache allocated filesize for read-only files

2015-09-25 Thread Jeff Cody
From: Peter Lieven If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang if block device info is queried and the NFS share is unresponsive. Signed

[Qemu-block] [PULL 3/7] sheepdog: add reopen support

2015-09-25 Thread Jeff Cody
From: Liu Yuan With reopen supported, block-commit (and offline commit) is now supported for image files whose base image uses the Sheepdog protocol driver. Cc: qemu-de...@nongnu.org Cc: Jeff Cody Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan Message-id: 1440730438-24676-1-git-s

[Qemu-block] [PULL 7/7] sheepdog: refine discard support

2015-09-25 Thread Jeff Cody
From: Hitoshi Mitake This patch refines discard support of the sheepdog driver. The existing discard mechanism was implemented on SD_OP_DISCARD_OBJ, which was introduced before fine grained reference counting on newer sheepdog. It doesn't care about relations of snapshots and clones and discards

[Qemu-block] [PULL 5/7] Backup: don't do copy-on-read in before_write_notifier

2015-09-25 Thread Jeff Cody
From: Wen Congyang We will copy data in before_write_notifier to do backup. It is a nested I/O request, so we cannot do copy-on-read. The steps to reproduce it: 1. -drive copy-on-read=on,... // qemu option 2. drive_backup -f disk0 /path_to_backup.img // monitor command Signed-off-by: Wen Congy

[Qemu-block] [PULL 4/7] block: Introduce a new API bdrv_co_no_copy_on_readv()

2015-09-25 Thread Jeff Cody
From: Wen Congyang In some cases, we need to disable copy-on-read, and just read the data. Signed-off-by: Wen Congyang Message-id: 1441682913-14320-2-git-send-email-we...@cn.fujitsu.com Signed-off-by: Jeff Cody --- block/io.c| 12 +++- include/block/block.h | 9 ++---

[Qemu-block] [PULL 1/7] block/nfs: fix calculation of allocated file size

2015-09-25 Thread Jeff Cody
From: Peter Lieven st.st_blocks is always counted in 512 byte units. Do not use st.st_blksize as multiplicator which may be larger. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven Reviewed-by: Max Reitz Reviewed-by: Jeff Cody Message-id: 1440067607-14547-1-git-send-email...@kamp.de Sig

[Qemu-block] [PULL 6/7] sheepdog: use per AIOCB dirty indexes for non overlapping requests

2015-09-25 Thread Jeff Cody
From: Hitoshi Mitake In the commit 96b14ff85acf, requests for overlapping areas are serialized. However, it cannot handle a case of non overlapping requests. In such a case, min_dirty_data_idx and max_dirty_data_idx can be overwritten by the requests and invalid inode update can happen e.g. a cas

[Qemu-block] [PULL 0/7] Block patches

2015-09-25 Thread Jeff Cody
The following changes since commit eb9d0ea063fc7bdfab76b84085602a9e48d13ec7: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150924' into staging (2015-09-24 01:32:11 +0100) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git tags/block-

Re: [Qemu-block] [Qemu-devel] [PATCH] block: disable I/O limits at the beginning of bdrv_close()

2015-09-25 Thread Alberto Garcia
On Fri 25 Sep 2015 04:22:26 PM CEST, Eric Blake wrote: >> Disabling I/O limits from a BDS also drains all pending throttled >> requests, so it should be done at the beginning of bdrv_close() with >> the rest of the bdrv_drain() calls before the BlockDriver is closed. > > Can this be abused? If I h

Re: [Qemu-block] [Qemu-devel] [PATCH] block: disable I/O limits at the beginning of bdrv_close()

2015-09-25 Thread Eric Blake
On 09/25/2015 07:41 AM, Alberto Garcia wrote: > Disabling I/O limits from a BDS also drains all pending throttled > requests, so it should be done at the beginning of bdrv_close() with > the rest of the bdrv_drain() calls before the BlockDriver is closed. Can this be abused? If I have a guest runn

Re: [Qemu-block] [PATCH 05/16] block: Convert bs->file to BdrvChild

2015-09-25 Thread Alberto Garcia
On Thu 17 Sep 2015 03:48:09 PM CEST, Kevin Wolf wrote: > @@ -1929,6 +1925,11 @@ void bdrv_close(BlockDriverState *bs) > bdrv_unref(backing_hd); > } > > +if (bs->file != NULL) { > +bdrv_unref(bs->file->bs); > +bs->file = NULL; > +} >

[Qemu-block] [PATCH] block: disable I/O limits at the beginning of bdrv_close()

2015-09-25 Thread Alberto Garcia
Disabling I/O limits from a BDS also drains all pending throttled requests, so it should be done at the beginning of bdrv_close() with the rest of the bdrv_drain() calls before the BlockDriver is closed. Signed-off-by: Alberto Garcia --- block.c | 11 ++- 1 file changed, 6 insertions(+),