On 11/13/2015 06:00 PM, Peter Lieven wrote:
>
>
>> Am 13.11.2015 um 23:42 schrieb John Snow :
>>
>>
>>
>>> On 11/12/2015 11:30 AM, Peter Lieven wrote:
>>> PIO read requests on the ATAPI interface used to be sync blk requests.
>>> This has two significant drawbacks. First the main loop hangs uti
> Am 13.11.2015 um 23:42 schrieb John Snow :
>
>
>
>> On 11/12/2015 11:30 AM, Peter Lieven wrote:
>> PIO read requests on the ATAPI interface used to be sync blk requests.
>> This has two significant drawbacks. First the main loop hangs util an
>> I/O request is completed and secondly if the I
On 11/12/2015 01:23 AM, Fam Zheng wrote:
> On Mon, 11/09 23:39, Max Reitz wrote:
>> bdrv_delete() is not very happy about deleting BlockDriverStates with
>> dirty bitmaps still attached to them. In the past, we got around that
>> very easily by relying on bdrv_close_all() bypassing bdrv_delete(),
On 11/12/2015 11:30 AM, Peter Lieven wrote:
> This series aims at avoiding a hanging main-loop if a vserver has a
> CDROM image mounted from a NFS share and that NFS share goes down.
> Typical situation is that users mount an CDROM ISO to install something
> and then forget to eject that CDROM af
On 11/12/2015 11:30 AM, Peter Lieven wrote:
> PIO read requests on the ATAPI interface used to be sync blk requests.
> This has two significant drawbacks. First the main loop hangs util an
> I/O request is completed and secondly if the I/O request does not
> complete (e.g. due to an unresponsive
On 11/13/2015 11:13 AM, Markus Armbruster wrote:
> We need c_name() to protect ticklish identifiers only when its result is
> used as identifier. Not when it's *part* of an identifier,
> e.g. prefixed with qapi_, or camel_to_upper(type_name) + '_'.
>
> We can protect even when we don't need to,
If we don't have the qemu-img tool, use the raw format
for tests and skip the high-sector LBA48 tests.
Signed-off-by: John Snow
---
tests/ahci-test.c | 41 -
1 file changed, 32 insertions(+), 9 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test
Skip tests that need qcow2 to function when qemu-img isn't
set or otherwise present.
When running under raw mode, we no longer properly test
LBA48 reads/writes beyond 137Gb. ahci-test will skip past
any //io//lba48//high test.
While we're at it, try to make failures due to missing qemu-img
binari
To allow tests to optionally exercise additional tests
that require the qemu-img tool that may not be present
in all builds.
Signed-off-by: John Snow
---
tests/libqos/libqos.c | 28 +++-
tests/libqos/libqos.h | 1 +
2 files changed, 24 insertions(+), 5 deletions(-)
diff
Signed-off-by: John Snow
---
tests/ahci-test.c | 51 +--
1 file changed, 29 insertions(+), 22 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 59d387c..6d9ac84 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -48,6 +48
On Fri, Nov 13, 2015 at 05:45:09PM +0800, Stefan Hajnoczi wrote:
> On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote:
> > recent libnfs versions support logging debug messages. Add
> > support for it in qemu through an URL parameter.
> >
> > Example:
> > qemu -cdrom nfs://127.0.0.1/iso
On 11/12/2015 02:51 PM, John Snow wrote:
> If we don't have the qemu-img tool, use the raw format
> for tests and skip the high-sector LBA48 tests.
>
> Signed-off-by: John Snow
> ---
> tests/ahci-test.c | 41 -
> 1 file changed, 32 insertions(+), 9 delet
Eric Blake writes:
> On 11/10/2015 11:51 PM, Eric Blake wrote:
>> When munging enum values, the fact that we were passing the entire
>> prefix + value through camel_to_upper() meant that enum values
>> spelled with CamelCase could be turned into CAMEL_CASE. However,
>> this provides a potential
On 11/10/2015 11:51 PM, Eric Blake wrote:
> When munging enum values, the fact that we were passing the entire
> prefix + value through camel_to_upper() meant that enum values
> spelled with CamelCase could be turned into CAMEL_CASE. However,
> this provides a potential collision (both OneTwo and
On 11/13/2015 06:13 AM, Mark Cave-Ayland wrote:
> On 12/11/15 16:30, Peter Lieven wrote:
>
>> This series aims at avoiding a hanging main-loop if a vserver has a
>> CDROM image mounted from a NFS share and that NFS share goes down.
>> Typical situation is that users mount an CDROM ISO to install
On 13/11/2015 10:32, Fam Zheng wrote:
> When a request R is absorbed by request M, it is appended to the
> "mr_next" queue led by M, and is completed together with the completion
> of M, in virtio_blk_rw_complete.
>
> With error policy equals stop, if M has an I/O error, now R also gets
> prepen
Otherwise the AioContext will never be released.
Signed-off-by: Alberto Garcia
---
blockdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/blockdev.c b/blockdev.c
index fc85128..4dcc510 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = {
Am 13.11.2015 um 12:19 hat Wen Congyang geschrieben:
> On 11/13/2015 06:53 PM, Kevin Wolf wrote:
> > Am 13.11.2015 um 11:25 hat Wen Congyang geschrieben:
> >> On 11/10/2015 09:40 AM, Wen Congyang wrote:
> >>> On 11/10/2015 12:04 AM, Kevin Wolf wrote:
> Am 16.10.2015 um 10:57 hat Wen Congyang g
On 11/13/2015 06:53 PM, Kevin Wolf wrote:
> Am 13.11.2015 um 11:25 hat Wen Congyang geschrieben:
>> On 11/10/2015 09:40 AM, Wen Congyang wrote:
>>> On 11/10/2015 12:04 AM, Kevin Wolf wrote:
Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben:
> +##
> +# @ChangeOperation:
> +#
>
On 12/11/15 16:30, Peter Lieven wrote:
> This series aims at avoiding a hanging main-loop if a vserver has a
> CDROM image mounted from a NFS share and that NFS share goes down.
> Typical situation is that users mount an CDROM ISO to install something
> and then forget to eject that CDROM afterwar
Am 13.11.2015 um 10:32 hat Paolo Bonzini geschrieben:
> > > On 10/11/2015 14:25, Rabin Vincent wrote:
> > >> The shifts of the address mask and value shift beyond 32 bits when there
> > >> are 5 address cycles.
> > >>
> > >> Signed-off-by: Rabin Vincent
> > >> ---
> > >> hw/block/nand.c |4 ++
Am 13.11.2015 um 11:25 hat Wen Congyang geschrieben:
> On 11/10/2015 09:40 AM, Wen Congyang wrote:
> > On 11/10/2015 12:04 AM, Kevin Wolf wrote:
> >> Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben:
> >>> +##
> >>> +# @ChangeOperation:
> >>> +#
> >>> +# An enumeration of block device change ope
On Fri 13 Nov 2015 11:15:52 AM CET, Stefan Hajnoczi wrote:
> blockdev.c: In function ‘blockdev_init’:
> blockdev.c:636:17: error: ‘length’ may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> block_acct_add_interval(blk_get_stats(blk), length);
>
On 13/11/2015 10:32, Fam Zheng wrote:
> When a request R is absorbed by request M, it is appended to the
> "mr_next" queue led by M, and is completed together with the completion
> of M, in virtio_blk_rw_complete.
>
> With error policy equals stop, if M has an I/O error, now R also gets
> prepen
On 11/10/2015 09:40 AM, Wen Congyang wrote:
> On 11/10/2015 12:04 AM, Kevin Wolf wrote:
>> Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben:
>>> +##
>>> +# @ChangeOperation:
>>> +#
>>> +# An enumeration of block device change operation.
>>> +#
>>> +# @add: Add a new block driver state to a exist
On Wed, Nov 11, 2015 at 09:59:26AM +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> 1. avoid possible superflous checking
> 2. make code more robustness
>
> Signed-off-by: Gonglei
> ---
> v4: address possible integer underover [Stefan]
>please review again, thanks
> ---
> hw/bloc
On Wed, Nov 11, 2015 at 03:17:12PM +0200, Alberto Garcia wrote:
> This is the natural JSON representation and prevents us from having to
> decode the list manually.
>
> Signed-off-by: Alberto Garcia
> ---
> blockdev.c | 64
> ++
> qapi
On Fri, Nov 13, 2015 at 5:37 PM, Wen Congyang wrote:
> On 11/13/2015 05:28 PM, Stefan Hajnoczi wrote:
>> On Fri, Oct 30, 2015 at 02:11:30PM +0800, Wen Congyang wrote:
>>> Ping...
>>
>> Tips for faster code review:
>>
>> It helps to mention the specific person you are expecting review from
>> when
Am 13.11.2015 um 10:45 schrieb Stefan Hajnoczi:
> On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote:
>> recent libnfs versions support logging debug messages. Add
>> support for it in qemu through an URL parameter.
>>
>> Example:
>> qemu -cdrom nfs://127.0.0.1/iso/my.iso?debug=2
>>
>> S
On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote:
> recent libnfs versions support logging debug messages. Add
> support for it in qemu through an URL parameter.
>
> Example:
> qemu -cdrom nfs://127.0.0.1/iso/my.iso?debug=2
>
> Signed-off-by: Peter Lieven
> ---
> v4->v5: add a comme
On 11/13/2015 05:28 PM, Stefan Hajnoczi wrote:
> On Fri, Oct 30, 2015 at 02:11:30PM +0800, Wen Congyang wrote:
>> Ping...
>
> Tips for faster code review:
>
> It helps to mention the specific person you are expecting review from
> when the CC list is long. For example, "Kevin: ping".
Do you mea
When a request R is absorbed by request M, it is appended to the
"mr_next" queue led by M, and is completed together with the completion
of M, in virtio_blk_rw_complete.
With error policy equals stop, if M has an I/O error, now R also gets
prepended to the per device DMA restart queue, which will
> > On 10/11/2015 14:25, Rabin Vincent wrote:
> >> The shifts of the address mask and value shift beyond 32 bits when there
> >> are 5 address cycles.
> >>
> >> Signed-off-by: Rabin Vincent
> >> ---
> >> hw/block/nand.c |4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> d
On Fri, Oct 30, 2015 at 02:11:30PM +0800, Wen Congyang wrote:
> Ping...
Tips for faster code review:
It helps to mention the specific person you are expecting review from
when the CC list is long. For example, "Kevin: ping".
Keeping the CC list short can result in faster code review than a long
34 matches
Mail list logo
