Re: [Qemu-block] [Qemu-devel] [Patch v8 3/3] qmp: add monitor command to add/remove a child

On 11/27/2015 02:06 PM, Wen Congyang wrote: The new QMP command name is x-blockdev-change. It's just for adding/removing quorum's child now, and doesn't support all kinds of children, all kinds of operations, nor all block drivers. So it is experimental now. Signed-off-by: Wen Congyang

Re: [Qemu-block] [Qemu-devel] [Patch v8 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 11/27/2015 02:06 PM, Wen Congyang wrote: Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 8 ++-- block/quorum.c| 124

[Qemu-block] [PATCH 1/1] block/raw-posix: avoid bogus fixup for cylinders on DASD disks

large volume DASD that have > 64k cylinders do claim to have 0xFFFE cylinders as special value in the old 16 bit field. We want to pass this "token" along to the guest, instead of calculating the real number. Otherwise qemu might fail with "cyls must be between 1 and 65535" Acked-by: Cornelia

[Qemu-block] [PATCH 0/1] Fixup for DASD geometry detection

Kevin, here is a fixup for the geometry detection. We tried to be overly clever and calculate the cyclinder size for devices > 64k cyls. Now this is wrong for the cyls parameter as the interface only has 16bit. Large DASD devices have a special token (0xfffe) that indicate to the DASD related

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

Peter Maydell writes: > On 11 December 2015 at 15:43, Max Reitz wrote: >> On 2015-12-11 at 16:40, Peter Maydell wrote: >>> >>> On 11 December 2015 at 15:30, Eric Blake wrote: On 12/11/2015 08:23 AM, Max Reitz wrote:

Re: [Qemu-block] RFC: Status of the intermediate block streaming work

On Mon 14 Dec 2015 09:23:11 AM CET, Stefan Hajnoczi wrote: >> 2) When a block-stream operation calls bdrv_reopen(), it drains all >> images. This can trigger the completion of a different >> block-stream operation, that will remove the intermediate images >>

Re: [Qemu-block] [PATCH V2] fix:readcapacity 10 failure was shown even 16 sent

[adding qemu-devel - ALL patches must cc qemu-devel, even if they are also sent to a sublist like qemu-block] On 12/13/2015 07:52 PM, Zhu Lingshan wrote: > Follow Peter's comment, it is the patch V2. This sentence should appear... > This patch can fix that error: readcapacity 10 failure will

Re: [Qemu-block] [PATCH v2 3/4] qemu-img: abort when full_backing_filename not present

On 12.12.2015 02:25, John Snow wrote: > ...But only if we have the backing_filename. It means something Scary > happened and we can't really be quite exactly sure if we can trust the > backing_filename. > > Signed-off-by: John Snow > --- > qemu-img.c | 5 - > 1 file

Re: [Qemu-block] [PATCH v2 2/4] block/qapi: always report full_backing_filename

On 12.12.2015 02:25, John Snow wrote: > Always report full_backing_filename, even if it's the same as > backing_filename. In the next patch, full_backing_filename may be > omitted if it cannot be generated instead of allowing e.g. drive_query > to abort if it runs into this scenario. > > The

Re: [Qemu-block] [PATCH v2 2/4] block/qapi: always report full_backing_filename

On 14.12.2015 17:38, John Snow wrote: > > > On 12/14/2015 11:36 AM, Max Reitz wrote: >> On 12.12.2015 02:25, John Snow wrote: >>> Always report full_backing_filename, even if it's the same as >>> backing_filename. In the next patch, full_backing_filename may be >>> omitted if it cannot be

Re: [Qemu-block] [PATCH v2 0/4] block: allow partial info-block query

On 12/14/2015 12:13 PM, Max Reitz wrote: > On 12.12.2015 02:25, John Snow wrote: >> Max: Did you have in mind something like this? > > What I had in mind was fixing the whole thing (the test case in 110 > should actually work just fine, because you can easily determine the > base directory to

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] block/raw-posix: avoid bogus fixup for cylinders on DASD disks

Christian Borntraeger writes: > large volume DASD that have > 64k cylinders do claim to have > 0xFFFE cylinders as special value in the old 16 bit field. We > want to pass this "token" along to the guest, instead of > calculating the real number. Otherwise qemu might fail

Re: [Qemu-block] [PATCH v2 2/4] block/qapi: always report full_backing_filename

On 12/14/2015 11:36 AM, Max Reitz wrote: > On 12.12.2015 02:25, John Snow wrote: >> Always report full_backing_filename, even if it's the same as >> backing_filename. In the next patch, full_backing_filename may be >> omitted if it cannot be generated instead of allowing e.g. drive_query >> to

Re: [Qemu-block] [PATCH v2 4/4] block/qapi: allow best-effort query

On 12.12.2015 02:25, John Snow wrote: > For more complex BDS trees that can be created under normal circumstances, > we lose the ability to issue query commands because of our inability to > re-construct the absolute filename. > > Instead, omit this field when it is a problem and present as much

Re: [Qemu-block] [PATCH v2 0/4] block: allow partial info-block query

On 12.12.2015 02:25, John Snow wrote: > Max: Did you have in mind something like this? What I had in mind was fixing the whole thing (the test case in 110 should actually work just fine, because you can easily determine the base directory to be used). ;-) I've been working on that myself anyway,

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.6 v2 04/10] fdc: add default drive type option

On 12/07/2015 06:56 PM, Eric Blake wrote: > On 12/07/2015 04:34 PM, John Snow wrote: >> This patch adds a new explicit Floppy Drive Type option. The existing >> behavior in QEMU is to automatically guess a drive type based on the >> media inserted, or if a diskette is not present, arbitrarily

Re: [Qemu-block] [PATCH v3 5/5] block/qapi: allow best-effort query

On 14.12.2015 20:55, John Snow wrote: > For more complex BDS trees that can be created under normal circumstances, > we lose the ability to issue query commands because of our inability to > re-construct the absolute filename. > > Instead, omit this field when it is a problem and present as much

Re: [Qemu-block] [PATCH v3 3/5] block/qapi: explicitly warn if !has_full_backing_filename

On 14.12.2015 20:55, John Snow wrote: > Disambiguate "Backing filename and full backing filename" are equivalent > from "full backing filename could not be determined." > > Signed-off-by: John Snow > --- > block/qapi.c | 7 --- > 1 file changed, 4 insertions(+), 3

[Qemu-block] [PATCH v3 5/5] block/qapi: allow best-effort query

For more complex BDS trees that can be created under normal circumstances, we lose the ability to issue query commands because of our inability to re-construct the absolute filename. Instead, omit this field when it is a problem and present as much information as we can. This will change the

[Qemu-block] [PATCH v3 2/5] block/qapi: always report full_backing_filename

Always report full_backing_filename, even if it's the same as backing_filename. In the next patch, full_backing_filename may be omitted if it cannot be generated instead of allowing e.g. drive_query to abort if it runs into this scenario. The presence or absence of the "full" field becomes useful

[Qemu-block] [PATCH v3 4/5] qemu-img: abort when full_backing_filename not present

...But only if we have the backing_filename. It means something Scary happened and we can't really be quite exactly sure if we can trust the backing_filename. Signed-off-by: John Snow Reviewed-by: Max Reitz --- qemu-img.c | 5 - 1 file changed, 4

[Qemu-block] [PATCH v3 0/5] block: allow partial info-block query

Allow info-block to succeed even when it cannot reconstruct filenames, but be explicit about this failure. Utilities that rely on the current behavior are modified to report this explicit failure to users. v3: - Fix qemu-img output such that "backing file IS the absolute backing path" and

[Qemu-block] [PATCH v3 1/5] block/qapi: do not redundantly print "actual path"

If it happens to match the backing path, that was the actual path. Signed-off-by: John Snow Reviewed-by: Max Reitz --- block/qapi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/qapi.c b/block/qapi.c index 267f147..01569da

[Qemu-block] [PATCH v3 3/5] block/qapi: explicitly warn if !has_full_backing_filename

Disambiguate "Backing filename and full backing filename" are equivalent from "full backing filename could not be determined." Signed-off-by: John Snow --- block/qapi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index

Re: [Qemu-block] [PATCH v3 3/5] block/qapi: explicitly warn if !has_full_backing_filename

On 14.12.2015 20:55, John Snow wrote: > Disambiguate "Backing filename and full backing filename" are equivalent Just noticed: R-b is assuming s/" are equivalent/ are equivalent"/. Max > from "full backing filename could not be determined." > > Signed-off-by: John Snow > ---

Re: [Qemu-block] [PATCH 1/1] block/raw-posix: avoid bogus fixup for cylinders on DASD disks

On Mon, 14 Dec 2015 16:41:19 +0100 Christian Borntraeger wrote: > large volume DASD that have > 64k cylinders do claim to have > 0xFFFE cylinders as special value in the old 16 bit field. We > want to pass this "token" along to the guest, instead of > calculating the real

Re: [Qemu-block] RFC: Status of the intermediate block streaming work

On Thu, Dec 10, 2015 at 06:07:54PM +0100, Alberto Garcia wrote: > Hi all, > > I have been retaking my work on the intermediate block streaming > patches. Here's a summary of this feature and the current problems: > > The goal is to be able to perform a 'block-stream' operation on a node >

Re: [Qemu-block] [PATCH v3 0/5] block: allow partial info-block query

On 14.12.2015 20:55, John Snow wrote: > Allow info-block to succeed even when it cannot reconstruct filenames, > but be explicit about this failure. Utilities that rely on the current > behavior are modified to report this explicit failure to users. > > v3: > - Fix qemu-img output such that