Re: [Qemu-block] [PATCH v10 3/3] qmp: add monitor command to add/remove a child

2016-03-05 Thread Max Reitz
On 16.02.2016 10:37, Changlong Xie wrote: > From: Wen Congyang > > The new QMP command name is x-blockdev-change. It's just for adding/removing > quorum's child now, and doesn't support all kinds of children, all kinds of > operations, nor all block drivers. So it is experimental now. > > Signed

Re: [Qemu-block] [PATCH v10 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-05 Thread Max Reitz
On 16.02.2016 10:37, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie > --- > block.c | 8 ++-- > block/quorum.c| 122 > +++

Re: [Qemu-block] [PATCH v10 1/3] Add new block driver interface to add/delete a BDS's child

2016-03-05 Thread Max Reitz
Sorry that I wasn't so pedantic last time; or maybe I should rather be sorry that I'm so pedantic this time. On 16.02.2016 10:37, Changlong Xie wrote: > From: Wen Congyang > > In some cases, we want to take a quorum child offline, and take > another child online. > > Signed-off-by: Wen Congyang

[Qemu-block] [PATCH v4 07/10] qapi: Don't special-case simple union wrappers

2016-03-05 Thread Eric Blake
Simple unions were carrying a special case that hid their 'data' QMP member from the resulting C struct, via the hack method QAPISchemaObjectTypeVariant.simple_union_type(). But by using the work we started by unboxing flat union and alternate branches, coupled with the ability to visit the member

Re: [Qemu-block] block: Dirty bitmaps and COR in bdrv_move_feature_fields()

2016-03-05 Thread Max Reitz
First of all: I heard someone (not that someone, the other someone) asking whether I had any opinion on the matter, and my response was the following: I don't like "bool float", because of two reasons: First, "floating" implies that thinks can be forced somewhere else temporarily before floating

Re: [Qemu-block] [Qemu-devel] [PATCH v4 RFC 00/17] qcow2: persistent dirty bitmaps

2016-03-05 Thread Vladimir Sementsov-Ogievskiy
On 04.03.2016 21:00, John Snow wrote: On 02/17/2016 10:28 AM, Vladimir Sementsov-Ogievskiy wrote: This series add persistent dirty bitmaps feature to qcow2. Specification is in docs/spec/qcow2.txt (not merged yet, see [PATCH v10] spec: add qcow2 bitmaps extension specification) This series are