Re: [Qemu-block] [PATCH v22 00/10] Block replication for continuous checkpoints

2016-07-25 Thread Changlong Xie
On 07/25/2016 10:34 PM, Stefan Hajnoczi wrote: On Mon, Jul 25, 2016 at 11:44:34AM +0800, Changlong Xie wrote: COLO block is the necessary prerequisite of COLO framework and COLO network, what are blocked by these patchsets now. Since v19, Stefan said he had reviewed most part of this patchsets.

Re: [Qemu-block] [PATCH v2] mirror: double performance of the bulk stage if the disc is full

2016-07-25 Thread Jeff Cody
On Thu, Jul 14, 2016 at 08:19:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Mirror can do up to 16 in-flight requests, but actually on full copy > (the whole source disk is non-zero) in-flight is always 1. This happens > as the request is not limited in size: the data occupies maximum available

Re: [Qemu-block] [PATCH v2] mirror: double performance of the bulk stage if the disc is full

2016-07-25 Thread Jeff Cody
On Thu, Jul 14, 2016 at 08:19:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Mirror can do up to 16 in-flight requests, but actually on full copy > (the whole source disk is non-zero) in-flight is always 1. This happens > as the request is not limited in size: the data occupies maximum available

Re: [Qemu-block] [PATCH v22 10/10] support replication driver in blockdev-add

2016-07-25 Thread Changlong Xie
On 07/26/2016 07:00 AM, Max Reitz wrote: On 22.07.2016 12:16, Wang WeiWei wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Eric Blake Signed-off-by: Wang WeiWei --- qapi/block-core.json |

Re: [Qemu-block] [PATCH v22 07/10] Introduce new APIs to do replication operation

2016-07-25 Thread Changlong Xie
On 07/26/2016 06:23 AM, Max Reitz wrote: +# @primary: Primary mode, the vm's state will be sent to secondary QEMU. >+# >+# @secondary: Secondary mode, receive the vm's state from primary QEMU. >+# >+# Since: 2.7 Probably 2.8 now. I'll update 2.7 to 2.8 for all these series Max

Re: [Qemu-block] [PATCH v22 03/10] Backup: export interfaces for extra serialization

2016-07-25 Thread Changlong Xie
On 07/26/2016 05:50 AM, Max Reitz wrote: On 22.07.2016 12:16, Wang WeiWei wrote: From: Changlong Xie Normal backup(sync='none') workflow: step 1. NBD peformance I/O write from client to server qcow2_co_writev bdrv_co_writev ... bdrv_aligned_pwritev notifier_with

Re: [Qemu-block] [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint

2016-07-25 Thread Changlong Xie
On 07/26/2016 05:18 AM, Max Reitz wrote: On 22.07.2016 12:15, Wang WeiWei wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- block/backup.c | 18 +

Re: [Qemu-block] [PATCH v22 00/10] Block replication for continuous checkpoints

2016-07-25 Thread Max Reitz
On 25.07.2016 16:34, Stefan Hajnoczi wrote: > On Mon, Jul 25, 2016 at 11:44:34AM +0800, Changlong Xie wrote: >> COLO block is the necessary prerequisite of COLO framework and COLO network, >> what are blocked by these patchsets now. >> >> Since v19, Stefan said he had reviewed most part of this pat

Re: [Qemu-block] [PATCH v22 10/10] support replication driver in blockdev-add

2016-07-25 Thread Max Reitz
On 22.07.2016 12:16, Wang WeiWei wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie > Reviewed-by: Eric Blake > Signed-off-by: Wang WeiWei > --- > qapi/block-core.json | 19 +-- >

Re: [Qemu-block] [PATCH v22 07/10] Introduce new APIs to do replication operation

2016-07-25 Thread Max Reitz
On 22.07.2016 12:16, Wang WeiWei wrote: > From: Changlong Xie > > This commit introduces six replication interfaces(for block, network etc). > Firstly we can use replication_(new/remove) to create/destroy replication > instances, then in migration we can use replication_(start/stop/do_checkpoint

Re: [Qemu-block] [PATCH v22 03/10] Backup: export interfaces for extra serialization

2016-07-25 Thread Max Reitz
On 22.07.2016 12:16, Wang WeiWei wrote: > From: Changlong Xie > > Normal backup(sync='none') workflow: > step 1. NBD peformance I/O write from client to server >qcow2_co_writev > bdrv_co_writev > ... >bdrv_aligned_pwritev > notifier_with_return_list_notify -> backup_d

Re: [Qemu-block] [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint

2016-07-25 Thread Max Reitz
On 22.07.2016 12:15, Wang WeiWei wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > --- > block/backup.c | 18 ++ > include/block/bloc

Re: [Qemu-block] [Qemu-devel] [PATCH v5 0/3] Dynamic module loading for block drivers

2016-07-25 Thread Max Reitz
On 25.07.2016 15:56, Colin Lord wrote: > On 07/23/2016 02:21 PM, Max Reitz wrote: >> On 20.07.2016 16:30, Colin Lord wrote: >>> Here's v5 of the modularization series. Since it seems the concensus is >>> that modularizing the format drivers is unnecessary, this series no >>> longer modularizes thos

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: fix error messages emitted by img_open()

2016-07-25 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Thu, Jul 21, 2016 at 10:41:53AM +0200, Reda Sallahi wrote: >> img_open_file() and img_open_opts() were printing error messages with a >> duplicate part because of a wrong use of error_reportf_err() (e.g. >> qemu-img: Could not open 'foo': Could not open 'foo': No such

[Qemu-block] [PATCH for-2.8] qtail: clean up direct access to tqe_prev field

2016-07-25 Thread Igor Mammedov
instead of accessing tqe_prev field dircetly outside of queue.h use macros to check if element is in list and make sure that afer element is removed from list tqe_prev field could be used to do the same check. Signed-off-by: Igor Mammedov --- The patch is split from as cleanup is not urgent [PA

Re: [Qemu-block] [PATCH v22 00/10] Block replication for continuous checkpoints

2016-07-25 Thread Stefan Hajnoczi
On Mon, Jul 25, 2016 at 11:44:34AM +0800, Changlong Xie wrote: > COLO block is the necessary prerequisite of COLO framework and COLO network, > what are blocked by these patchsets now. > > Since v19, Stefan said he had reviewed most part of this patchsets. So, this > series *REALLY* need more comm

Re: [Qemu-block] [Qemu-devel] [PATCH v5 0/3] Dynamic module loading for block drivers

2016-07-25 Thread Colin Lord
On 07/23/2016 02:21 PM, Max Reitz wrote: > On 20.07.2016 16:30, Colin Lord wrote: >> Here's v5 of the modularization series. Since it seems the concensus is >> that modularizing the format drivers is unnecessary, this series no >> longer modularizes those and is thus much shorter than before. >> >>