Re: [Qemu-block] [PATCH v23 12/12] MAINTAINERS: add maintainer for replication

On 07/27/2016 12:25 AM, Max Reitz wrote: +replication While some acronyms are written fully in lower case in this file, this is not an acronym, so I'd capitalize it as "Replication", or maybe call it "Block replication" instead. I just know the rule and "Repliation" is good for me. >+M:

Re: [Qemu-block] [PATCH v23 11/12] support replication driver in blockdev-add

On 07/27/2016 12:22 AM, Max Reitz wrote: On 26.07.2016 10:15, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei

[Qemu-block] [PATCH for-2.7 0/1] ide: fix halted IO segfault at reset

For convenience, this branch is available at: https://github.com/jnsnow/qemu.git branch ide-reset-segfault https://github.com/jnsnow/qemu/tree/ide-reset-segfault This version is tagged ide-reset-segfault-v1:

[Qemu-block] [PULL 2/2] mirror: double performance of the bulk stage if the disc is full

From: Vladimir Sementsov-Ogievskiy Mirror can do up to 16 in-flight requests, but actually on full copy (the whole source disk is non-zero) in-flight is always 1. This happens as the request is not limited in size: the data occupies maximum available capacity of s->buf.

[Qemu-block] [PULL 1/2] block/gluster: fix doc in the qapi schema and member name

From: Prasanna Kumar Kalever 1. qapi @BlockdevOptionsGluster schema member name s/debug_level/debug-level/ 2. rearrange the versioning 3. s/server description/servers description/ Signed-off-by: Prasanna Kumar Kalever Reviewed-by: Eric

[Qemu-block] [PULL 0/2] Block patches for 2.7

The following changes since commit f49ee630d73729ecaeecf4b38a8df11bc613914d: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160726' into staging (2016-07-26 11:53:47 +0100) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git tags/block-pull

Re: [Qemu-block] [libvirt] [libvirt RFC PATCH 02/10] util: storage: Add parser for qemu's "json" backing pseudo-protocol

On 07/15/2016 07:46 AM, Peter Krempa wrote: > Add a modular parser that will allow to parse 'json' backing definitions > that are supported by qemu. The initial implementation adds support for > the 'file' driver. Might be nice for this commit message to show an actual json: string that it now

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/1] block: improve error handling in raw_open

Dear Max, Max Reitz writes: >> So how about: >> >> /* >> * Just like error_setg(), with @os_error info added to the message. >> * If @os_error is non-zero, ": " + strerror(os_error) is appended to >> * the human-readable error message. >> + * >> + * Reminder: errno

Re: [Qemu-block] [libvirt] [libvirt RFC PATCH 01/10] tests: Add testing of backing store string parser

On 07/15/2016 07:46 AM, Peter Krempa wrote: > As we already test that the extraction of the backing store string works > well additional tests for the backing store string parser can be made > simpler. > > Export virStorageSourceNewFromBackingAbsolute and use it to parse the > backing store

Re: [Qemu-block] [PATCH for-2.6 0/2] Fix regression with the default naming of throttling groups

On 07/26/2016 11:34 AM, Max Reitz wrote: > On 26.07.2016 14:52, Alberto Garcia wrote: >> On Fri, Jul 08, 2016 at 05:05:12PM +0300, Alberto Garcia wrote: >>> Hi, >>> >>> Stefan reported this, this is a regression caused by commit >>> efaa7c4eeb7490c6f37f3. >>> >>> I sent a separate series for the

Re: [Qemu-block] [PATCH v2 1/1] block: improve error handling in raw_open

On 07/26/2016 07:34 AM, Halil Pasic wrote: > Make raw_open for POSIX more consistent in handling errors by setting > the error object also when qemu_open fails. The error object was set > generally set in case of errors, but I guess this case was overlooked. > Do the same for win32. > >

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/1] block: improve error handling in raw_open

On 26.07.2016 20:03, Sascha Silbe wrote: > Dear Max, > > Max Reitz writes: > >> We don't guarantee that error_setg_errno() does not modify errno. (In >> practice it should not, but we don't guarantee that.) > > I agree it's a good general policy to _not_ rely on the callee >

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/1] block: improve error handling in raw_open

Dear Max, Max Reitz writes: > We don't guarantee that error_setg_errno() does not modify errno. (In > practice it should not, but we don't guarantee that.) I agree it's a good general policy to _not_ rely on the callee explicitly saving and restoring errno. Especially since

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/1] block: improve error handling in raw_open

On 26.07.2016 19:18, Halil Pasic wrote: > > > On 07/26/2016 05:42 PM, Max Reitz wrote: >>> +++ b/block/raw-posix.c @@ -485,6 +485,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options, s->fd = -1; fd = qemu_open(filename, s->open_flags, 0644);

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/1] block: improve error handling in raw_open

On 26.07.2016 19:18, Halil Pasic wrote: > > > On 07/26/2016 05:42 PM, Max Reitz wrote: >>> +++ b/block/raw-posix.c @@ -485,6 +485,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options, s->fd = -1; fd = qemu_open(filename, s->open_flags, 0644);

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/1] block: improve error handling in raw_open

On 07/26/2016 05:42 PM, Max Reitz wrote: >> +++ b/block/raw-posix.c >> > @@ -485,6 +485,7 @@ static int raw_open_common(BlockDriverState *bs, QDict >> > *options, >> > s->fd = -1; >> > fd = qemu_open(filename, s->open_flags, 0644); >> > if (fd < 0) { >> > +

Re: [Qemu-block] [PATCH v2] iotest: fix python based IO tests

On 26.07.2016 18:16, Daniel P. Berrange wrote: > The previous commit refactoring iotests.py: > > commit 66613974468fb6e1609fb3eabf55981b1ee436cf > Author: Daniel P. Berrange > Date: Wed Jul 20 14:23:10 2016 +0100 > > scripts: refactor the VM class in iotests for

Re: [Qemu-block] [PATCH v23 12/12] MAINTAINERS: add maintainer for replication

On 26.07.2016 10:15, Changlong Xie wrote: > As per Stefan's suggestion, add Wen and I as co-maintainers > of replication. > > Cc: Stefan Hajnoczi > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > --- >

Re: [Qemu-block] [PATCH v23 11/12] support replication driver in blockdev-add

On 26.07.2016 10:15, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > Signed-off-by: zhanghailiang

Re: [Qemu-block] [PATCH v23 09/12] Implement new driver for block replication

On 26.07.2016 10:15, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > Signed-off-by: zhanghailiang

[Qemu-block] [PATCH v2] iotest: fix python based IO tests

The previous commit refactoring iotests.py: commit 66613974468fb6e1609fb3eabf55981b1ee436cf Author: Daniel P. Berrange Date: Wed Jul 20 14:23:10 2016 +0100 scripts: refactor the VM class in iotests for reuse was not properly tested and included a number of

Re: [Qemu-block] [PATCH v2 1/1] block: improve error handling in raw_open

On 26.07.2016 13:34, Halil Pasic wrote: > Make raw_open for POSIX more consistent in handling errors by setting > the error object also when qemu_open fails. The error object was set > generally set in case of errors, but I guess this case was overlooked. > Do the same for win32. > >

Re: [Qemu-block] [PATCH for-2.6 0/2] Fix regression with the default naming of throttling groups

On 26.07.2016 14:52, Alberto Garcia wrote: > On Fri, Jul 08, 2016 at 05:05:12PM +0300, Alberto Garcia wrote: >> Hi, >> >> Stefan reported this, this is a regression caused by commit >> efaa7c4eeb7490c6f37f3. >> >> I sent a separate series for the git master, this is the backport >> for QEMU

Re: [Qemu-block] [PATCH] iotest: fix python based IO tests

On 26.07.2016 15:13, Daniel P. Berrange wrote: > The previous commit refactoring iotests.py: > > commit 66613974468fb6e1609fb3eabf55981b1ee436cf > Author: Daniel P. Berrange > Date: Wed Jul 20 14:23:10 2016 +0100 > > scripts: refactor the VM class in iotests for

Re: [Qemu-block] [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard

On Thu, Jul 21, 2016 at 01:34:48PM -0600, Eric Blake wrote: > Dell Equallogic iSCSI SANs have a very unusual advertised geometry: > > $ iscsi-inq -e 1 -c $((0xb0)) iscsi://XXX/0 > wsnz:0 > maximum compare and write length:1 > optimal transfer length granularity:0 > maximum transfer length:0 >

[Qemu-block] [PATCH] iotest: fix python based IO tests

The previous commit refactoring iotests.py: commit 66613974468fb6e1609fb3eabf55981b1ee436cf Author: Daniel P. Berrange Date: Wed Jul 20 14:23:10 2016 +0100 scripts: refactor the VM class in iotests for reuse was not properly tested and included a number of

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: fix error messages emitted by img_open()

On Mon, Jul 25, 2016 at 05:58:54PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Thu, Jul 21, 2016 at 10:41:53AM +0200, Reda Sallahi wrote: > >> img_open_file() and img_open_opts() were printing error messages with a > >> duplicate part because of a

Re: [Qemu-block] [PATCH for-2.6 0/2] Fix regression with the default naming of throttling groups

On Fri, Jul 08, 2016 at 05:05:12PM +0300, Alberto Garcia wrote: > Hi, > > Stefan reported this, this is a regression caused by commit > efaa7c4eeb7490c6f37f3. > > I sent a separate series for the git master, this is the backport > for QEMU v2.6.0. ping Berto

[Qemu-block] [PATCH v2 1/1] block: improve error handling in raw_open

Make raw_open for POSIX more consistent in handling errors by setting the error object also when qemu_open fails. The error object was set generally set in case of errors, but I guess this case was overlooked. Do the same for win32. Signed-off-by: Halil Pasic

[Qemu-block] [PATCH v23 10/12] tests: add unit test case for replication

Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- tests/.gitignore | 1 + tests/Makefile.include | 4 + tests/test-replication.c | 575

[Qemu-block] [PATCH v23 09/12] Implement new driver for block replication

From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei

[Qemu-block] [PATCH v23 08/12] Introduce new APIs to do replication operation

This commit introduces six replication interfaces(for block, network etc). Firstly we can use replication_(new/remove) to create/destroy replication instances, then in migration we can use replication_(start/stop/do_checkpoint /get_error)_all to handle all replication operations. More detail

[Qemu-block] [PATCH v23 11/12] support replication driver in blockdev-add

From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei

[Qemu-block] [PATCH v23 12/12] MAINTAINERS: add maintainer for replication

As per Stefan's suggestion, add Wen and I as co-maintainers of replication. Cc: Stefan Hajnoczi Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff

[Qemu-block] [PATCH v23 07/12] configure: support replication

configure --(enable/disable)-replication to switch replication support on/off, and it is on by default. We later introduce replation support. Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei

[Qemu-block] [PATCH v23 05/12] docs: block replication's description

From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei

[Qemu-block] [PATCH v23 00/12] Block replication for continuous checkpoints

Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the detailed information about block replication from here: http://wiki.qemu.org/Features/BlockReplication Usage: Please refer to docs/block-replication.txt You can get the

[Qemu-block] [PATCH v23 04/12] Link backup into block core

From: Wen Congyang Some programs that add a dependency on it will use the block layer directly. Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei

[Qemu-block] [PATCH v23 03/12] Backup: export interfaces for extra serialization

Normal backup(sync='none') workflow: step 1. NBD peformance I/O write from client to server qcow2_co_writev bdrv_co_writev ... bdrv_aligned_pwritev notifier_with_return_list_notify -> backup_do_cow bdrv_driver_pwritev // write new contents step 2. drive-backup

[Qemu-block] [PATCH v23 01/12] unblock backup operations in backing file

From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- block.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block.c

[Qemu-block] [PATCH v23 06/12] auto complete active commit

From: Wen Congyang Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei ---