Re: [Qemu-block] [Qemu-devel] [PATCH 1/7] util: Add UUID API

On Wed, Aug 03, 2016 at 10:36:40AM +0800, Fam Zheng wrote: > On Tue, 08/02 15:45, Paolo Bonzini wrote: > > > > > > - Original Message - > > > From: "Fam Zheng" > > > To: qemu-de...@nongnu.org > > > Cc: f...@redhat.com, berra...@redhat.com, pbonz...@redhat.com, > > >

Re: [Qemu-block] [Qemu-devel] [PATCH 1/7] util: Add UUID API

On Tue, 08/02 15:45, Paolo Bonzini wrote: > > > - Original Message - > > From: "Fam Zheng" > > To: qemu-de...@nongnu.org > > Cc: f...@redhat.com, berra...@redhat.com, pbonz...@redhat.com, > > kw...@redhat.com, mre...@redhat.com, > > mdr...@linux.vnet.ibm.com,

Re: [Qemu-block] [PATCH for-2.7] block: Accept any target node for transactional blockdev-backup

On 08/02/2016 01:22 PM, Kevin Wolf wrote: Commit 0d978913 changed blockdev-backup to accept arbitrary node names instead of device names (i.e. root nodes) for the backup target. However, it forgot to make the same change in transactions and to update http://i.imgur.com/PfBxuOb.gif the

Re: [Qemu-block] [Qemu-devel] [Bug 1608802] [NEW] READ_DMA (0xC8) command does not work correctly

- Original Message - Am 02.08.2016 um 08:52 hat Stefan Weil geschrieben: Am 02.08.2016 um 08:11 schrieb Stefan Weil: > Public bug reported: > > The QEMU PC emulation of DMA does not behave like real hardware or other > virtualization software. > > >From the original bug report (Benjamin

Re: [Qemu-block] [PATCH 1/7] util: Add UUID API

- Original Message - > From: "Fam Zheng" > To: qemu-de...@nongnu.org > Cc: f...@redhat.com, berra...@redhat.com, pbonz...@redhat.com, > kw...@redhat.com, mre...@redhat.com, > mdr...@linux.vnet.ibm.com, arm...@redhat.com, s...@weilnetz.de, > qemu-block@nongnu.org >

[Qemu-block] [PATCH for-2.7] atapi: fix halted DMA reset

Followup to 87ac25fd, this time for ATAPI DMA. Reported-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/atapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 95056d9..6189675 100644 --- a/hw/ide/atapi.c

Re: [Qemu-block] [PATCH] resize qcow2 with snapshot

Am 02.08.2016 um 15:43 hat zhangzhiming geschrieben: > ping > > zhangzhiming > zhangzhimin...@meituan.com I replied to you on July 11: http://lists.nongnu.org/archive/html/qemu-devel/2016-07/msg02241.html Message-ID: <20160711131710.gc5...@noname.redhat.com> Did you not receive the email?

[Qemu-block] [PATCH for-2.7] block: Accept any target node for transactional blockdev-backup

Commit 0d978913 changed blockdev-backup to accept arbitrary node names instead of device names (i.e. root nodes) for the backup target. However, it forgot to make the same change in transactions and to update the documentation. This patch fixes these omissions. Signed-off-by: Kevin Wolf

Re: [Qemu-block] [PATCH for-2.7 1/1] ide: fix halted IO segfault at reset

> >> diff --git a/hw/ide/core.c b/hw/ide/core.c > >> index 081c9eb..d117b7c 100644 > >> --- a/hw/ide/core.c > >> +++ b/hw/ide/core.c > >> @@ -823,6 +823,7 @@ static void ide_dma_cb(void *opaque, int ret) > >> } > >> if (ret < 0) { > >> if (ide_handle_rw_error(s, -ret, > >>

Re: [Qemu-block] [PATCH for-2.7 1/1] ide: fix halted IO segfault at reset

> > The patch is (was, since it's committed :)) okay, but I think there is > > another bug in the REPORT case, where ide_rw_error and > > ide_atapi_io_error are not calling ide_set_inactive and thus are leaving > > s->bus->dma->aiocb non-NULL. > > > > Paolo > > > > Actually, won't we hit

Re: [Qemu-block] [PATCH v4 03/11] block: Accept node-name for blockdev-backup

Am 18.07.2016 um 15:59 hat Max Reitz geschrieben: > On 14.07.2016 15:28, Kevin Wolf wrote: > > In order to remove the necessity to use BlockBackend names in the > > external API, we want to allow node-names everywhere. This converts > > blockdev-backup and the corresponding transaction action to

Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] blockjob: fix dead pointer in txn list

On 08/02/2016 07:05 AM, Vladimir Sementsov-Ogievskiy wrote: On 02.08.2016 01:39, John Snow wrote: On 07/27/2016 06:49 AM, Vladimir Sementsov-Ogievskiy wrote: Job may be freed in block_job_unref and in this case this would break transaction QLIST. Fix this by removing job from this list

Re: [Qemu-block] [PATCH v4 02/11] block: Accept node-name for block-commit

Am 01.08.2016 um 15:35 hat Alberto Garcia geschrieben: > On Thu 14 Jul 2016 03:28:05 PM CEST, Kevin Wolf wrote: > > -blk = blk_by_name(device); > > -if (!blk) { > > -error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND, > > - "Device '%s' not found", device); > > +bs =

Re: [Qemu-block] [PATCH v4 09/11] block: Accept node-name for drive-mirror

Am 18.07.2016 um 16:30 hat Max Reitz geschrieben: > On 14.07.2016 15:28, Kevin Wolf wrote: > > In order to remove the necessity to use BlockBackend names in the > > external API, we want to allow node-names everywhere. This converts > > drive-mirror to accept a node-name without lifting the

Re: [Qemu-block] [PATCH v6 0/4] Dynamic module loading for block drivers

On 08/02/2016 10:12 AM, Colin Lord wrote: > I'm sending one more version of this series. v5 didn't seem to need any > huge makeovers, but I found a small bug in it so I'm hoping it hasn't > been committed yet. In v5, if a user explicitly specified the driver to > use, eg driver=gluster, and the

[Qemu-block] [PATCH v6 4/4] blockdev: Modularize nfs block driver

Modularizes the nfs block driver so that it gets dynamically loaded. --- block/Makefile.objs | 1 + configure | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/Makefile.objs b/block/Makefile.objs index 595f366..fa4d8b8 100644 --- a/block/Makefile.objs +++

[Qemu-block] [PATCH v6 0/4] Dynamic module loading for block drivers

I'm sending one more version of this series. v5 didn't seem to need any huge makeovers, but I found a small bug in it so I'm hoping it hasn't been committed yet. In v5, if a user explicitly specified the driver to use, eg driver=gluster, and the driver was modularized, it was not correctly

[Qemu-block] [PATCH v6 2/4] blockdev: Add dynamic generation of module_block.h

From: Marc Mari To simplify the addition of new block modules, add a script that generates module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí

[Qemu-block] [PATCH v6 1/4] blockdev: prepare iSCSI block driver for dynamic loading

This commit moves the initialization of the QemuOptsList qemu_iscsi_opts struct out of block/iscsi.c in order to allow the iscsi module to be dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Fam Zheng --- block/iscsi.c | 36

[Qemu-block] [PATCH v6 3/4] blockdev: Add dynamic module loading for block drivers

Extend the current module interface to allow for block drivers to be loaded dynamically on request. The only block drivers that can be converted into modules are the drivers that don't perform any init operation except for registering themselves. In addition, only the protocol drivers are being

Re: [Qemu-block] [PATCH] resize qcow2 with snapshot

ping zhangzhiming zhangzhimin...@meituan.com > On Jun 24, 2016, at 7:10 PM, zhangzhiming wrote: > > qcow2 can’t be resized while there is a snapshot in qcow2 image but in > version 3 image of qcow2, > each disk size of snapshot is stored in the image, so we can

Re: [Qemu-block] [Qemu-devel] [Bug 1608802] [NEW] READ_DMA (0xC8) command does not work correctly

Am 02.08.2016 um 08:52 hat Stefan Weil geschrieben: > Am 02.08.2016 um 08:11 schrieb Stefan Weil: > > Public bug reported: > > > > The QEMU PC emulation of DMA does not behave like real hardware or other > > virtualization software. > > > > >From the original bug report (Benjamin David Lunt): > >

Re: [Qemu-block] [PATCH 1/3] blockjob: fix dead pointer in txn list

On 02.08.2016 01:39, John Snow wrote: On 07/27/2016 06:49 AM, Vladimir Sementsov-Ogievskiy wrote: Job may be freed in block_job_unref and in this case this would break transaction QLIST. Fix this by removing job from this list before unref. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-block] [PATCH] backup: block-job error BUG

On 02.08.2016 01:36, John Snow wrote: On 07/18/2016 05:22 PM, Vladimir Sementsov-Ogievskiy wrote: Hi all! This is a variant of existing test case which produces test failure. It looks like the reason is: one block job is in backup_complete, in synchronous bdrv_flush (success job) other

[Qemu-block] [PATCH 7/7] configure: Remove detection code for UUID

All code now uses built-in UUID implementation. Remove the code of libuuid and make --enable-uuid and --disable-uuid only print a message. Signed-off-by: Fam Zheng --- configure | 43 --- 1 file changed, 4 insertions(+), 39 deletions(-)

[Qemu-block] [PATCH 6/7] tests: No longer dependent on CONFIG_UUID

crypto now uses built-in uuid implementation, so this check is not needed. Signed-off-by: Fam Zheng --- tests/test-crypto-block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-crypto-block.c b/tests/test-crypto-block.c index a38110d..1957a86

[Qemu-block] [PATCH 1/7] util: Add UUID API

A number of different places across the code base use CONFIG_UUID. Some of them are soft dependency, some are not built if libuuid is not available, some come with dummy fallback, some throws runtime error. It is hard to maintain, and hard to reason for users. Since UUID is a simple standard

[Qemu-block] [PATCH 4/7] vpc: Use QEMU UUID API

Previously we conditionally generate if footer->uuid, when libuuid is available. Now that we have a built-in implementation, we can switch to it. Signed-off-by: Fam Zheng --- block/vpc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/block/vpc.c

[Qemu-block] [PATCH 5/7] crypto: Switch to QEMU UUID API

The uuid generation doesn't return error, so update the function signature and calling code accordingly. Signed-off-by: Fam Zheng --- crypto/block-luks.c | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/crypto/block-luks.c

[Qemu-block] [PATCH 3/7] vdi: Use QEMU UUID API

The QEMU UUID api, including the data structure (qemu_uuid_t), is fully compatible with libuuid. Use it, and remove the unused code. Signed-off-by: Fam Zheng --- block/vdi.c | 49 ++--- 1 file changed, 10 insertions(+), 39

[Qemu-block] [PATCH 0/7] UUID clean ups for 2.8

The facts how we use libuuid now are not particularly pleasant. - VHDX driver depends on uuid, but is unconditionally checked in iotests 109. If it is not built, the test would fail, leaving no hint about that. In fact this even makes the feature implementation a bit ugly because it

[Qemu-block] [PATCH 2/7] vhdx: Use QEMU UUID API

This removes our dependency to libuuid, so that the driver can always be built. Similar to how we handled data plane configure options, --enable-vhdx and --disable-vhdx are also changed to a nop with a message saying it's obsolete. Signed-off-by: Fam Zheng ---