Re: [Qemu-block] [Qemu-devel] fix incorrect identify implementation in nvme

2016-08-04 Thread Markus Armbruster
Keith Busch writes: > On Thu, Aug 04, 2016 at 09:42:13PM +0200, Christoph Hellwig wrote: >> Third resent of this series after this didn't get picked up the >> previous times. The Qemu NVMe implementation mistakes the cns >> field in the Identify command as a boolean. This was never >> true, and

Re: [Qemu-block] [Qemu-devel] [PATCH 3/7] vdi: Use QEMU UUID API

2016-08-04 Thread Markus Armbruster
Eric Blake writes: > On 08/04/2016 12:58 PM, Stefan Weil wrote: >> Hi, >> >> On 08/02/16 11:18, Fam Zheng wrote: >>> The QEMU UUID api, including the data structure (qemu_uuid_t), is fully >>> compatible with libuuid. Use it, and remove the unused code. >>> >>> Signed-off-by: Fam Zheng >>> ---

Re: [Qemu-block] [PATCH] MAINTAINERS: Add Fam and Jsnow for Bitmap support

2016-08-04 Thread Fam Zheng
On Thu, 08/04 14:18, John Snow wrote: > These files are currently unmaintained. > > I'm proposing that Fam and I co-maintain them; under the model that > whomever between us isn't authoring a given series will be responsible > for reviewing it. > > Signed-off-by: John Snow > --- > MAINTAINERS |

[Qemu-block] [PATCH 2/2] nvme: bump PCI revision

2016-08-04 Thread Christoph Hellwig
The broken Identify implementation in earlier Qemu versions means we need to blacklist it from issueing the NVMe 1.1 Identify Namespace List command. As we want to be able to use it in newer Qemu versions we need a way to identify those. Bump the PCI revision as a guest visible indicator of this

[Qemu-block] fix incorrect identify implementation in nvme

2016-08-04 Thread Christoph Hellwig
Third resent of this series after this didn't get picked up the previous times. The Qemu NVMe implementation mistakes the cns field in the Identify command as a boolean. This was never true, and is actively harmful since NVMe1.1 (which the Qemu device claims to support) supports more than two Ide

[Qemu-block] [PATCH 1/2] nvme: fix identify to be NVMe 1.1 compliant

2016-08-04 Thread Christoph Hellwig
NVMe 1.1 requires devices to implement a Namespace List subcommand of the identify command. Qemu not only not implements this features, but also misinterprets it as an Identify Controller request. Due to this any OS trying to use the Namespace List will fail the probe. Signed-off-by: Christoph H

Re: [Qemu-block] [Qemu-devel] [PATCH 3/7] vdi: Use QEMU UUID API

2016-08-04 Thread Eric Blake
On 08/04/2016 12:58 PM, Stefan Weil wrote: > Hi, > > On 08/02/16 11:18, Fam Zheng wrote: >> The QEMU UUID api, including the data structure (qemu_uuid_t), is fully >> compatible with libuuid. Use it, and remove the unused code. >> >> Signed-off-by: Fam Zheng >> --- >> block/vdi.c | 49 +

Re: [Qemu-block] fix incorrect identify implementation in nvme

2016-08-04 Thread Keith Busch
On Thu, Aug 04, 2016 at 09:42:13PM +0200, Christoph Hellwig wrote: > Third resent of this series after this didn't get picked up the > previous times. The Qemu NVMe implementation mistakes the cns > field in the Identify command as a boolean. This was never > true, and is actively harmful since N

Re: [Qemu-block] [PATCH 3/7] vdi: Use QEMU UUID API

2016-08-04 Thread Stefan Weil
Hi, On 08/02/16 11:18, Fam Zheng wrote: > The QEMU UUID api, including the data structure (qemu_uuid_t), is fully > compatible with libuuid. Use it, and remove the unused code. > > Signed-off-by: Fam Zheng > --- > block/vdi.c | 49 ++--- > 1 file cha

Re: [Qemu-block] [Qemu-devel] [PATCH] ide: fix DMA register transitions

2016-08-04 Thread John Snow
On 08/02/2016 06:05 PM, John Snow wrote: ATA8-APT defines the state transitions for both a host controller and for the hardware device during the lifecycle of a DMA transfer, in section 9.7 "DMA command protocol." One of the interesting tidbits here is that when a device transitions from DDMA0

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.7] atapi: fix halted DMA reset

2016-08-04 Thread John Snow
On 08/02/2016 02:55 PM, John Snow wrote: Followup to 87ac25fd, this time for ATAPI DMA. Reported-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/atapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 95056d9..6189675 100644 --- a/hw/ide/atapi

[Qemu-block] [PATCH] MAINTAINERS: Add Fam and Jsnow for Bitmap support

2016-08-04 Thread John Snow
These files are currently unmaintained. I'm proposing that Fam and I co-maintain them; under the model that whomever between us isn't authoring a given series will be responsible for reviewing it. Signed-off-by: John Snow --- MAINTAINERS | 14 ++ 1 file changed, 14 insertions(+) di

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] ide: ide-cd without drive property for empty drive

2016-08-04 Thread Eric Blake
On 08/01/2016 01:47 PM, Kevin Wolf wrote: > Am 14.07.2016 um 21:48 hat Eric Blake geschrieben: >> On 07/14/2016 07:49 AM, Kevin Wolf wrote: >>> This allows to create an empty ide-cd device without manually creating a >>> BlockBackend. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> hw/ide/qdev.c |

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.7 v2] block/qdev: Let 'drive' property fall back to node name

2016-08-04 Thread Eric Blake
On 08/04/2016 06:09 AM, Kevin Wolf wrote: > If a qdev block device is created with an anonymous BlockBackend (i.e. > a node name rather than a BB name was given for the drive property), > qdev used to return an empty string when the property was read. This > patch fixes it to return the node name i

Re: [Qemu-block] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Daniel P. Berrange
On Tue, Aug 02, 2016 at 05:18:32PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to maintain

Re: [Qemu-block] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Jeff Cody
On Tue, Aug 02, 2016 at 05:18:32PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to maintain

Re: [Qemu-block] [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Marc-André Lureau
Hi On Thu, Aug 4, 2016 at 4:44 PM Paolo Bonzini wrote: > > > On 03/08/2016 04:36, Fam Zheng wrote: > > On Tue, 08/02 15:45, Paolo Bonzini wrote: > >> > >> > >> - Original Message - > >>> From: "Fam Zheng" > >>> To: qemu-de...@nongnu.org > >>> Cc: f...@redhat.com, berra...@redhat.com, pb

Re: [Qemu-block] [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Paolo Bonzini
On 03/08/2016 04:36, Fam Zheng wrote: > On Tue, 08/02 15:45, Paolo Bonzini wrote: >> >> >> - Original Message - >>> From: "Fam Zheng" >>> To: qemu-de...@nongnu.org >>> Cc: f...@redhat.com, berra...@redhat.com, pbonz...@redhat.com, >>> kw...@redhat.com, mre...@redhat.com, >>> mdr...@linu

Re: [Qemu-block] [PATCH for-2.7] block/qdev: Let 'drive' property fall back to node name

2016-08-04 Thread Kevin Wolf
Am 04.08.2016 um 14:03 hat Kevin Wolf geschrieben: > If a qdev block device is created with an anonymous BlockBackend (i.e. > a node name rather than a BB name was given for the drive property), > qdev used to return an empty string when the property was read. This > patch fixes it to return the no

Re: [Qemu-block] [PATCH for-2.7] block: Accept any target node for transactional blockdev-backup

2016-08-04 Thread Stefan Hajnoczi
On Tue, Aug 02, 2016 at 07:22:04PM +0200, Kevin Wolf wrote: > Commit 0d978913 changed blockdev-backup to accept arbitrary node names > instead of device names (i.e. root nodes) for the backup target. > However, it forgot to make the same change in transactions and to update > the documentation. Thi

[Qemu-block] [PATCH for-2.7 v2] block/qdev: Let 'drive' property fall back to node name

2016-08-04 Thread Kevin Wolf
If a qdev block device is created with an anonymous BlockBackend (i.e. a node name rather than a BB name was given for the drive property), qdev used to return an empty string when the property was read. This patch fixes it to return the node name instead. Signed-off-by: Kevin Wolf --- v2: - Chec

[Qemu-block] [PATCH for-2.7] block/qdev: Let 'drive' property fall back to node name

2016-08-04 Thread Kevin Wolf
If a qdev block device is created with an anonymous BlockBackend (i.e. a node name rather than a BB name was given for the drive property), qdev used to return an empty string when the property was read. This patch fixes it to return the node name instead. Signed-off-by: Kevin Wolf --- hw/core/q

Re: [Qemu-block] [PATCH for-2.7 v2 0/2] Don't allow burst limits to be lower than the normal limits

2016-08-04 Thread Stefan Hajnoczi
On Thu, Jul 28, 2016 at 11:08:11AM +0300, Alberto Garcia wrote: > Hello, > > Gu Nini found this problem and reported it in > > https://bugzilla.redhat.com/show_bug.cgi?id=1355665 > > When setting the throttling configuration, the burst limits can be > lower than the normal limits. This does not

Re: [Qemu-block] [PATCH v24 05/12] docs: block replication's description

2016-08-04 Thread Stefan Hajnoczi
On Wed, Jul 27, 2016 at 03:01:46PM +0800, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > docs/block-replication.txt | 239 > +++

Re: [Qemu-block] [PATCH v24 03/12] Backup: export interfaces for extra serialization

2016-08-04 Thread Stefan Hajnoczi
On Wed, Jul 27, 2016 at 03:01:44PM +0800, Changlong Xie wrote: > Normal backup(sync='none') workflow: > step 1. NBD peformance I/O write from client to server >qcow2_co_writev > bdrv_co_writev > ... >bdrv_aligned_pwritev > notifier_with_return_list_notify -> backup_do_c

Re: [Qemu-block] [PATCH v24 02/12] Backup: clear all bitmap when doing block checkpoint

2016-08-04 Thread Stefan Hajnoczi
On Wed, Jul 27, 2016 at 03:01:43PM +0800, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > block/backup.c | 18 +

Re: [Qemu-block] [PATCH v24 01/12] unblock backup operations in backing file

2016-08-04 Thread Stefan Hajnoczi
On Wed, Jul 27, 2016 at 03:01:42PM +0800, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > --- > block.c | 17 + > 1 file changed, 17 insertions(+) Reviewed-by: Stefan Hajnoczi signature

Re: [Qemu-block] [PATCH v7 00/16] backup compression

2016-08-04 Thread Stefan Hajnoczi
On Fri, Jul 22, 2016 at 11:17:39AM +0300, Denis V. Lunev wrote: > The idea is simple - backup is "written-once" data. It is written block > by block and it is large enough. It would be nice to save storage > space and compress it. > > These patches add the ability to compress data during backup. T

Re: [Qemu-block] [PATCH v7 02/16] block: Convert bdrv_pwrite_compressed() to BdrvChild

2016-08-04 Thread Stefan Hajnoczi
On Fri, Jul 22, 2016 at 11:17:41AM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin > > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > Reviewed-by: Eric Blake > CC: Jeff Cody > CC: Markus Armbruster > CC: Eric Blake > CC: John Snow > CC: Stefan Hajnoczi > CC: Kevin Wol

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] iotests: fix 109

2016-08-04 Thread Sascha Silbe
Dear Max, Max Reitz writes: > On 03.08.2016 17:22, Sascha Silbe wrote: [...] >> What are the exact semantics of the "offset" field for >> BLOCK_JOB_COMPLETED? >> >> docs/qmp-events.txt is rather vague. As an API consumer I'd have assumed >> that everything up to offset has been completed succes