Hi,
>From the QAPI schema documentation of 'blockdev-mirror':
# @target: the id or node-name of the block device to mirror to. This
mustn't be attached to guest.
Why must the target, prepared by 'blockdev-add', be not attached to the
guest? (Side question: is this via 'device_add
On Tue 16 Aug 2016 04:02:10 PM CEST, Kevin Wolf wrote:
> If a block job is started with a node name rather than a device name and
> no explicit job ID is passed, it was reported that '' isn't a
"it was" ?
> well-formed ID. Which is correct, but we can make the message a little
> bit nicer.
>
> Si
On Tue, Aug 16, 2016 at 04:02:10PM +0200, Kevin Wolf wrote:
> If a block job is started with a node name rather than a device name and
> no explicit job ID is passed, it was reported that '' isn't a
> well-formed ID. Which is correct, but we can make the message a little
> bit nicer.
>
> Signed-of
On 09.08.2016 16:15, Vladimir Sementsov-Ogievskiy wrote:
Source disk is created and filled with test data before each test case.
Instead initialize it once for the whole unit.
Test disk filling patterns are merged into one pattern.
Also TestSetSpeed used different image_len for source and targe
If a block job is started with a node name rather than a device name and
no explicit job ID is passed, it was reported that '' isn't a
well-formed ID. Which is correct, but we can make the message a little
bit nicer.
Signed-off-by: Kevin Wolf
---
blockjob.c | 4
1 file changed, 4 insertions
[I erroneously gave a Tested-by to the next patch (02/12) in this
series, instead of this one.]
On Wed, Jul 27, 2016 at 03:01:42PM +0800, Changlong Xie wrote:
> From: Wen Congyang
>
> Signed-off-by: Wen Congyang
> Signed-off-by: Changlong Xie
> Signed-off-by: Wang WeiWei
> ---
> block.c | 17
On Tue, Aug 16, 2016 at 02:55:41PM +0200, Kashyap Chamarthy wrote:
> On Wed, Jul 27, 2016 at 03:01:43PM +0800, Changlong Xie wrote:
> > From: Wen Congyang
> >
> > Signed-off-by: Wen Congyang
> > Signed-off-by: Changlong Xie
> > Signed-off-by: Wang WeiWei
> > Signed-off-by: zhanghailiang
> > S
On Wed, Jul 27, 2016 at 03:01:43PM +0800, Changlong Xie wrote:
> From: Wen Congyang
>
> Signed-off-by: Wen Congyang
> Signed-off-by: Changlong Xie
> Signed-off-by: Wang WeiWei
> Signed-off-by: zhanghailiang
> Signed-off-by: Gonglei
> ---
> block/backup.c | 18 +
On Mon, Aug 15, 2016 at 02:11:49PM +0200, Reda Sallahi wrote:
> dd was creating an output image regardless of whether there was one already
> created. With this patch we try to open first the output image and resize it
> if necessary.
>
> We also make it mandatory to specify conv=notrunc when the
On Tue, Aug 16, 2016 at 11:37:28AM +0100, Daniel P. Berrange wrote:
> On Tue, Aug 16, 2016 at 01:26:12PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > Reviewed-by: John Snow
> > Signed-off-by: Vladimir Sementsov-Ogievskiy
> > ---
> > block/dirty-bitmap.c | 1 +
> > include/qemu/hbitmap.h | 8
On Tue, Aug 16, 2016 at 01:26:12PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Reviewed-by: John Snow
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/dirty-bitmap.c | 1 +
> include/qemu/hbitmap.h | 8
> qapi/block-core.json | 5 -
> util/hbitmap.c | 8 +
The only problem with it is the same qmp socket name (which is
vm._monitor_path) for all vms. And because of this second vm couldn't be
lauched (vm.launch() fails because of socket is already in use).
This patch adds a number of vm into vm._monitor_path
Reviewed-by: John Snow
Signed-off-by: Vladi
Like bdrv_next() - bdrv_next_dirty_bitmap() is a function to provide
access to private dirty bitmaps list.
Reviewed-by: John Snow
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 10 ++
include/block/dirty-bitmap.h | 3 +++
2 files changed, 13 insertions(
Split common postcopy staff from ram postcopy staff.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/migration/migration.h | 1 +
migration/migration.c | 39 +++
migration/postcopy-ram.c | 4 +++-
migration/savevm.c| 31 +
There would be savevm states (dirty-bitmap) which can migrate only in
postcopy stage. The corresponding pending is introduced here.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/migration/vmstate.h | 5 +++--
include/sysemu/sysemu.h | 5 +++--
migration/block.c | 7 +++
Postcopy migration of dirty bitmaps. Only named dirty bitmaps,
associated with root nodes and non-root named nodes are migrated.
If destination qemu is already containing a dirty bitmap with the same name
as a migrated bitmap (for the same node), than, if their granularities are
the same the migra
Enabling bitmap successor is necessary to enable successors of bitmaps
being migrated before target vm start.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 5 +
include/block/dirty-bitmap.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/block/dirty-bit
Reviewed-by: John Snow
Reviewed-by: Eric Blake
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/migration/migration.h | 1 +
migration/migration.c | 9 +
qapi-schema.json | 4 +++-
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/include/migrati
Add function opposite to qemu_get_counted_string.
qemu_put_counted_string puts one-byte length of the string (string
should not be longer than 255 characters), and then it puts the string,
without last zero byte.
Reviewed-by: John Snow
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/mig
To just release successor and unfreeze bitmap without any additional
work.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
---
block/dirty-bitmap.c | 10 ++
include/block/dirty-bitmap.h | 2 ++
2 files changed, 12 insertions(+)
diff --git a/block/dirt
Reviewed-by: John Snow
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index fade81e..37c0f63 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tes
Enable postcopy if dirty bitmap migration is endabled.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 7d56a8e..a3bb518 100644
--- a/migration/migration.c
Now postcopy-able states are recognized by not NULL
save_live_complete_postcopy handler. But when we have several different
postcopy-able states, it is not convenient. Ram postcopy may be
disabled, while some other postcopy enabled, in this case Ram state
should behave as it is not postcopy-able.
When testing migration, auto-generated by qemu node-names differs in
source and destination qemu and migration fails. After this patch,
auto-generated by iotest nodenames will be the same.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 3 ++-
1 file changed, 2 in
Only-postcopy savevm states (dirty-bitmap) don't need live iteration, so
to disable them and stop transporting empty sections there is a new
savevm handler.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/migration/vmstate.h | 1 +
migration/savevm.c | 5 +
2 files changed,
Test
- start two vms (vm_a, vm_b)
- in a
- do writes from set A
- do writes from set B
- fix bitmap md5
- clear bitmap
- do writes from set A
- start migration
- than, in b
- wait vm start (postcopy should start)
- do writes from set B
- check btimap md5
The te
v2:
some bugs fixed, iotests a bit changed and merged into one test.
based on block-next (https://github.com/XanClic/qemu/commits/block-next)
clone: tag postcopy-v2 from https://src.openvz.org/scm/~vsementsov/qemu.git
online:
https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=refs%2Ftags
The test starts two vms (vm_a, vm_b), create dirty bitmap in
the first one, do several writes to corresponding device and
then migrate vm_a to vm_b with dirty bitmaps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/169 | 84 ++
Reviewed-by: John Snow
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 1 +
include/qemu/hbitmap.h | 8
qapi/block-core.json | 5 -
util/hbitmap.c | 8
4 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/block/dirty-bitmap.c b/b
Fill postcopy-able pending only if ram postcopy is enabled.
It is necessary because of there will be other postcopy-able states and
when ram postcopy is disabled, it should not spoil common postcopy
related pending.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
migration/ram.c | 8 ++--
1
On 15 August 2016 at 14:57, Kevin Wolf wrote:
> The following changes since commit 60ac136102098a70b97ab0c07bc7bf53131c:
>
> target-arm: Fix warn about implicit conversion (2016-08-12 11:12:24 +0100)
>
> are available in the git repository at:
>
> git://repo.or.cz/qemu/kevin.git tags/for-u
On Tue, 08/16 15:59, Fam Zheng wrote:
> diff --git a/block/Makefile.objs b/block/Makefile.objs
> index fa4d8b8..141dec5 100644
> --- a/block/Makefile.objs
> +++ b/block/Makefile.objs
> @@ -40,6 +40,7 @@ gluster.o-libs := $(GLUSTERFS_LIBS)
> ssh.o-cflags := $(LIBSSH2_CFLAGS)
> ssh.o-libs
dmg.o was moved to block-obj-m in 5505e8b76 to become a separate module,
so that its reference to libbz2, since 6b383c08c, doesn't add an extra
library to the main executable.
Until recently, commit 06e60f70a (blockdev: Add dynamic module loading
for block drivers) moved it back to block-obj-y to
Signed-off-by: Fam Zheng
---
scripts/modules/module_block.py | 5 -
1 file changed, 5 deletions(-)
diff --git a/scripts/modules/module_block.py b/scripts/modules/module_block.py
index db4fb54..7efec00 100644
--- a/scripts/modules/module_block.py
+++ b/scripts/modules/module_block.py
@@ -56,1
Use a hash table to keep record of all loaded modules, and return early
if the requested module is already loaded.
Signed-off-by: Fam Zheng
---
util/module.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/util/module.c b/util/module.c
index a5f7fbd..63ef
v2: Rebase on top of Max's block-next tree, which has Colin's patches to
dynamically load block modules.
Two more tweaks to the module system is added.
v1 was submitted as a single patch:
https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg00508.html
Fam Zheng (3):
scripts: Allow
36 matches
Mail list logo