Re: [Qemu-block] [PATCH v2 03/11] Blockjobs: Internalize user_pause logic

2016-10-03 Thread John Snow
On 10/03/2016 08:57 PM, Jeff Cody wrote: On Fri, Sep 30, 2016 at 06:00:41PM -0400, John Snow wrote: BlockJobs will begin hiding their state in preparation for some refactorings anyway, so let's internalize the user_pause mechanism instead of leaving it to callers to correctly manage.

Re: [Qemu-block] [PATCH v2 03/11] Blockjobs: Internalize user_pause logic

2016-10-03 Thread Jeff Cody
On Fri, Sep 30, 2016 at 06:00:41PM -0400, John Snow wrote: > BlockJobs will begin hiding their state in preparation for some > refactorings anyway, so let's internalize the user_pause mechanism > instead of leaving it to callers to correctly manage. > > Signed-off-by: John Snow

Re: [Qemu-block] [PATCH v4 05/12] block/nbd: Add nbd_has_filename_options_conflict()

2016-10-03 Thread Eric Blake
On 09/28/2016 03:55 PM, Max Reitz wrote: > Right now, we have four possible options that conflict with specifying > an NBD filename, and a future patch will add another one ("address"). > This future option is a nested QDict that is flattened at this point, > requiring us to test each option

Re: [Qemu-block] backup notifier fail policy

2016-10-03 Thread John Snow
On 10/03/2016 09:11 AM, Stefan Hajnoczi wrote: On Fri, Sep 30, 2016 at 09:59:16PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 30.09.2016 20:11, Vladimir Sementsov-Ogievskiy wrote: Hi all! Please, can somebody explain me, why we fail guest request in case of io error in write notifier? I

Re: [Qemu-block] [PATCH v4 04/12] block/nbd: Use qdict_put()

2016-10-03 Thread Eric Blake
On 09/28/2016 03:55 PM, Max Reitz wrote: > Instead of inlining this nice macro (i.e. resorting to > qdict_put_obj(..., QOBJECT(...))), use it. > > Signed-off-by: Max Reitz > --- > block/nbd.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) >

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options

2016-10-03 Thread Eric Blake
On 10/02/2016 02:13 PM, Tomáš Golembiovský wrote: > Added two new options 'offset' and 'size'. This makes it possible to use > only part of the file as a device. This can be used e.g. to limit the > access only to single partition in a disk image or use a disk inside a > tar archive (like OVA). >

Re: [Qemu-block] backup notifier fail policy

2016-10-03 Thread Stefan Hajnoczi
On Fri, Sep 30, 2016 at 09:59:16PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 30.09.2016 20:11, Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > > > Please, can somebody explain me, why we fail guest request in case of io > > error in write notifier? I think guest consistency is more

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options

2016-10-03 Thread Paolo Bonzini
On 03/10/2016 12:47, Tomáš Golembiovský wrote: > On Mon, 3 Oct 2016 11:20:44 +0200 > Paolo Bonzini wrote: > >> On 03/10/2016 10:52, Daniel P. Berrange wrote: >>> On Sun, Oct 02, 2016 at 09:13:29PM +0200, Tomáš Golembiovský wrote: Added two new options 'offset' and

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options

2016-10-03 Thread Daniel P. Berrange
On Mon, Oct 03, 2016 at 01:07:07PM +0200, Tomáš Golembiovský wrote: > On Mon, 3 Oct 2016 11:52:59 +0100 > > > > > > > + > > > > > +if (((bs->drv != _file) || !bs->read_only) && > > > > > > > > Why the check against bdrv_file ? > > > > > > To limit it only to files. Maybe there is

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options

2016-10-03 Thread Tomáš Golembiovský
On Mon, 3 Oct 2016 11:52:59 +0100 "Daniel P. Berrange" wrote: > On Mon, Oct 03, 2016 at 12:45:57PM +0200, Tomáš Golembiovský wrote: > > On Mon, 3 Oct 2016 09:52:13 +0100 > > "Daniel P. Berrange" wrote: > > > > > On Sun, Oct 02, 2016 at 09:13:29PM

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options

2016-10-03 Thread Daniel P. Berrange
On Mon, Oct 03, 2016 at 12:45:57PM +0200, Tomáš Golembiovský wrote: > On Mon, 3 Oct 2016 09:52:13 +0100 > "Daniel P. Berrange" wrote: > > > On Sun, Oct 02, 2016 at 09:13:29PM +0200, Tomáš Golembiovský wrote: > > > Added two new options 'offset' and 'size'. This makes it

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options

2016-10-03 Thread Tomáš Golembiovský
On Mon, 3 Oct 2016 11:20:44 +0200 Paolo Bonzini wrote: > On 03/10/2016 10:52, Daniel P. Berrange wrote: > > On Sun, Oct 02, 2016 at 09:13:29PM +0200, Tomáš Golembiovský wrote: > >> Added two new options 'offset' and 'size'. This makes it possible to use > >> only part of

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options

2016-10-03 Thread Tomáš Golembiovský
On Mon, 3 Oct 2016 09:52:13 +0100 "Daniel P. Berrange" wrote: > On Sun, Oct 02, 2016 at 09:13:29PM +0200, Tomáš Golembiovský wrote: > > Added two new options 'offset' and 'size'. This makes it possible to use > > only part of the file as a device. This can be used e.g. to

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options

2016-10-03 Thread Paolo Bonzini
On 03/10/2016 10:52, Daniel P. Berrange wrote: > On Sun, Oct 02, 2016 at 09:13:29PM +0200, Tomáš Golembiovský wrote: >> Added two new options 'offset' and 'size'. This makes it possible to use >> only part of the file as a device. This can be used e.g. to limit the >> access only to single

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options

2016-10-03 Thread Daniel P. Berrange
On Sun, Oct 02, 2016 at 09:13:29PM +0200, Tomáš Golembiovský wrote: > Added two new options 'offset' and 'size'. This makes it possible to use > only part of the file as a device. This can be used e.g. to limit the > access only to single partition in a disk image or use a disk inside a > tar