[Qemu-block] [PATCH] block: failed qemu-img command should return non-zero exit code

2016-10-09 Thread Xu Tian
If backing file can not open when do qemu-img rebase, var 'ret' not assign a no-zero value, qemu-img process go out with exit code zero. Signed-off-by: Xu Tian --- qemu-img.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-img.c b/qemu-img.c index 46f2a6d..37dcade 100644 --- a/qemu-im

Re: [Qemu-block] [PATCH] block: failed qemu-img command should return non-zero exit code

2016-10-09 Thread Reda Sallahi
On Sun, Oct 09, 2016 at 05:17:27PM +0800, Xu Tian wrote: > If backing file can not open when do qemu-img rebase, var 'ret' not > assign a no-zero value, qemu-img process go out with exit code zero. > > Signed-off-by: Xu Tian > --- > qemu-img.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff

[Qemu-block] [PATCH 2/2] macio: switch over to new byte-aligned DMA helpers

2016-10-09 Thread Mark Cave-Ayland
Now that the DMA helpers are byte-aligned they can be called directly from the macio routines rather than emulating byte-aligned accesses via multiple block-level accesses. Signed-off-by: Mark Cave-Ayland --- hw/ide/macio.c | 213 1 file

[Qemu-block] [PATCH 1/2] dma-helpers: explicitly pass alignment into dma-helpers

2016-10-09 Thread Mark Cave-Ayland
The hard-coded default alignment is BDRV_SECTOR_SIZE, however this is not necessarily the case for all platforms. Use this as the default alignment for all current callers. Signed-off-by: Mark Cave-Ayland --- dma-helpers.c| 20 +++- hw/block/nvme.c |6 -- h

[Qemu-block] [PATCH 0/2] dma-helpers: explicitly pass alignment into dma-helpers

2016-10-09 Thread Mark Cave-Ayland
This is a follow-up to the thread at https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg01396.html which introduces an explicit alignment to the DMA helpers to facilitate conversion of the macio controller over to use the now byte-aligned DMA helpers. Patch 1 introduces an alignment paramete

[Qemu-block] [PATCH] iotests: drop thread spun work-around

2016-10-09 Thread Michael S. Tsirkin
We've disabled the warning, no need for test to work around it. Signed-off-by: Michael S. Tsirkin --- tests/qemu-iotests/common.filter | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index cfdb633..49217b0 100644 --- a/tests/

[Qemu-block] [PULL 22/33] virtio-blk: convert VMSTATE_VIRTIO_DEVICE

2016-10-09 Thread Michael S. Tsirkin
From: Halil Pasic Use the new VMSTATE_VIRTIO_DEVICE macro. Signed-off-by: Halil Pasic Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/block/virtio-blk.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/hw/block/virtio-

[Qemu-block] [PULL 14/33] virtio-blk: handle virtio_blk_handle_request() errors

2016-10-09 Thread Michael S. Tsirkin
From: Greg Kurz All these errors are caused by a buggy guest: QEMU should not exit. With this patch, if virtio_blk_handle_request() detects a buggy request, it marks the device as broken and returns an error to the caller so it takes appropriate action. In the case of virtio_blk_handle_vq(), we

[Qemu-block] [PULL 09/33] virtio-blk: add missing virtio_detach_element() call

2016-10-09 Thread Michael S. Tsirkin
From: Stefan Hajnoczi Make sure to unmap the scatter-gather list and decrement vq->inuse before freeing requests in virtio_blk_reset(). Signed-off-by: Stefan Hajnoczi Reviewed-by: Ladi Prosek Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/block/virtio-blk.c | 1 +

[Qemu-block] [PULL 12/33] virtio-blk: make some functions static

2016-10-09 Thread Michael S. Tsirkin
From: Greg Kurz Some functions that were called from the dataplane code are now only used locally: virtio_blk_init_request() virtio_blk_handle_request() virtio_blk_submit_multireq() since commit "03de2f527499 virtio-blk: do not use vring in dataplane", and virtio_blk_free_request() since comm

[Qemu-block] [PULL 32/33] virtio: cleanup VMSTATE_VIRTIO_DEVICE

2016-10-09 Thread Michael S. Tsirkin
From: Halil Pasic Now all the usages of the old version of VMSTATE_VIRTIO_DEVICE are gone, so we can get rid of the conditionals, and the old macro. Signed-off-by: Halil Pasic Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 27 -

[Qemu-block] [Qemu-devel][PATCH] qemu-img: fix failed qemu-img command return zero exit code defeat

2016-10-09 Thread Xu Tian
If backing file can not open when do image rebase, flag 'ret' not assign a non-zero value, then qemu-img process exit with code zero. Assign value '-1' to flag 'ret' after report error message to fix this defeat. BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1383012 Signed-off-by: Xu Tian ---

[Qemu-block] block/nfs: Fine grained runtime options in nfs

2016-10-09 Thread Ashijeet Acharya
Hi all, I was working on trying to add blockdev-add compatibility for the nfs block driver but before that runtime options need to be separated into various options rather than just a simple "filename" option. I have added the following until now: a) host b) port (not sure about this one, do we j