The guest sends discard requests as u64 sector/count pairs, but the
block layer operates internally with s64/s32 pairs. The conversion
leads to IO errors in the guest, the discard request is not processed.
domU.cfg:
'vdev=xvda, format=qcow2, backendtype=qdisk, target=/x.qcow2'
domU:
mkfs.e
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v2] xen_disk: split discard input to match
internal representation
Type: series
Message-id: 20161123094914.15675-1-o...@aepfle.de
=== TEST SCRIPT BEGIN ===
#!/bin/bash
The guest sends discard requests as u64 sector/count pairs, but the
block layer operates internally with s64/s32 pairs. The conversion
leads to IO errors in the guest, the discard request is not processed.
domU.cfg:
'vdev=xvda, format=qcow2, backendtype=qdisk, target=/x.qcow2'
domU:
mkfs.e
On Wed, Nov 23, Olaf Hering wrote:
> > > +if (!blk_split_discard(ioreq, req->sector_number,
> > > req->nr_sectors)) {
> > > +goto err;
> > How is error handling supposed to work here?
In the guest the cmd is stuck, instead of getting an IO error:
[ 91.966404] mkfs.ext4
Ping.
On Fri, Nov 18, Olaf Hering wrote:
> On Fri, Nov 18, Olaf Hering wrote:
>
> > @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq)
> > +if (!blk_split_discard(ioreq, req->sector_number,
> > req->nr_sectors)) {
> > +goto err;
>
> How is error hand
On 11/23/2016 04:39 AM, Olaf Hering wrote:
> The guest sends discard requests as u64 sector/count pairs, but the
> block layer operates internally with s64/s32 pairs. The conversion
> leads to IO errors in the guest, the discard request is not processed.
>
> domU.cfg:
> 'vdev=xvda, format=qcow
On Tue, 22 Nov 2016 16:02:12 +0100
Pradeep Kiruvale wrote:
> On 22 November 2016 at 14:55, Greg Kurz wrote:
>
> > On Tue, 22 Nov 2016 14:51:12 +0100
> > Alberto Garcia wrote:
> >
> > > On Tue 22 Nov 2016 01:49:51 PM CET, Greg Kurz wrote:
> > >
> > > > This will allow other subsystems (i.e. fsd
On 23 November 2016 at 13:13, Greg Kurz wrote:
> On Tue, 22 Nov 2016 16:02:12 +0100
> Pradeep Kiruvale wrote:
>
> > On 22 November 2016 at 14:55, Greg Kurz wrote:
> >
> > > On Tue, 22 Nov 2016 14:51:12 +0100
> > > Alberto Garcia wrote:
> > >
> > > > On Tue 22 Nov 2016 01:49:51 PM CET, Greg Kur
Am 23.11.2016 um 12:40 hat Eric Blake geschrieben:
> On 11/23/2016 04:39 AM, Olaf Hering wrote:
> > The guest sends discard requests as u64 sector/count pairs, but the
> > block layer operates internally with s64/s32 pairs. The conversion
> > leads to IO errors in the guest, the discard request is
Am 15.11.2016 um 07:36 hat Pavel Butsykin geschrieben:
> It's just byte-based wrappers over bdrv_co_aio_prw_vector(), which provide
> a byte-based interface for AIO read/write.
>
> Signed-off-by: Pavel Butsykin
I'm in the process to phase out the last users of bdrv_aio_*() so that
this set of i
Am 15.11.2016 um 07:36 hat Pavel Butsykin geschrieben:
> The basic version of pcache driver for easy preparation of a patch set.
>
> Signed-off-by: Pavel Butsykin
> ---
> block/Makefile.objs | 1 +
> block/pcache.c | 144
>
> 2 files c
On Wed, Nov 23, 2016 at 10:39:12AM +, Olaf Hering wrote:
> The guest sends discard requests as u64 sector/count pairs, but the
> block layer operates internally with s64/s32 pairs. The conversion
> leads to IO errors in the guest, the discard request is not processed.
>
> domU.cfg:
> 'vdev
On Wed, 23 Nov 2016, Kevin Wolf wrote:
> Am 23.11.2016 um 12:40 hat Eric Blake geschrieben:
> > On 11/23/2016 04:39 AM, Olaf Hering wrote:
> > > The guest sends discard requests as u64 sector/count pairs, but the
> > > block layer operates internally with s64/s32 pairs. The conversion
> > > leads t
On Wed, 23 Nov 2016, Olaf Hering wrote:
> The guest sends discard requests as u64 sector/count pairs, but the
> block layer operates internally with s64/s32 pairs. The conversion
> leads to IO errors in the guest, the discard request is not processed.
>
> domU.cfg:
> 'vdev=xvda, format=qcow2,
On Wed, 23 Nov 2016, Olaf Hering wrote:
> On Wed, Nov 23, Olaf Hering wrote:
>
> > > > +if (!blk_split_discard(ioreq, req->sector_number,
> > > > req->nr_sectors)) {
> > > > +goto err;
> > > How is error handling supposed to work here?
>
> In the guest the cmd is stuck, inste
Am 23. November 2016 13:27:13 MEZ, schrieb Kevin Wolf :
>Am 23.11.2016 um 12:40 hat Eric Blake geschrieben:
>> Qualifies as a bug fix, so requesting 2.8 inclusion.
>> Reviewed-by: Eric Blake
Is this a can for 2.x?
Olaf
Am 15.11.2016 um 07:37 hat Pavel Butsykin geschrieben:
> RBCache provides functionality to cache the data from block devices
> (basically). The range here is used as the main key for searching and storing
> data. The cache is based on red-black trees, so basic operations search,
> insert, delete ar
Am 23. November 2016 21:44:50 MEZ, schrieb Olaf Hering :
>Is this a can for 2.x?
candidate
Olaf
18 matches
Mail list logo