Re: [Qemu-block] [PATCH 00/14] block: Image locking series

On 31.10.2016 16:38, Fam Zheng wrote: > This is v9 of the image locking series. I redid the whole series, adopting the > "two locks" approach from Kevin and Max. > > Depends on "[Qemu-devel] [PATCH] raw-posix: Rename 'raw_s' to 'rs'" in Max's > block branch. > > Fam Zheng (14): > osdep: Add

Re: [Qemu-block] [PATCH 05/14] block: Set "share-rw" flag in drive-backup when sync=none

On 31.10.2016 16:38, Fam Zheng wrote: > In this case we may open the source's backing image chain multiple > times. Setting share flag means the new open won't try to acquire or > check any lock, once we implement image locking. > > Signed-off-by: Fam Zheng > > --- > > An

Re: [Qemu-block] [PATCH 04/14] qemu-img: Set "share-rw" flag in read-only commands

On 31.10.2016 16:38, Fam Zheng wrote: > Checking the status of an image when it is being used by guest is > usually useful, True for qemu-img info and maybe even qemu-img compare (and qemu-img map is just a debugging tool, so that's fine, too), but I don't think qemu-img check is very useful.

Re: [Qemu-block] [PATCH 01/14] osdep: Add qemu_lock_fd and qemu_unlock_fd

On 31.10.2016 16:38, Fam Zheng wrote: > They are wrappers of POSIX fcntl "file private locking". > > Signed-off-by: Fam Zheng > --- > include/qemu/osdep.h | 2 ++ > util/osdep.c | 29 + > 2 files changed, 31 insertions(+) > > diff --git

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: Improve commit invalid base message

On 01.12.2016 03:36, Eric Blake wrote: > On 11/30/2016 08:05 PM, Max Reitz wrote: >> When trying to invoke qemu-img commit with a base image file name that >> is not part of the top image's backing chain, the user receives a rather >> plain "Base not found" error message. This is not really

Re: [Qemu-block] [PATCH 06/10] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock

On 30/11/2016 14:36, Paolo Bonzini wrote: > > > On 30/11/2016 14:31, Stefan Hajnoczi wrote: >> On Tue, Nov 29, 2016 at 12:47:03PM +0100, Paolo Bonzini wrote: >>> @@ -272,22 +275,32 @@ bool aio_prepare(AioContext *ctx) >>> bool aio_pending(AioContext *ctx) >>> { >>> AioHandler *node; >>>

Re: [Qemu-block] [PATCH 1/3] timer: fix misleading comment in timer.h

On 01/12/2016 14:50, Stefan Hajnoczi wrote: > On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote: >> It's timer to expire, not clock. >> >> Signed-off-by: Yaowei Bai >> --- >> include/qemu/timer.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-block] [RFC PATCH] glusterfs: allow partial reads

Fixes #1644754. Signed-off-by: Wolfgang Bumiller --- I'm not sure what the original rationale was to treat both partial reads as well as well as writes as I/O error. (Seems to have happened from original glusterfs v1 to v2 series with a note but no reasoning for the read

Re: [Qemu-block] [Qemu-devel] [PATCH] migration: re-active images when migration fails to complete

Forwarding to qemu-block so I won't forget to have a look. Am 19.11.2016 um 12:43 hat zhanghailiang geschrieben: > commit fe904ea8242cbae2d7e69c052c754b8f5f1ba1d6 fixed a case > which migration aborted QEMU because it didn't regain the control > of images while some errors happened. > >

Re: [Qemu-block] [PATCH 1/3] timer: fix misleading comment in timer.h

On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote: > It's timer to expire, not clock. > > Signed-off-by: Yaowei Bai > --- > include/qemu/timer.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) For the whole series: Reviewed-by: Stefan Hajnoczi

Re: [Qemu-block] QEMU 1.1.2: block IO throttle might occasionally freeze running process's IO to zero

On 01/12/2016 05:07, Bob Chen wrote: > Test case: > > 1. QEMU 1.1.2 > 2. Run fio inside the vm, give it some pressure. Watch the realtime > throughput > 3. block_set_io_throttle drive_2 1 0 0 2000 0 0 # > throttle bps and iops, any value > 4. Observed that the IO is very likely

Re: [Qemu-block] [Qemu-devel] QEMU 1.1.2: block IO throttle might occasionally freeze running process's IO to zero

On Thu, 12/01 12:07, Bob Chen wrote: > Test case: > > 1. QEMU 1.1.2 > 2. Run fio inside the vm, give it some pressure. Watch the realtime > throughput > 3. block_set_io_throttle drive_2 1 0 0 2000 0 0 # throttle > bps and iops, any value > 4. Observed that the IO is very likely to