Re: [Qemu-block] [PATCH 2/3] xen-disk: add support for multi-page shared rings

2017-06-20 Thread Stefano Stabellini
On Tue, 20 Jun 2017, Paul Durrant wrote: > The blkif protocol has had provision for negotiation of multi-page shared > rings for some time now and many guest OS have support in their frontend > drivers. > > This patch makes the necessary modifications to xen-disk support a shared > ring up to orde

Re: [Qemu-block] [PATCH 1/3] xen-disk: only advertize feature-persistent if grant copy is not available

2017-06-20 Thread Stefano Stabellini
On Tue, 20 Jun 2017, Paul Durrant wrote: > If grant copy is available then it will always be used in preference to > persistent maps. In this case feature-persistent should not be advertized > to the frontend, otherwise it may needlessly copy data into persistently > granted buffers. > > Signed-of

Re: [Qemu-block] [PATCH 3/3] xen-disk: use an IOThread per instance

2017-06-20 Thread Paul Durrant
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: 20 June 2017 17:08 > To: Paul Durrant ; xen-de...@lists.xenproject.org; > qemu-de...@nongnu.org; qemu-block@nongnu.org > Cc: Anthony Perard ; Kevin Wolf > ; Stefano Stabellini ;

Re: [Qemu-block] [PATCH 3/3] xen-disk: use an IOThread per instance

2017-06-20 Thread Paolo Bonzini
On 20/06/2017 15:47, Paul Durrant wrote: > This patch allocates an IOThread object for each xen_disk instance and > sets the AIO context appropriately on connect. This allows processing > of I/O to proceed in parallel. > > The patch also adds tracepoints into xen_disk to make it possible to > foll

Re: [Qemu-block] [PATCH] qcow2: Use offset_into_cluster() and offset_to_l2_index()

2017-06-20 Thread Kevin Wolf
Am 20.06.2017 um 15:01 hat Alberto Garcia geschrieben: > We already have functions for doing these calculations, so let's use > them instead of doing everything by hand. This makes the code a bit > more readable. > > Signed-off-by: Alberto Garcia Thanks, applied to the block branch. Kevin

Re: [Qemu-block] [PATCH v4 0/7] Reduce the number of I/O ops when doing COW

2017-06-20 Thread Kevin Wolf
Am 19.06.2017 um 15:40 hat Alberto Garcia geschrieben: > Hi all, > > here's a patch series that rewrites the copy-on-write code in the > qcow2 driver to reduce the number of I/O operations. > > This is version v4, please refer to the original e-mail for a complete > description: > > https://list

Re: [Qemu-block] [PATCH v9 07/20] block: deprecate "encryption=on" in favor of "encrypt.format=aes"

2017-06-20 Thread Alberto Garcia
On Tue 20 Jun 2017 02:02:06 PM CEST, Daniel P. Berrange wrote: >> > +if (encryptfmt) { >> > +buf = qemu_opt_get_del(opts, BLOCK_OPT_ENCRYPT); >> > +if (buf != NULL) { >> > +g_free(buf); >> >> If you use qemu_opt_get() instead then you don't need "buf" at all, >> do

[Qemu-block] [PATCH 1/3] xen-disk: only advertize feature-persistent if grant copy is not available

2017-06-20 Thread Paul Durrant
If grant copy is available then it will always be used in preference to persistent maps. In this case feature-persistent should not be advertized to the frontend, otherwise it may needlessly copy data into persistently granted buffers. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: A

[Qemu-block] [PATCH 0/3] xen-disk: performance improvements

2017-06-20 Thread Paul Durrant
Paul Durrant (3): xen-disk: only advertize feature-persistent if grant copy is not available xen-disk: add support for multi-page shared rings xen-disk: use an IOThread per instance hw/block/trace-events | 7 ++ hw/block/xen_disk.c | 200 -

[Qemu-block] [PATCH 2/3] xen-disk: add support for multi-page shared rings

2017-06-20 Thread Paul Durrant
The blkif protocol has had provision for negotiation of multi-page shared rings for some time now and many guest OS have support in their frontend drivers. This patch makes the necessary modifications to xen-disk support a shared ring up to order 4 (i.e. 16 pages). Signed-off-by: Paul Durrant --

[Qemu-block] [PATCH 3/3] xen-disk: use an IOThread per instance

2017-06-20 Thread Paul Durrant
This patch allocates an IOThread object for each xen_disk instance and sets the AIO context appropriately on connect. This allows processing of I/O to proceed in parallel. The patch also adds tracepoints into xen_disk to make it possible to follow the state transtions of an instance in the log. S

[Qemu-block] [PATCH] qcow2: Use offset_into_cluster() and offset_to_l2_index()

2017-06-20 Thread Alberto Garcia
We already have functions for doing these calculations, so let's use them instead of doing everything by hand. This makes the code a bit more readable. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 4 ++-- block/qcow2.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

Re: [Qemu-block] [PATCH v9 07/20] block: deprecate "encryption=on" in favor of "encrypt.format=aes"

2017-06-20 Thread Daniel P. Berrange
On Tue, Jun 20, 2017 at 01:44:50PM +0200, Alberto Garcia wrote: > On Mon 19 Jun 2017 07:34:42 PM CEST, Daniel P. Berrange wrote: > > Historically the qcow & qcow2 image formats supported a property > > "encryption=on" to enable their built-in AES encryption. We'll > > soon be supporting LUKS for qc

Re: [Qemu-block] [PATCH v9 07/20] block: deprecate "encryption=on" in favor of "encrypt.format=aes"

2017-06-20 Thread Alberto Garcia
On Mon 19 Jun 2017 07:34:42 PM CEST, Daniel P. Berrange wrote: > Historically the qcow & qcow2 image formats supported a property > "encryption=on" to enable their built-in AES encryption. We'll > soon be supporting LUKS for qcow2, so need a more general purpose > way to enable encryption, with a c

Re: [Qemu-block] [PULL 0/2] Block patches

2017-06-20 Thread Peter Maydell
On 14 June 2017 at 22:55, Jeff Cody wrote: > The following changes since commit 3f0602927b120a480b35dcf58cf6f95435b3ae91: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20170613' into staging (2017-06-13 > 15:49:07 +0100) > > are available in the git repository at: >

Re: [Qemu-block] [PATCH] nvme: Add support for Read Data and Write Data in CMBs.

2017-06-20 Thread Kevin Wolf
Am 19.06.2017 um 23:24 hat Keith Busch geschrieben: > On Tue, Jun 13, 2017 at 04:08:35AM -0600, sba...@raithlin.com wrote: > > From: Stephen Bates > > > > Add the ability for the NVMe model to support both the RDS and WDS > > modes in the Controller Memory Buffer. > > > > Although not currently