With the move of some docs to docs/interop on d59157ea05, a reference path
was not updated.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Kevin Wolf
---
docs/qcow2-cache.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
inde
On Fri, 28 Jul 2017, Olaf Hering wrote:
> g_malloc0_n is available since glib-2.24. To allow build with older glib
> versions use the generic g_new0, which is already used in many other
> places in the code.
>
> Fixes commit 3284fad728 ("xen-disk: add support for multi-page shared rings")
>
> Sig
On Fri, 28 Jul 2017, Philippe Mathieu-Daudé wrote:
> Hi Olaf,
>
> On 07/28/2017 10:11 AM, Olaf Hering wrote:
> > g_malloc0_n is available since glib-2.24. To allow build with older glib
> > versions use the generic g_new0, which is already used in many other
> > places in the code.
>
> Can you pr
On Fri, Jul 28, 2017 at 03:14:52PM +0200, Kevin Wolf wrote:
> qemu-iotests 059 left a whole lot of image files behind in the scratch
> directory because VMDK creates additional files for extents and cleaning
> them up requires the original image intact (it parses qemu-img info
> output to find all
On Fri, Jul 28, 2017 at 03:14:46PM +0200, Kevin Wolf wrote:
> qemu-iotests 041 left quorum_snapshot.img and target.img behind in the
> scratch directory. Make sure to clean up after completing the tests.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/041 | 4 +++-
> 1 file changed, 3 i
On Fri, Jul 28, 2017 at 03:14:51PM +0200, Kevin Wolf wrote:
> qemu-iotests 063 left t.raw.raw1 behind in the scratch directory because
> it used the wrong suffix. Make sure to clean it up after completing the
> test.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/063 | 4 +---
> 1 file
On Fri, Jul 28, 2017 at 03:14:50PM +0200, Kevin Wolf wrote:
> qemu-iotests 162 left qemu-nbd.pid behind in the scratch directory, and
> potentially a file called '42' in the current directory. Make sure to
> clean it up after completing the tests.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu
On Fri, Jul 28, 2017 at 03:14:48PM +0200, Kevin Wolf wrote:
> qemu-iotests 141 attempted to use brace expansion to remove all images
> with a single command. However, for this to work, the braces shouldn't
> be quoted.
>
> With this fix, the tests correctly cleans up its scratch images.
>
> Signe
On 28 July 2017 at 21:49, Philippe Mathieu-Daudé wrote:
> Hi Olaf,
>
> On 07/28/2017 10:11 AM, Olaf Hering wrote:
>>
>> g_malloc0_n is available since glib-2.24. To allow build with older glib
>> versions use the generic g_new0, which is already used in many other
>> places in the code.
>
>
> Can
Hi Olaf,
On 07/28/2017 10:11 AM, Olaf Hering wrote:
g_malloc0_n is available since glib-2.24. To allow build with older glib
versions use the generic g_new0, which is already used in many other
places in the code.
Can you provide information about which
distrib/release/version/[packages?] you
On 07/28/2017 02:16 AM, Fam Zheng wrote:
On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 23de632424..54e35fdab9 100644
--- a/MAIN
On 07/28/2017 08:14 AM, Kevin Wolf wrote:
> This fixes leaked temporary files that are created during successful
> runs of qemu-iotests for qcow2, raw and vmdk. More file leaks exist for
> failing or interrupted tests, but this is something for another day.
>
> Kevin Wolf (7):
> qemu-iotests/041
On 07/28/2017 08:14 AM, Kevin Wolf wrote:
> qemu-iotests 059 left a whole lot of image files behind in the scratch
> directory because VMDK creates additional files for extents and cleaning
> them up requires the original image intact (it parses qemu-img info
> output to find all extent files), but
On 07/28/2017 08:14 AM, Kevin Wolf wrote:
> qemu-iotests 041 left quorum_snapshot.img and target.img behind in the
> scratch directory. Make sure to clean up after completing the tests.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/041 | 4 +++-
> 1 file changed, 3 insertions(+), 1 de
On 07/28/2017 08:14 AM, Kevin Wolf wrote:
> qemu-iotests 074 and 179 left a blkdebug.conf behind the scratch
s/behind/behind in/
> directory. Make sure to clean up after completing the tests.
>
> Signed-off-by: Kevin Wolf
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
On 07/28/2017 08:11 AM, Olaf Hering wrote:
> g_malloc0_n is available since glib-2.24. To allow build with older glib
s/is/is only/
> versions use the generic g_new0, which is already used in many other
> places in the code.
>
> Fixes commit 3284fad728 ("xen-disk: add support for multi-page shar
On 24 July 2017 at 15:32, Kevin Wolf wrote:
> Commits 0db832f and 6cdbceb introduced the automatic insertion of filter
> nodes above the top layer of mirror and commit block jobs. The
> assumption made there was that since libvirt doesn't do node-level
> management of the block layer yet, it shoul
On 07/28/2017 01:53 PM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> Now that we have the qmp_cmd() helper, we can further simplify
>> some of the tests by using it.
>>
>> Signed-off-by: Eric Blake
>> ---
>> }
>> -resp = qmp("{'execute': 'qom-list-types',"
>> - " 'a
Eric Blake writes:
> Now that we have the qmp_cmd() helper, we can further simplify
> some of the tests by using it.
>
> Signed-off-by: Eric Blake
> ---
> tests/device-introspect-test.c | 3 +--
> tests/ide-test.c | 2 +-
> tests/libqos/libqos.c | 5 +++--
> tests/libq
On 07/27/2017 08:25 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
The commit message in 1/8 was a lot nicer, in referring to which commit
broke the linkage.
(When backporting patches, a very common thing to do is 'git log' and
then grep for the commit id being backpor
On Fri, Jul 28, 2017 at 6:58 PM Paolo Bonzini wrote:
> On 28/07/2017 18:30, Marc-André Lureau wrote:
> > The function does the same initialization, and matches with
> > scsi_free_scsi_task() usage, and qemu doesn't need to know the
> > allocator details.
> >
> > Signed-off-by: Marc-André Lureau
Stefan Hajnoczi writes:
> On Tue, Jul 25, 2017 at 04:15:20PM -0500, Eric Blake wrote:
>> @@ -419,19 +420,18 @@ static void test_ivshmem_server_irq(void)
>> static void test_ivshmem_hotplug(void)
>> {
>> const char *arch = qtest_get_arch();
>> -gchar *opts;
>> +QObject *extra_args =
From: Philippe Mathieu-Daudé
nbd/client.c:385:12: warning: Potential leak of memory pointed to by 'buf'
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Eric Blake
Message-Id: <20170727024224.22900-5-f4...@amsat.org>
[introduced in commit 8ecaeae8]
Signed-o
On 28/07/2017 18:30, Marc-André Lureau wrote:
> The function does the same initialization, and matches with
> scsi_free_scsi_task() usage, and qemu doesn't need to know the
> allocator details.
>
> Signed-off-by: Marc-André Lureau
> ---
> block/iscsi.c | 30 +++---
> 1 fi
These days, many programs are including a bug-reporting address,
or better yet, a link to the project web site, at the tail of
their --help output. However, we were not very consistent at
doing so: only qemu-nbd and qemu-qa mentioned anything, with the
latter pointing to an individual person inste
Merge two previous postings. I'm not sure what tree this should
go through (Paolo's miscellaneous patches?)
Eric Blake (4):
qemu-img: Sort sub-command names in --help
qemu-io: Give more --version information
qga: Give more --version information
maint: Include bug-reporting info in --help o
Include the package version information (useful for detecting
builds from git or downstream backports), and the copyright notice.
Signed-off-by: Eric Blake
---
qemu-io.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qemu-io.c b/qemu-io.c
index 4cfa41c8f9..ec175630a6 1006
'amend' was the only sub-command not listed alphabetically; hoist
it earlier, and separate the @end table block to make it easier
to copy-and-paste the addition of future sub-commands.
Signed-off-by: Eric Blake
---
qemu-img-cmds.hx | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
Include the package version information (useful for detecting
builds from git or downstream backports), and the copyright notice.
Signed-off-by: Eric Blake
---
qga/main.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 1b381d0bf3..b64c7ac2a
On 07/28/2017 11:35 AM, Eric Blake wrote:
>>> +QObject *extra_args = qobject_from_jsonf("{ 'shm': '%s', 'size': '1M'
>>> }",
>>> + tmpshm);
>>
> Passing '%s' through qobject_from_jsonf() is generally wrong (it would
> produce ''...'' instead of the
Olaf Hering writes:
> On Fri, Jul 28, Eric Blake wrote:
>
>> This version is prone to multiplication overflow (well, maybe not, but
>> you have to audit for that). Wouldn't it be better to use:
>
> What could go wrong?
> qemu will die either way, I think.
An overflow in the size argument of mal
On 07/28/2017 08:05 AM, Stefan Hajnoczi wrote:
> On Tue, Jul 25, 2017 at 04:15:20PM -0500, Eric Blake wrote:
>> @@ -419,19 +420,18 @@ static void test_ivshmem_server_irq(void)
>> static void test_ivshmem_hotplug(void)
>> {
>> const char *arch = qtest_get_arch();
>> -gchar *opts;
>> +
The function does the same initialization, and matches with
scsi_free_scsi_task() usage, and qemu doesn't need to know the
allocator details.
Signed-off-by: Marc-André Lureau
---
block/iscsi.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
v2:
- set cdb_
Am 14.07.2017 um 16:35 hat Manos Pitsidianakis geschrieben:
> v3:
> new commit: block: fix dangling bs->explicit_options in block.c
> rework error paths in bdrv_open_driver()
> v2:
> move bdrv_unref_child(bs, bs->file) to bdrv_open_driver
> do not set bs->drv to NULL if open succeeds
Thanks, a
On Fri, Jul 28, 2017 at 03:14:49PM +0200, Kevin Wolf wrote:
> qemu-iotests 153 left t.qcow2.c behind in the scratch directory. Make
> sure to clean it up after completing the tests.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/153 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --g
On Fri, Jul 28, 2017 at 03:14:47PM +0200, Kevin Wolf wrote:
> qemu-iotests 074 and 179 left a blkdebug.conf behind the scratch
> directory. Make sure to clean up after completing the tests.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/074 | 1 +
> tests/qemu-iotests/179 | 1 +
> 2 fi
Am 13.07.2017 um 17:30 hat Manos Pitsidianakis geschrieben:
> This series makes implementing some of the bdrv_* callbacks easier for block
> filters by passing requests to bs->file if bs->drv doesn't implement it
> instead
> of failing, and adding default bdrv_co_get_block_status() implementations
qemu-iotests 059 left a whole lot of image files behind in the scratch
directory because VMDK creates additional files for extents and cleaning
them up requires the original image intact (it parses qemu-img info
output to find all extent files), but the image overwrote it many times
like it works f
qemu-iotests 063 left t.raw.raw1 behind in the scratch directory because
it used the wrong suffix. Make sure to clean it up after completing the
test.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/063 | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/06
qemu-iotests 162 left qemu-nbd.pid behind in the scratch directory, and
potentially a file called '42' in the current directory. Make sure to
clean it up after completing the tests.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/162 | 7 +++
1 file changed, 7 insertions(+)
diff --git a/te
qemu-iotests 041 left quorum_snapshot.img and target.img behind in the
scratch directory. Make sure to clean up after completing the tests.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/041 | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/041 b/tests/q
This fixes leaked temporary files that are created during successful
runs of qemu-iotests for qcow2, raw and vmdk. More file leaks exist for
failing or interrupted tests, but this is something for another day.
Kevin Wolf (7):
qemu-iotests/041: Fix leaked scratch images
qemu-iotests: Remove blk
qemu-iotests 141 attempted to use brace expansion to remove all images
with a single command. However, for this to work, the braces shouldn't
be quoted.
With this fix, the tests correctly cleans up its scratch images.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/141 | 2 +-
1 file changed,
qemu-iotests 153 left t.qcow2.c behind in the scratch directory. Make
sure to clean it up after completing the tests.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/153 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153
index 0b45d78ea3..fa25eb2
qemu-iotests 074 and 179 left a blkdebug.conf behind the scratch
directory. Make sure to clean up after completing the tests.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/074 | 1 +
tests/qemu-iotests/179 | 1 +
2 files changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/074 b/tests/qe
g_malloc0_n is available since glib-2.24. To allow build with older glib
versions use the generic g_new0, which is already used in many other
places in the code.
Fixes commit 3284fad728 ("xen-disk: add support for multi-page shared rings")
Signed-off-by: Olaf Hering
---
hw/block/xen_disk.c | 2
On Tue, Jul 25, 2017 at 04:15:20PM -0500, Eric Blake wrote:
> @@ -419,19 +420,18 @@ static void test_ivshmem_server_irq(void)
> static void test_ivshmem_hotplug(void)
> {
> const char *arch = qtest_get_arch();
> -gchar *opts;
> +QObject *extra_args = qobject_from_jsonf("{ 'shm': '%s'
On 07/28/2017 07:48 AM, Olaf Hering wrote:
> On Fri, Jul 28, Eric Blake wrote:
>
>> This version is prone to multiplication overflow (well, maybe not, but
>> you have to audit for that). Wouldn't it be better to use:
>
> What could go wrong?
> qemu will die either way, I think.
Dying immediatel
On Tue, Jul 25, 2017 at 04:15:19PM -0500, Eric Blake wrote:
> Now that we have the qmp_cmd() helper, we can further simplify
> some of the tests by using it.
>
> Signed-off-by: Eric Blake
> ---
> tests/device-introspect-test.c | 3 +--
> tests/ide-test.c | 2 +-
> tests/libqos/li
Am 09.07.2017 um 19:06 hat Peter Maydell geschrieben:
> The function vmdk_read_cid() can fail if the read on the underlying
> block device fails, or if there's a format error in the VMDK file.
> However its API doesn't provide a mechanism to report these errors,
> and in some cases we were returnin
On Fri, Jul 28, 2017 at 07:43:59AM -0500, Eric Blake wrote:
> On 07/28/2017 07:31 AM, Olaf Hering wrote:
> > g_malloc0_n is available since glib-2.24. To allow build with older glib
> > versions use the generic g_malloc0, which is already used in many other
> > places in the code.
> >
> > Fixes co
On Fri, Jul 28, Eric Blake wrote:
> This version is prone to multiplication overflow (well, maybe not, but
> you have to audit for that). Wouldn't it be better to use:
What could go wrong?
qemu will die either way, I think.
Olaf
signature.asc
Description: PGP signature
On 07/28/2017 07:31 AM, Olaf Hering wrote:
> g_malloc0_n is available since glib-2.24. To allow build with older glib
> versions use the generic g_malloc0, which is already used in many other
> places in the code.
>
> Fixes commit 3284fad728 ("xen-disk: add support for multi-page shared rings")
>
g_malloc0_n is available since glib-2.24. To allow build with older glib
versions use the generic g_malloc0, which is already used in many other
places in the code.
Fixes commit 3284fad728 ("xen-disk: add support for multi-page shared rings")
Signed-off-by: Olaf Hering
---
hw/block/xen_disk.c |
On Fri, Jul 28, 2017 at 02:35:33AM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4f9ce6e686..2958dd2479 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @
Am 27.07.2017 um 12:07 hat Stefan Hajnoczi geschrieben:
> On Wed, Jul 26, 2017 at 09:23:20PM +0300, Manos Pitsidianakis wrote:
> > On Wed, Jul 26, 2017 at 04:12:21PM +0100, Stefan Hajnoczi wrote:
> > > On Wed, Jul 26, 2017 at 05:19:24PM +0300, Manos Pitsidianakis wrote:
> > > > This proposal follow
On Fri, Jul 28, 2017 at 02:35:42AM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On Fri, Jul 28, 2017 at 02:36:03AM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On 07/27/2017 04:23 PM, John Snow wrote:
>>>
>>> "Allocations may be considered either used or unused by the format
>>> driver interpreting those allocations. It is at the discretion of the
>>> format driver (e.g. qcow2) which regions of its backing storage are
>>> considered in-use or not."
>>
>>
Am 28.07.2017 um 00:09 hat John Snow geschrieben:
> On 07/26/2017 02:23 PM, Manos Pitsidianakis wrote:
> > On Wed, Jul 26, 2017 at 04:12:21PM +0100, Stefan Hajnoczi wrote:
> > > On Wed, Jul 26, 2017 at 05:19:24PM +0300, Manos Pitsidianakis wrote:
> > > > This proposal follows a discussion we had wi
Am 28.07.2017 um 07:35 hat Philippe Mathieu-Daudé geschrieben:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6b83dac812..2dcdda4cd5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1856,6
Am 28.07.2017 um 03:25 hat Philippe Mathieu-Daudé geschrieben:
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Kevin Wolf
On Thu, Jul 27, 2017 at 06:09:04PM -0400, John Snow wrote:
On 07/26/2017 02:23 PM, Manos Pitsidianakis wrote:
On Wed, Jul 26, 2017 at 04:12:21PM +0100, Stefan Hajnoczi wrote:
On Wed, Jul 26, 2017 at 05:19:24PM +0300, Manos Pitsidianakis wrote:
This proposal follows a discussion we had with Ke
28.07.2017 00:23, John Snow wrote:
On 07/12/2017 11:18 AM, Vladimir Sementsov-Ogievskiy wrote:
30.06.2017 03:27, John Snow wrote:
On 06/06/2017 12:26 PM, Vladimir Sementsov-Ogievskiy wrote:
The function should collect statistics, about used/unused by top-level
format driver space (in its .f
64 matches
Mail list logo
