Re: [Qemu-block] [PATCH v3 4/7] block: remove legacy I/O throttling

2017-09-08 Thread Manos Pitsidianakis
On Fri, Sep 08, 2017 at 06:00:11PM +0200, Kevin Wolf wrote: Am 08.09.2017 um 17:44 hat Manos Pitsidianakis geschrieben: On Thu, Sep 07, 2017 at 03:26:11PM +0200, Kevin Wolf wrote: > We shouldn't really need any throttling code in > blk_root_drained_begin/end any more now because the throttle nod

[Qemu-block] [PATCH v3 11/15] MAINTAINERS: add missing AIO entry

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4e05831bda..98b7edc8b3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1224,6 +1224,7 @@ F: util/aio-*.c F:

[Qemu-block] [PATCH v3 15/15] MAINTAINERS: update docs/interop/ entries

2017-09-08 Thread Philippe Mathieu-Daudé
moved in commit 7746cf8aab68 Signed-off-by: Philippe Mathieu-Daudé Acked-by: Fam Zheng Acked-by: John Snow --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f8630561de..99f3681842 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @

[Qemu-block] [PATCH v3 06/15] MAINTAINERS: add missing qcow2 entry

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fa1620d8a8..39ac5d132a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1851,6 +1851,7 @@ M: Max Reitz L: q

Re: [Qemu-block] [PATCH v2 12/17] MAINTAINERS: add missing megasas test entry

2017-09-08 Thread Philippe Mathieu-Daudé
Let's try another SUSE domain On 09/08/2017 02:12 PM, Philippe Mathieu-Daudé wrote: I wonder if "megasas" is still maintained, I got: To: Hannes Reinecke Final-Recipient: rfc822; h...@suse.de Action: failed Status: 5.1.1 Remote-MTA: dns; mx2.suse.de. (195.135.220.15, the server for the domain

Re: [Qemu-block] [PATCH v2 12/17] MAINTAINERS: add missing megasas test entry

2017-09-08 Thread Philippe Mathieu-Daudé
I wonder if "megasas" is still maintained, I got: To: Hannes Reinecke Final-Recipient: rfc822; h...@suse.de Action: failed Status: 5.1.1 Remote-MTA: dns; mx2.suse.de. (195.135.220.15, the server for the domain suse.de.) Diagnostic-Code: smtp; 550 5.1.1 : Recipient address rejected: User unknow

Re: [Qemu-block] [PATCH v3 4/7] block: remove legacy I/O throttling

2017-09-08 Thread Kevin Wolf
Am 08.09.2017 um 17:44 hat Manos Pitsidianakis geschrieben: > On Thu, Sep 07, 2017 at 03:26:11PM +0200, Kevin Wolf wrote: > > We shouldn't really need any throttling code in > > blk_root_drained_begin/end any more now because the throttle node will > > be drained. If this code is necessary, a bdrv_

Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051

2017-09-08 Thread Thomas Huth
On 08.09.2017 13:54, Kevin Wolf wrote: > Am 08.09.2017 um 13:24 hat Cornelia Huck geschrieben: >> On Fri, 8 Sep 2017 13:04:25 +0200 >> Kevin Wolf wrote: >> >>> Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben: The default cpu model on s390x does not provide zPCI, which is not yet wir

Re: [Qemu-block] [PATCH v3 4/7] block: remove legacy I/O throttling

2017-09-08 Thread Manos Pitsidianakis
On Thu, Sep 07, 2017 at 03:26:11PM +0200, Kevin Wolf wrote: We shouldn't really need any throttling code in blk_root_drained_begin/end any more now because the throttle node will be drained. If this code is necessary, a bdrv_drain() on an explicit throttle node will work differently from one on a

Re: [Qemu-block] [PATCH v6 16/18] qcow2: Switch store_bitmap_data() to byte-based iteration

2017-09-08 Thread Kevin Wolf
Am 08.09.2017 um 16:09 hat Eric Blake geschrieben: > On 09/08/2017 08:27 AM, Kevin Wolf wrote: > > Am 30.08.2017 um 23:05 hat Eric Blake geschrieben: > >> Now that we have adjusted the majority of the calls this function > >> makes to be byte-based, it is easier to read the code if it makes > >> pa

Re: [Qemu-block] [PATCH v6 16/18] qcow2: Switch store_bitmap_data() to byte-based iteration

2017-09-08 Thread Eric Blake
On 09/08/2017 08:27 AM, Kevin Wolf wrote: > Am 30.08.2017 um 23:05 hat Eric Blake geschrieben: >> Now that we have adjusted the majority of the calls this function >> makes to be byte-based, it is easier to read the code if it makes >> passes over the image using bytes rather than sectors. >> >> Si

Re: [Qemu-block] [PATCH v6 10/18] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes

2017-09-08 Thread Eric Blake
On 09/08/2017 07:51 AM, Kevin Wolf wrote: > Am 30.08.2017 um 23:05 hat Eric Blake geschrieben: >> Thanks to recent cleanups, all callers were scaling a return value >> of sectors into bytes; do the scaling internally instead. >> >> Signed-off-by: Eric Blake >> Reviewed-by: John Snow >> Reviewed-b

Re: [Qemu-block] [PATCH v6 05/18] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes

2017-09-08 Thread Eric Blake
On 09/08/2017 07:22 AM, Kevin Wolf wrote: > Am 30.08.2017 um 23:05 hat Eric Blake geschrieben: >> We are still using an internal hbitmap that tracks a size in sectors, >> with the granularity scaled down accordingly, because it lets us >> use a shortcut for our iterators which are currently sector-

Re: [Qemu-block] [PATCH v6 14/18] qcow2: Switch qcow2_measure() to byte-based iteration

2017-09-08 Thread Eric Blake
On 09/08/2017 08:15 AM, Kevin Wolf wrote: > Am 30.08.2017 um 23:05 hat Eric Blake geschrieben: >> This is new code, but it is easier to read if it makes passes over >> the image using bytes rather than sectors (and will get easier in >> the future when bdrv_get_block_status is converted to byte-bas

Re: [Qemu-block] [PATCH v6 16/18] qcow2: Switch store_bitmap_data() to byte-based iteration

2017-09-08 Thread Kevin Wolf
Am 30.08.2017 um 23:05 hat Eric Blake geschrieben: > Now that we have adjusted the majority of the calls this function > makes to be byte-based, it is easier to read the code if it makes > passes over the image using bytes rather than sectors. > > Signed-off-by: Eric Blake > Reviewed-by: John Sno

Re: [Qemu-block] [PATCH v6 14/18] qcow2: Switch qcow2_measure() to byte-based iteration

2017-09-08 Thread Kevin Wolf
Am 30.08.2017 um 23:05 hat Eric Blake geschrieben: > This is new code, but it is easier to read if it makes passes over > the image using bytes rather than sectors (and will get easier in > the future when bdrv_get_block_status is converted to byte-based). > > Signed-off-by: Eric Blake > Reviewed

Re: [Qemu-block] [PATCH v2 12/17] MAINTAINERS: add missing megasas test entry

2017-09-08 Thread Philippe Mathieu-Daudé
ping? On 08/30/2017 06:55 PM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fa74b7254b..20d65dca73 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1118,6 +1118,7 @@ L: qem

Re: [Qemu-block] [PATCH v6 10/18] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes

2017-09-08 Thread Kevin Wolf
Am 30.08.2017 um 23:05 hat Eric Blake geschrieben: > Thanks to recent cleanups, all callers were scaling a return value > of sectors into bytes; do the scaling internally instead. > > Signed-off-by: Eric Blake > Reviewed-by: John Snow > Reviewed-by: Juan Quintela > diff --git a/block/mirror.c

Re: [Qemu-block] [PATCH v6 05/18] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes

2017-09-08 Thread Kevin Wolf
Am 30.08.2017 um 23:05 hat Eric Blake geschrieben: > We are still using an internal hbitmap that tracks a size in sectors, > with the granularity scaled down accordingly, because it lets us > use a shortcut for our iterators which are currently sector-based. > But there's no reason we can't track t

Re: [Qemu-block] [PATCH 2/3] iotests: use -ccw on s390x for 051

2017-09-08 Thread Kevin Wolf
Am 08.09.2017 um 13:24 hat Cornelia Huck geschrieben: > On Fri, 8 Sep 2017 13:04:25 +0200 > Kevin Wolf wrote: > > > Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben: > > > The default cpu model on s390x does not provide zPCI, which is > > > not yet wired up on tcg. Moreover, virtio-ccw is the

Re: [Qemu-block] [PATCH 2/3] iotests: use -ccw on s390x for 051

2017-09-08 Thread Cornelia Huck
On Fri, 8 Sep 2017 13:04:25 +0200 Kevin Wolf wrote: > Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben: > > The default cpu model on s390x does not provide zPCI, which is > > not yet wired up on tcg. Moreover, virtio-ccw is the standard > > on s390x, so use the -ccw instead of the -pci versio

Re: [Qemu-block] [PATCH 1/3] iotests: use -ccw on s390x for 040, 139, and 182

2017-09-08 Thread Kevin Wolf
Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben: > The default cpu model on s390x does not provide zPCI, which is > not yet wired up on tcg. Moreover, virtio-ccw is the standard > on s390x, so use the -ccw instead of the -pci versions of virtio > devices on s390x. > > Signed-off-by: Cornelia

Re: [Qemu-block] [PATCH 3/3] iotests: use -ccw on s390x for 067

2017-09-08 Thread Kevin Wolf
Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben: > The default cpu model on s390x does not provide zPCI, which is > not yet wired up on tcg. Moreover, virtio-ccw is the standard > on s390x, so use the -ccw instead of the -pci versions of virtio > devices on s390x. > > Provide an output file f

Re: [Qemu-block] [PATCH v6] docs: add qemu-block-drivers(7) man page

2017-09-08 Thread Kevin Wolf
Am 08.09.2017 um 10:39 hat Stefan Hajnoczi geschrieben: > Block driver documentation is available in qemu-doc.html. It would be > convenient to have documentation for formats, protocols, and filter > drivers in a man page. > > Extract the relevant part of qemu-doc.html into a new file called > do

Re: [Qemu-block] [PATCH 2/3] iotests: use -ccw on s390x for 051

2017-09-08 Thread Kevin Wolf
Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben: > The default cpu model on s390x does not provide zPCI, which is > not yet wired up on tcg. Moreover, virtio-ccw is the standard > on s390x, so use the -ccw instead of the -pci versions of virtio > devices on s390x. > > Provide an output file f

Re: [Qemu-block] [PATCH v3] file-posix: Clear out first sector in hdev_create

2017-09-08 Thread Kevin Wolf
Am 08.09.2017 um 11:44 hat Fam Zheng geschrieben: > People get surprised when, after "qemu-img create -f raw /dev/sdX", they > still see qcow2 with "qemu-img info", if previously the bdev had a qcow2 > header. While this is natural because raw doesn't need to write any > magic bytes during creation

Re: [Qemu-block] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python

2017-09-08 Thread Kashyap Chamarthy
On Tue, Sep 05, 2017 at 02:37:21PM -0500, Eric Blake wrote: > On 09/04/2017 08:28 AM, Kashyap Chamarthy wrote: > > On Mon, Sep 04, 2017 at 08:55:23PM +0800, Fam Zheng wrote: > >> Hi Kashyap, > >> > >> On Mon, 09/04 13:16, Kashyap Chamarthy wrote: > > >>> The test 192 ("Test NBD export with '-incom

[Qemu-block] [PATCH v3] file-posix: Clear out first sector in hdev_create

2017-09-08 Thread Fam Zheng
People get surprised when, after "qemu-img create -f raw /dev/sdX", they still see qcow2 with "qemu-img info", if previously the bdev had a qcow2 header. While this is natural because raw doesn't need to write any magic bytes during creation, hdev_create is free to clear out the first sector to mak

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.11 v2] file-posix: Clear out first sector in hdev_create

2017-09-08 Thread Fam Zheng
On Thu, 09/07 17:07, Kevin Wolf wrote: > > diff --git a/block/file-posix.c b/block/file-posix.c > > index f4de022ae0..a63bbf2b90 100644 > > --- a/block/file-posix.c > > +++ b/block/file-posix.c > > @@ -2703,6 +2703,16 @@ static int hdev_create(const char *filename, > > QemuOpts *opts, > >

[Qemu-block] [PATCH v6] docs: add qemu-block-drivers(7) man page

2017-09-08 Thread Stefan Hajnoczi
Block driver documentation is available in qemu-doc.html. It would be convenient to have documentation for formats, protocols, and filter drivers in a man page. Extract the relevant part of qemu-doc.html into a new file called docs/qemu-block-drivers.texi. This file can also be built as a stand-