On 09/11/2017 01:20 PM, Eric Blake wrote:
> Rather than have two similar shutdown functions, where one requires
> the use of global_qtest in the header, it is better to have a single
> shutdown function that still takes care of cleaning up global_qtest
> if it is set. All callers are updated.
>
On 09/11/2017 08:20 PM, John Snow wrote:
>
>
> On 09/11/2017 01:20 PM, Eric Blake wrote:
>> Managing parallel connections to two different monitors via
>> the implicit global_qtest makes it hard to copy-and-paste code
>> to tests that are not aware of the implicit state; the
>> management of gl
On 09/11/2017 01:20 PM, Eric Blake wrote:
> Managing parallel connections to two different monitors via
> the implicit global_qtest makes it hard to copy-and-paste code
> to tests that are not aware of the implicit state; the
> management of global_qtest is even harder to follow because
> it was
On 09/11/2017 01:20 PM, Eric Blake wrote:
> Drop one more client of global_qtest by teaching all remaining
> libqos stragglers to pass in an explicit QTestState. Change the
> setting of global_qtest from being implicit in libqos' call to
> qtest_start() to instead be explicit in all clients that
On 09/11/2017 01:20 PM, Eric Blake wrote:
> Drop one more client of global_qtest by teaching all ahci test
> functionality to pass in an explicit QTestState. The state was
> already available, so no callers had to be adjusted.
>
> Signed-off-by: Eric Blake
I should admit that this makes my ur
On 09/11/2017 01:19 PM, Eric Blake wrote:
> Drop one more client of global_qtest by teaching all fw_cfg test
> functionality (invoked through alloc-pc) to pass in an explicit
> QTestState, adjusting all callers. In particular, fw_cfg-test
> had to reorder things to create the test state prior to
On 09/11/2017 01:19 PM, Eric Blake wrote:
> When initializing a QPCIBus, track which QTestState the bus is
> associated with (so that a later patch can then explicitly use
> that test state for all communication on the bus, rather than
> blindly relying on global_qtest). Update the initializatio
- Original Message -
> From: "John Snow"
> To: "Paolo Bonzini" , qemu-de...@nongnu.org
> Cc: kw...@redhat.com, qemu-block@nongnu.org
> Sent: Tuesday, September 12, 2017 12:22:26 AM
> Subject: Re: [Qemu-block] [PATCH 00/12] cleanup qemu-iotests
>
>
>
> On 08/09/2017 05:54 PM, Paolo Bon
On 08/09/2017 05:54 PM, Paolo Bonzini wrote:
> The purpose of this series is to separate the "check" sources from
> the tests. After these patches, common.config is reduced to simple
> shell initialization, and common.rc is only included by the tests.
>
> Along the way, a lot of dead code is re
On Mon, 11 Sep 2017 12:20:19 -0500
Eric Blake wrote:
> Maintaining two layers of libqtest APIs, one that takes an explicit
> QTestState object, and the other that uses the implicit global_qtest,
> is annoying. In the interest of getting rid of global implicit
> state and having less code to main
On Mon, 11 Sep 2017 12:20:01 -0500
Eric Blake wrote:
> Drop one more client of global_qtest by teaching all remaining
> libqos stragglers to pass in an explicit QTestState. Change the
> setting of global_qtest from being implicit in libqos' call to
> qtest_start() to instead be explicit in all c
Maintaining two layers of libqtest APIs, one that takes an explicit
QTestState object, and the other that uses the implicit global_qtest,
is annoying. In the interest of getting rid of global implicit
state and having less code to maintain, merge:
qtest_memset()
with its short counterpart. All c
Maintaining two layers of libqtest APIs, one that takes an explicit
QTestState object, and the other that uses the implicit global_qtest,
is annoying. In the interest of getting rid of global implicit
state and having less code to maintain, merge:
qtest_readb()
qtest_readw()
qtest_readl()
qtes
Maintaining two layers of libqtest APIs, one that takes an explicit
QTestState object, and the other that uses the implicit global_qtest,
is annoying. In the interest of getting rid of global implicit
state and having less code to maintain, merge:
qtest_outb()
qtest_outw()
qtest_outl()
qtest_i
Maintaining two layers of libqtest APIs, one that takes an explicit
QTestState object, and the other that uses the implicit global_qtest,
is annoying. In the interest of getting rid of global implicit
state and having less code to maintain, merge:
qtest_hmp()
with its short counterpart, and delet
Maintaining two layers of libqtest APIs, one that takes an explicit
QTestState object, and the other that uses the implicit global_qtest,
is annoying. In the interest of getting rid of global implicit
state and having less code to maintain, merge:
qtest_clock_set()
qtest_clock_step()
qtest_cloc
Remove the trivial wrapper qtest_init(), and change qtest_start()
to no longer implicitly set global_qtest, to make it obvious in the
rest of the testsuite where we are still relying on global_qtest.
Everything now uses qtest_start() (and friends) and qtest_quit(),
and explicitly tracks the QTestSt
Upcoming patches will be adding new convenience methods for
constructing QMP commands. But making every variation of sending
support every variation of response handling becomes unwieldy;
it's easier to specify that discarding a JSON response is
unassociated with sending the command, where qmp_asy
We have several callers that were formatting the argument strings
themselves; consolidate this effort by adding new convenience
functions directly in libqtest, and update all call-sites that
can benefit from it.
Note that the new functions qtest_startf() and qtest_vstartf()
behave more like qtest_
Maintaining two layers of libqtest APIs, one that takes an explicit
QTestState object, and the other that uses the implicit global_qtest,
is annoying. In the interest of getting rid of global implicit
state and having less code to maintain, merge:
qtest_memread()
qtest_bufread()
qtest_memwrite(
Maintaining two layers of libqtest APIs, one that takes an explicit
QTestState object, and the other that uses the implicit global_qtest,
is annoying. In the interest of getting rid of global implicit
state and having less code to maintain, merge:
qtest_get_irq()
qtest_irq_intercept_in()
qtest_
Rather than have two similar shutdown functions, where one requires
the use of global_qtest in the header, it is better to have a single
shutdown function that still takes care of cleaning up global_qtest
if it is set. All callers are updated.
Signed-off-by: Eric Blake
---
tests/libqtest.h
Managing parallel connections to two different monitors via
the implicit global_qtest makes it hard to copy-and-paste code
to tests that are not aware of the implicit state; the
management of global_qtest is even harder to follow because
it was masked behind set_context().
Instead, explicitly pass
Drop one more client of global_qtest by teaching all remaining
libqos stragglers to pass in an explicit QTestState. Change the
setting of global_qtest from being implicit in libqos' call to
qtest_start() to instead be explicit in all clients that are
still relying on global_qtest.
Note that qmp_e
When initializing a QVirtioDevice (which always has an associated
QVirtioBus), we want to track which QTestState to use for all
I/O processed through that bus and device. Copy the paradigm
used for QPCIBus, and track the test state at the bus level; this
in turn requires a separate bus object per
Drop one more client of global_qtest by teaching all ahci test
functionality to pass in an explicit QTestState. The state was
already available, so no callers had to be adjusted.
Signed-off-by: Eric Blake
---
v7: split libqos changes from test-ahci
---
tests/libqos/ahci.c | 45
Drop one more client of global_qtest by teaching all fw_cfg test
functionality (invoked through alloc-pc) to pass in an explicit
QTestState, adjusting all callers. In particular, fw_cfg-test
had to reorder things to create the test state prior to creating
the fw_cfg (and drop a pointless strdup in
Now that QVirtioDevice and QVirtQueue point back to QVirtioBus,
we can reuse the explicit QTestState stored there rather than
relying on implicit global_qtest. We also have to pass QTestState
through a few functions that can't trace back through
QVirtioDevice, and update those callers.
Drop some
Now that the QPCIBus tracks QTestState, use that state instead
of an implicit reliance on global_qtest.
Pass an explicit QTestState to the remaining few functions in
the same file that don't have direct access to QPCIBus, and
update all callers.
Signed-off-by: Eric Blake
---
v7: more sites with
When initializing a QPCIBus, track which QTestState the bus is
associated with (so that a later patch can then explicitly use
that test state for all communication on the bus, rather than
blindly relying on global_qtest). Update the initialization
functions to take another parameter, and update al
Commit 2f8b2767 originally added qpci_plug_device_test() and
qpci_unplug_acpi_device_test() as a pair, both in pci-pc.c.
Later, commit cf716b31 moved one half of the pair to pci.c
when adding PPC64 support. Keep the implementations of the
two functions together, and shorten the name to
qpci_unplug
Hi Kevin!
I'm confused with relations of permissions and invalidation, can you
please help?
Now dirty bitmaps are loaded in invalidate_cache. Here is a problem with
migration:
1. destination starts (inactive)
2. load bitmaps readonly
...
3. invalidate_cache: here we should make our loade
Am 25.07.2017 um 16:41 hat Peter Lieven geschrieben:
> Signed-off-by: Peter Lieven
> ---
> docs/interop/qcow2.txt | 51
> +-
> roms/ipxe | 2 +-
> 2 files changed, 51 insertions(+), 2 deletions(-)
>
> diff --git a/docs/interop/qcow2.
Am 25.07.2017 um 23:55 hat Eric Blake geschrieben:
> On 07/25/2017 09:41 AM, Peter Lieven wrote:
> > Signed-off-by: Peter Lieven
> > ---
> > block/qcow2.c| 7 +++
> > qapi/block-core.json | 6 +-
> > 2 files changed, 12 insertions(+), 1 deletion(-)
> >
> > +++ b/qapi/block-core.j
Dne 8.9.2017 v 17:55 Thomas Huth napsal(a):
> On 08.09.2017 13:54, Kevin Wolf wrote:
>> Am 08.09.2017 um 13:24 hat Cornelia Huck geschrieben:
>>> On Fri, 8 Sep 2017 13:04:25 +0200
>>> Kevin Wolf wrote:
>>>
Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben:
> The default cpu model on s3
On 10/09/2017 19:15, Philippe Mathieu-Daudé wrote:
> and update maintainer email address
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Hannes Reinecke replied:
> I'm currently on vacation with no internet access, but will be happy to
> answer your mail once I'm back at work on Sep, 12th.
>
On 30/08/2017 18:37, Stefan Hajnoczi wrote:
>
> The case statements asssume sz has a certain minimum value. I didn't
> see a check anywhere that guarantees this. It may be easier to hide the
> client's sz value and instead use sizeof(client->data). The caller can
> worry about sz.
Makes sense.
37 matches
Mail list logo
