Re: [Qemu-block] [PATCH v3 11/13] nbd: share some nbd entities to be reused in block/nbd-client.c

2017-10-13 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/nbd.h | 48 > nbd/nbd-internal.h | 25 - > nbd/client.c| 32

Re: [Qemu-block] [PATCH v3 13/13] nbd: Minimal structured read for client

2017-10-13 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Minimal implementation: for structured error only error_report error > message. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/nbd.h | 6 + > block/nbd-client.c | 395 >

Re: [Qemu-block] [PATCH v3 12/13] nbd/client: prepare nbd_receive_reply for structured reply

2017-10-13 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > In following patch nbd_receive_reply will be used both for simple > and structured reply header receiving. > NBDReply is altered into union of simple reply header and structured > reply chunk header, simple error translation moved to

Re: [Qemu-block] [PATCH v3 11/13] nbd: share some nbd entities to be reused in block/nbd-client.c

2017-10-13 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/nbd.h | 48 > nbd/nbd-internal.h | 25 - > nbd/client.c| 32

Re: [Qemu-block] [PATCH v3 11/13] nbd: share some nbd entities to be reused in block/nbd-client.c

2017-10-13 Thread Vladimir Sementsov-Ogievskiy
13.10.2017 21:47, Eric Blake wrote: On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 48 nbd/nbd-internal.h | 25

Re: [Qemu-block] [PATCH v3 11/13] nbd: share some nbd entities to be reused in block/nbd-client.c

2017-10-13 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/nbd.h | 48 > nbd/nbd-internal.h | 25 - > nbd/client.c| 32

Re: [Qemu-block] [PATCH v3 10/13] nbd/client: refactor nbd_receive_starttls

2017-10-13 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Split out nbd_receive_simple_option to be reused for structured reply s/receive/request/, but see [1] > option. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/client.c | 64 >

Re: [Qemu-block] [Qemu-devel] [PATCH v3 09/13] nbd: Minimal structured read for server

2017-10-13 Thread Vladimir Sementsov-Ogievskiy
13.10.2017 19:15, Eric Blake wrote: On 10/13/2017 11:00 AM, Eric Blake wrote: On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal implementation of structured read: one structured reply chunk, no segmentation. Minimal structured error implementation: no text message. Support DF

Re: [Qemu-block] [PATCH v3 09/13] nbd: Minimal structured read for server

2017-10-13 Thread Vladimir Sementsov-Ogievskiy
13.10.2017 19:00, Eric Blake wrote: On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal implementation of structured read: one structured reply chunk, no segmentation. Minimal structured error implementation: no text message. Support DF flag, but just ignore it, as there is no

Re: [Qemu-block] [Qemu-devel] [PATCH v3 09/13] nbd: Minimal structured read for server

2017-10-13 Thread Eric Blake
On 10/13/2017 11:00 AM, Eric Blake wrote: > On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: >> Minimal implementation of structured read: one structured reply chunk, >> no segmentation. >> Minimal structured error implementation: no text message. >> Support DF flag, but just ignore it,

Re: [Qemu-block] [PATCH v3 09/13] nbd: Minimal structured read for server

2017-10-13 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Minimal implementation of structured read: one structured reply chunk, > no segmentation. > Minimal structured error implementation: no text message. > Support DF flag, but just ignore it, as there is no segmentation any > way. > >

Re: [Qemu-block] [PATCH v13 2/6] qmp: Use ThrottleLimits structure

2017-10-13 Thread Eric Blake
[adding Markus, and block list] On 10/13/2017 09:16 AM, Alberto Garcia wrote: > On Mon 02 Oct 2017 04:33:28 PM CEST, Pradeep Jagadeesh wrote: >> This patch factors out code to use the ThrottleLimits >> structure. > >> { 'struct': 'BlockIOThrottle', >> - 'data': { '*device': 'str', '*id':

[Qemu-block] iotest 77 failure [was: [Qemu-devel] [PATCH v2 0/5] backup improvements part 1]

2017-10-13 Thread Eric Blake
[adding qemu-block] On 10/13/2017 02:37 AM, Vladimir Sementsov-Ogievskiy wrote: > 077 is unrelated to backup, it's already broken test: > > i=1; while check -nbd 077; do echo $((i++)) - OK; done; echo $i - FAIL > > failed on 3rd try for me on master > >> 077 - output mismatch (see

Re: [Qemu-block] [PATCH 18/31] qcow2: Update qcow2_get_cluster_offset() to support L2 slices

2017-10-13 Thread Alberto Garcia
On Thu, Oct 12, 2017 at 04:05:32PM +0300, Alberto Garcia wrote: > @@ -522,8 +522,8 @@ int qcow2_get_cluster_offset(BlockDriverState *bs, > uint64_t offset, > { > BDRVQcow2State *s = bs->opaque; > unsigned int l2_index; > -uint64_t l1_index, l2_offset, *l2_table; > -int l1_bits,

Re: [Qemu-block] [PATCH v3 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks

2017-10-13 Thread Stefan Hajnoczi
On Sat, Sep 23, 2017 at 02:14:08PM +0300, Manos Pitsidianakis wrote: > This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new > bdrv_co_drain_end callback to match bdrv_drained_begin/end and > drained_begin/end of BdrvChild. This is needed because the throttle driver >

Re: [Qemu-block] [PATCH v3 00/13] nbd minimal structured read

2017-10-13 Thread Vladimir Sementsov-Ogievskiy
13.10.2017 01:39, Eric Blake wrote: On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: Minimally implement nbd structured read extension. v3: clone: tag up-nbd-minimal-structured-read-v3 from https://src.openvz.org/scm/~vsementsov/qemu.git online: