First, I can running my qemu guest normally,
And i can use keyboard and mouse in my VM,
But i cannot use those after one day.
And cannot find any useful log in my system.
those message is my VM state( with qemu-monitor-command ):
Device 0.1, Port 1, Speed 1.5 Mb/s, Product G100s Gaming Keyboard,
An upcoming change to block/nbd-client.c will want to read the
tail of a structured reply chunk directly from the wire. Move
this function to make it easier.
Based on a patch from Vladimir Sementsov-Ogievskiy.
Signed-off-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-Id: <201
From: Vladimir Sementsov-Ogievskiy
Split out nbd_request_simple_option to be reused for structured reply
option.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Eric Blake
Message-Id: <20171027104037.8319-10-ebl...@redhat.com>
---
nbd/client.c | 70 +
The NBD spec permits including a human-readable error string if
structured replies are in force, so we might as well send the
client the message that we logged on any error.
Signed-off-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20171027104037.8319-9-ebl...@redhat.com>
From: Vladimir Sementsov-Ogievskiy
In following patch nbd_receive_reply will be used both for simple
and structured reply header receiving.
NBDReply is altered into union of simple reply header and structured
reply chunk header, simple error translation moved to block/nbd-client
to be consistent
From: Vladimir Sementsov-Ogievskiy
Minimal implementation of structured read: one structured reply chunk,
no segmentation.
Minimal structured error implementation: no text message.
Support DF flag, but just ignore it, as there is no segmentation any
way.
Signed-off-by: Vladimir Sementsov-Ogievsk
Instead of making each caller check whether a transmission error
occurred, we can sink a common error check to the end of the loop.
Signed-off-by: Eric Blake
Message-Id: <20171027104037.8319-6-ebl...@redhat.com>
[eblake: squash in compiler warning fix]
Reviewed-by: Vladimir Sementsov-Ogievskiy
-
When the server is read-only, we were already reporting an error
message for NBD_CMD_WRITE_ZEROES, but failed to set errp for a
similar NBD_CMD_WRITE. This will matter more once structured
replies allow the server to propagate the errp information back
to the client. While at it, use an error mes
Consolidate the response for a non-zero-length option payload
into a new function, nbd_reject_length(). This check will
also be used when introducing support for structured replies.
Note that STARTTLS response differs based on time: if the connection
is still unencrypted, we set fatal to true (a
Upcoming patches will implement the NBD structured reply
extension [1] for both client and server roles. Declare the
constants, structs, and lookup routines that will be valuable
whether the server or client code is backported in isolation.
This includes moving one constant from an internal heade
This is needed in preparation for structured reply handling,
as we will be performing the translation from NBD error to
system errno value higher in the stack at block/nbd-client.c.
Signed-off-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20171027104037.8319-3-ebl...@redh
From: Vladimir Sementsov-Ogievskiy
Minimal implementation: for structured error only error_report error
message.
Note that test 83 is now more verbose, because the implementation
prints more warnings about unexpected communication errors; perhaps
future patches should tone things down by using t
NBD errors were originally sent over the wire based on Linux errno
values; but not all the world is Linux, and not all platforms share
the same values. Since a number isn't very easy to decipher on all
platforms, update the trace messages to include the name of NBD
errors being sent/received over
On 10/30/2017 09:11 PM, Eric Blake wrote:
> On 10/30/2017 06:22 PM, Vladimir Sementsov-Ogievskiy wrote:
>> 27.10.2017 13:40, Eric Blake wrote:
>>> Consolidate the response for a non-zero-length option payload
>>> into a new function, nbd_reject_length(). This check will
>>> also be used when intro
On 10/30/2017 06:22 PM, Vladimir Sementsov-Ogievskiy wrote:
> 27.10.2017 13:40, Eric Blake wrote:
>> Consolidate the response for a non-zero-length option payload
>> into a new function, nbd_reject_length(). This check will
>> also be used when introducing support for structured replies.
>>
>> Not
30.10.2017 19:32, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
There is a new version of dirty bitmap postcopy migration series.
v8
clone: tag postcopy-v8 from https://src.openvz.org/scm/~vsementsov/qemu.git
online: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=postcopy-v8
comp
There would be savevm states (dirty-bitmap) which can migrate only in
postcopy stage. The corresponding pending is introduced here.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Juan Quintela
---
8.1: add new version for cmma_save_pending too.
include/migration/register.h | 17 +++
30.10.2017 20:31, Dr. David Alan Gilbert wrote:
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
There would be savevm states (dirty-bitmap) which can migrate only in
postcopy stage. The corresponding pending is introduced here.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Revie
27.10.2017 13:45, Eric Blake wrote:
Commenting these two lines is enough to avoid the change to 083.out
in 12/12. That is evidence that we may want these two lines to be
trace points rather than error messages; or maybe we really do like
the extra verbosity in the case of an unexpected communica
27.10.2017 13:40, Eric Blake wrote:
From: Vladimir Sementsov-Ogievskiy
Minimal implementation: for structured error only error_report error
message.
Note that test 83 is now more verbose, because the implementation
prints more warnings about unexpected communication errors; perhaps
future patc
27.10.2017 13:40, Eric Blake wrote:
From: Vladimir Sementsov-Ogievskiy
Split out nbd_request_simple_option to be reused for structured reply
option.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Eric Blake
ok for me.
---
v6: error message tweak [Vladimir]
v5: only check le
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
> There would be savevm states (dirty-bitmap) which can migrate only in
> postcopy stage. The corresponding pending is introduced here.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Juan Quintela
Note the error pa
27.10.2017 13:40, Eric Blake wrote:
From: Vladimir Sementsov-Ogievskiy
Minimal implementation of structured read: one structured reply chunk,
no segmentation.
Minimal structured error implementation: no text message.
Support DF flag, but just ignore it, as there is no segmentation any
way.
Sig
27.10.2017 13:40, Eric Blake wrote:
Consolidate the response for a non-zero-length option payload
into a new function, nbd_reject_length(). This check will
also be used when introducing support for structured replies.
Note that STARTTLS response differs based on time: if the connection
is still
Cc'ing Stefan and Trivial
On 10/30/2017 01:07 PM, Doug Gale wrote:
> From 0e27b5dca8f4f32a1b194e1b3544be77dd4f45d9 Mon Sep 17 00:00:00 2001
> From: Doug Gale
> Date: Mon, 30 Oct 2017 09:28:43 -0400
> Subject: [PATCH] nvme: Add tracing
>
^ to remove from commit description, maybe maintainer taki
Postcopy migration of dirty bitmaps. Only named dirty bitmaps,
associated with root nodes and non-root named nodes are migrated.
If destination qemu is already containing a dirty bitmap with the same name
as a migrated bitmap (for the same node), then, if their granularities are
the same the migra
It is needed to realize bdrv_dirty_bitmap_release_successor in
the following patch.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
inde
To just release successor and unfreeze bitmap without any additional
work.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
---
include/block/dirty-bitmap.h | 2 ++
block/dirty-bitmap.c | 14 ++
2 files changed, 16 insertions(+)
diff --git a/includ
There would be savevm states (dirty-bitmap) which can migrate only in
postcopy stage. The corresponding pending is introduced here.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Juan Quintela
---
include/migration/register.h | 17 +++--
migration/savevm.h | 5 +
Hi all!
There is a new version of dirty bitmap postcopy migration series.
v8
clone: tag postcopy-v8 from https://src.openvz.org/scm/~vsementsov/qemu.git
online: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=postcopy-v8
- rebased on master
- patches 01-03 from v7 are already merge
Test
- start two vms (vm_a, vm_b)
- in a
- do writes from set A
- do writes from set B
- fix bitmap sha256
- clear bitmap
- do writes from set A
- start migration
- than, in b
- wait vm start (postcopy should start)
- do writes from set B
- check bitmap sha256
27.10.2017 13:40, Eric Blake wrote:
Instead of making each caller check whether a transmission error
occurred, we can sink a common error check to the end of the loop.
Signed-off-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
Only-postcopy savevm states (dirty-bitmap) don't need live iteration, so
to disable them and stop transporting empty sections there is a new
savevm handler.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Juan Quintela
---
include/migration/register.h | 1 +
migration/savevm.c
The test starts two vms (vm_a, vm_b), create dirty bitmap in
the first one, do several writes to corresponding device and
then migrate vm_a to vm_b with dirty bitmaps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iotests/169 | 86
Enable postcopy if dirty bitmap migration is endabled.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Juan Quintela
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 1526cd4bff..e973837bfd
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Juan Quintela
---
qapi/migration.json | 6 +-
migration/migration.h | 1 +
migration/migration.c | 9 +
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/qapi/migr
Test that persistent bitmap migrates and its persistance property
migrates too.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/169 | 21 ++---
tests/qemu-iotests/169.out | 4 ++--
2 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-
Enabling bitmap successor is necessary to enable successors of bitmaps
being migrated before target vm start.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/dirty-bitmap.h | 1 +
block/dirty-bitmap.c | 8
2 files changed, 9 insertions(+)
diff --git a/include/bloc
Make it possible to set bitmap 'frozen' without a successor.
This is needed to protect the bitmap during outgoing bitmap postcopy
migration.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/dirty-bitmap.h | 1 +
block/dirty-bitmap.c | 22 --
2 files chan
Add function opposite to qemu_get_counted_string.
qemu_put_counted_string puts one-byte length of the string (string
should not be longer than 255 characters), and then it puts the string,
without last zero byte.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Reviewed-by: Jua
When testing migration, auto-generated by qemu node-names differs in
source and destination qemu and migration fails. After this patch,
auto-generated by iotest nodenames will be the same.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 2 +
>From 0e27b5dca8f4f32a1b194e1b3544be77dd4f45d9 Mon Sep 17 00:00:00 2001
From: Doug Gale
Date: Mon, 30 Oct 2017 09:28:43 -0400
Subject: [PATCH] nvme: Add tracing
Add trace output for commands, errors, and undefined behavior.
Add guest error log output for undefined behavior.
Report invalid undefin
On Sun, Oct 29, 2017 at 01:53:38PM +0100, Kevin Wolf wrote:
> This avoids that random UI frontend error messages end up in the output.
> In particular, we were seeing this line in CI error logs:
>
> +Unable to init server: Could not connect: Connection refused
>
> Signed-off-by: Kevin Wolf
> ---
Hi!
Any ideas?
05.10.2017 12:41, Vladimir Sementsov-Ogievskiy wrote:
12.09.2017 12:46, Kevin Wolf wrote:
Am 11.09.2017 um 18:51 hat Vladimir Sementsov-Ogievskiy geschrieben:
Hi Kevin!
I'm confused with relations of permissions and invalidation, can you
please
help?
Now dirty bitmaps are l
On Fri 29 Sep 2017 06:53:31 PM CEST, Max Reitz wrote:
> @@ -4096,22 +4086,31 @@ BlockDriverState
> *bdrv_find_backing_image(BlockDriverState *bs,
> } else {
> /* If not an absolute filename path, make it relative to the
> current
> * image's filename path */
>
On Fri 29 Sep 2017 06:53:30 PM CEST, Max Reitz wrote:
> This is a general function for making a filename that is relative to a
> certain BDS absolute.
>
> It calls bdrv_get_full_backing_filename_from_filename() for now, but
> that will be changed in a follow-up patch.
>
> Signed-off-by: Max Reitz
On Mon, Oct 30, 2017 at 11:13:21AM +0100, Kevin Wolf wrote:
> Am 30.10.2017 um 09:39 hat Kashyap Chamarthy geschrieben:
> > On Sun, Oct 29, 2017 at 01:53:38PM +0100, Kevin Wolf wrote:
[...]
> > > echo
> > > echo "Starting a second QEMU using the same image should fail"
> > > -echo 'quit' | $QEM
Test 194 checks for 'luks' to exclude as an unsupported format,
However, most formats are unsupported, due to migration blockers.
Rather than specifying a blacklist of unsupported formats, whitelist
supported formats (specifically, qcow2, qed, raw, dmg).
Signed-off-by: Jeff Cody
---
tests/qemu-
The VHDX specification requires that before user data modification of
the vhdx image, the VHDX header file and data GUIDs need to be updated.
In vhdx_open(), if the image is set to RDWR, we go ahead and update the
header.
However, just because the image is set to RDWR does not mean we can go
ahead
If we write or modify the image file while the QEMU run state is
INMIGRATE, then the BDRV_O_INACTIVE BDS flag is set. This will cause
an assert, since the image is marked inactive. Make sure we obey this
flag.
Signed-off-by: Jeff Cody
---
block/parallels.c | 7 ++-
1 file changed, 2 insert
Changes from v1->v2:
* Drop previous parallels patches, just check BDRV_O_INACTIVE now
(Kevin)
git-backport-diff -r qemu/master.. -u github/master
Key:
[] : patches are identical
[] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
T
On 10/30/2017 01:34 PM, Vladimir Sementsov-Ogievskiy wrote:
> 27.10.2017 13:45, Eric Blake wrote:
>> Commenting these two lines is enough to avoid the change to 083.out
>> in 12/12. That is evidence that we may want these two lines to be
>> trace points rather than error messages; or maybe we real
27.10.2017 13:45, Eric Blake wrote:
Commenting these two lines is enough to avoid the change to 083.out
in 12/12. That is evidence that we may want these two lines to be
trace points rather than error messages; or maybe we really do like
the extra verbosity in the case of an unexpected communica
Hi Doug,
On 10/12/2017 04:07 PM, Doug Gale wrote:
> From c7f12a5949458fdd195b5e0b52f158e8f114f203 Mon Sep 17 00:00:00 2001
> From: Doug Gale
> Date: Thu, 12 Oct 2017 14:29:07 -0400
> Subject: [PATCH] nvme: Add tracing
>
> Add trace output for commands, errors, and undefined behavior.
> Add guest
Am 30.10.2017 um 09:39 hat Kashyap Chamarthy geschrieben:
> On Sun, Oct 29, 2017 at 01:53:38PM +0100, Kevin Wolf wrote:
> > This avoids that random UI frontend error messages end up in the output.
> > In particular, we were seeing this line in CI error logs:
> >
> > +Unable to init server: Could n
On Fri, Oct 20, 2017 at 4:11 PM, Doug Gale wrote:
> On Thu, Oct 12, 2017 at 3:07 PM, Doug Gale wrote:
>
>> From c7f12a5949458fdd195b5e0b52f158e8f114f203 Mon Sep 17 00:00:00 2001
>> From: Doug Gale
>> Date: Thu, 12 Oct 2017 14:29:07 -0400
>> Subject: [PATCH] nvme: Add tracing
>>
>> Add trace out
On Sun, Oct 29, 2017 at 01:53:38PM +0100, Kevin Wolf wrote:
> This avoids that random UI frontend error messages end up in the output.
> In particular, we were seeing this line in CI error logs:
>
> +Unable to init server: Could not connect: Connection refused
>
> Signed-off-by: Kevin Wolf
> ---
57 matches
Mail list logo