Re: [Qemu-block] [Qemu-devel] [PATCH v9 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap

2018-01-24 Thread John Snow
On 01/24/2018 05:16 AM, Paolo Bonzini wrote: > On 22/01/2018 13:14, Vladimir Sementsov-Ogievskiy wrote: >>> so, accessing the bitmap needs mutex lock? >>> >>> Then what do you mean under accessing the bitmap? Any touch of >>> BdrvDirtyBitmap fields? Then "reading the list" will require bitmap >>>

Re: [Qemu-block] [Qemu-devel] [PATCH] block/mirror: fix fail to cancel when VM has heavy BLK IO

2018-01-24 Thread Eric Blake
On 01/24/2018 12:17 AM, Liang Li wrote: > We found that when doing drive mirror to a low speed shared storage, > if there was heavy BLK IO write workload in VM after the 'ready' event, > drive mirror block job can't be canceled immediately, it would keep > running until the heavy BLK IO workload st

[Qemu-block] [PATCH] block/mirror: fix fail to cancel when VM has heavy BLK IO

2018-01-24 Thread Liang Li
We found that when doing drive mirror to a low speed shared storage, if there was heavy BLK IO write workload in VM after the 'ready' event, drive mirror block job can't be canceled immediately, it would keep running until the heavy BLK IO workload stopped in the VM. This patch fixed this issue. C

Re: [Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

2018-01-24 Thread Stefan Hajnoczi
On Mon, Jan 22, 2018 at 09:01:49AM -0600, Mark Kanda wrote: > Add a BlockDriverState NULL check to virtio_blk_handle_request() > to prevent a segfault if the drive is forcibly removed using HMP > 'drive_del' (without performing a hotplug 'device_del' first). > > Signed-off-by: Mark Kanda > Review

Re: [Qemu-block] [Qemu-devel] [PATCH v9 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap

2018-01-24 Thread Paolo Bonzini
On 22/01/2018 13:14, Vladimir Sementsov-Ogievskiy wrote: >> so, accessing the bitmap needs mutex lock? >> >> Then what do you mean under accessing the bitmap? Any touch of >> BdrvDirtyBitmap fields? Then "reading the list" will require bitmap >> mutex too. >> Or accessing the bitmap is accessing an