Nack. This will be fixed by
s390/ipl: only print boot menu error if -boot menu=on was specified
On 03/06/2018 08:54 AM, QingFeng Hao wrote:
> In s390x, the case 200 failed as:
> === Starting QEMU VM ===
>
> +QEMU_PROG: boot menu is not supported for this device type.
> {"return": {}}
>
> ==
In s390x, the case 200 failed as:
=== Starting QEMU VM ===
+QEMU_PROG: boot menu is not supported for this device type.
{"return": {}}
=== Sending stream/cancel, checking for SIGSEGV only ===
Failures: 200
Failed 1 of 1 tests
It was caused by the command which isn't supported by s390x now:
qe
On 03/05/2018 01:47 PM, Eric Blake wrote:
On 03/05/2018 12:04 PM, Vladimir Sementsov-Ogievskiy wrote:
In the subject line: s/space/sparse/
In case of io error in nbd_co_send_sparse_read we should not
"goto reply:", as it is fatal error and common behavior is
disconnect in this case. We should
On 03/02/2018 12:54 PM, Kevin Wolf wrote:
From: Stefan Hajnoczi
BlockDriverState has the BDRV_POLL_WHILE() macro to wait on event loop
activity while a condition evaluates to true. This is used to implement
synchronous operations where it acts as a condvar between the IOThread
running the oper
On 03/05/2018 12:04 PM, Vladimir Sementsov-Ogievskiy wrote:
In case of io error in nbd_co_send_sparse_read we should not
"goto reply:", as it is fatal error and common behavior is
disconnect in this case. We should not try to send client an
error reply, representing channel-io error on previous t
On Mon, Mar 05, 2018 at 08:27:32AM -0300, Philippe Mathieu-Daudé wrote:
> It eases code review, unit is explicit.
>
> Patch generated using:
>
> $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
>
> and modified manually.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Re
On 5 March 2018 at 09:40, Stefan Hajnoczi wrote:
> The following changes since commit 136c67e07869227b21b3f627316e03679ce7b738:
>
> Merge remote-tracking branch
> 'remotes/bkoppelmann/tags/pull-tricore-2018-03-02' into staging (2018-03-02
> 16:56:20 +)
>
> are available in the Git reposito
In case of io error in nbd_co_send_sparse_read we should not
"goto reply:", as it is fatal error and common behavior is
disconnect in this case. We should not try to send client an
error reply, representing channel-io error on previous try to
send a reply.
Fix this by handle block-status error in
The following changes since commit 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180302'
into staging (2018-03-02 14:37:10 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for
On 2018-03-01 02:14, Fam Zheng wrote:
> The AFL image is to exercise the code validating image size, which
> doesn't work on 32 bit or when out of memory (there is a large
> allocation before the interesting point). So check that and skip the
> test, instead of faking the result.
>
> Signed-off-by
On 2018-03-02 12:20, Alberto Garcia wrote:
> This patch tweaks TestParallelOps in iotest 030 so it allocates data
> in smaller regions (256KB/512KB instead of 512KB/1MB) and the
> block-stream job in test_stream_commit() only needs to copy data that
> is at the very end of the image.
>
> This way
On Fri, Dec 15, 2017 at 04:59:13PM -0800, Deepa Srinivasan wrote:
> Starting qemu with the following arguments causes qemu to segfault:
> ... -device lsi,id=lsi0 -drive file=iscsi:<...>,format=raw,if=none,node-name=
> iscsi1 -device scsi-block,bus=lsi0.0,id=<...>,drive=iscsi1
>
> This patch fixes
Am 05.03.2018 um 17:10 hat Eric Blake geschrieben:
> On 03/05/2018 09:05 AM, Kevin Wolf wrote:
> > blk_error_action() sends a BLOCK_IO_ERROR QMP event which includes the
> > node name of its root node. If the BlockBackend represents an empty
> > drive, there is no root node, so we should not try to
On 2018-03-05 17:18, Eric Blake wrote:
> The majority of our iotests have the executable bit set; fix the
> few outliers for consistency.
>
> Signed-off-by: Eric Blake
>
> ---
> v2: fix missing test [Max]
>
> Note that checkpatch.pl complains that this doesn't look like a patch,
> because it is
The majority of our iotests have the executable bit set; fix the
few outliers for consistency.
Signed-off-by: Eric Blake
---
v2: fix missing test [Max]
Note that checkpatch.pl complains that this doesn't look like a patch,
because it is only changing mode bits.
---
tests/qemu-iotests/096 | 0
On 03/05/2018 09:56 AM, Max Reitz wrote:
On 2018-03-02 14:49, Eric Blake wrote:
The majority of our iotests have the executable bit set; fix the
few outliers for consistency.
Signed-off-by: Eric Blake
---
I think 124 is missing.
Good catch. Yes, it is, and I'll spin v2.
--
Eric Blake, Pr
On 03/05/2018 09:05 AM, Kevin Wolf wrote:
blk_error_action() sends a BLOCK_IO_ERROR QMP event which includes the
node name of its root node. If the BlockBackend represents an empty
drive, there is no root node, so we should not try to access its node
name. Make the field optional in the event and
On 2018-03-05 16:59, Stefan Hajnoczi wrote:
> There is a race between the test's 'query-migrate' QMP command after the
> QMP 'STOP' event and completing the migration:
>
> The test case invokes 'query-migrate' upon receiving 'STOP'. At this
> point the migration thread may still be in the process
There is a race between the test's 'query-migrate' QMP command after the
QMP 'STOP' event and completing the migration:
The test case invokes 'query-migrate' upon receiving 'STOP'. At this
point the migration thread may still be in the process of completing.
Therefore 'query-migrate' can return '
On 2018-03-02 14:49, Eric Blake wrote:
> The majority of our iotests have the executable bit set; fix the
> few outliers for consistency.
>
> Signed-off-by: Eric Blake
> ---
I think 124 is missing.
Max
signature.asc
Description: OpenPGP digital signature
On 2017-12-25 03:51, Fam Zheng wrote:
> Signed-off-by: Fam Zheng
>
> ---
>
> v2: Actually test the thing. [Kevin]
> ---
> tests/qemu-iotests/153 | 8 +---
> tests/qemu-iotests/153.out | 7 ---
> 2 files changed, 9 insertions(+), 6 deletions(-)
Thanks, applied to my block tree:
htt
On Fri, Feb 23, 2018 at 02:03:15PM +0100, Max Reitz wrote:
> Hi,
>
> iotest 203 relatively often fails for me, at least when run in parallel.
> When I run the following concurrently on four shells:
>
> $ while TEST_DIR=/tmp/t1 ./check -T -qcow2 203; do; done
> $ while TEST_DIR=/tmp/t2 ./check -T
hello David,
Dr. David Alan Gilbert writes:
> * Richard Palethorpe (rpaletho...@suse.com) wrote:
>> Allow a QEMU instance which has been started and used without the "-incoming"
>> flag to accept an incoming migration with the "migrate-incoming" QMP
>> command. This allows the user to dump the VM
blk_error_action() sends a BLOCK_IO_ERROR QMP event which includes the
node name of its root node. If the BlockBackend represents an empty
drive, there is no root node, so we should not try to access its node
name. Make the field optional in the event and include it only when
the BlockBackend isn't
* Peter Lieven (p...@kamp.de) wrote:
> Am 05.03.2018 um 12:45 schrieb Stefan Hajnoczi:
> > On Thu, Feb 22, 2018 at 12:13:50PM +0100, Peter Lieven wrote:
> >> I stumbled across the MAX_INFLIGHT_IO field that was introduced in 2015
> >> and was curious what was the reason
> >> to choose 512MB as rea
Am 05.03.2018 um 12:45 schrieb Stefan Hajnoczi:
> On Thu, Feb 22, 2018 at 12:13:50PM +0100, Peter Lieven wrote:
>> I stumbled across the MAX_INFLIGHT_IO field that was introduced in 2015 and
>> was curious what was the reason
>> to choose 512MB as readahead? The question is that I found that the s
Hello Roman,
Roman Kagan writes:
> On Tue, Feb 27, 2018 at 12:56:49PM +0100, Richard Palethorpe wrote:
>> Following on from the discussion about creating savevm/loadvm QMP
>> equivalents. I decided to take the advice given that we should use external
>> snapshots. However reverting to a snapshot
07.02.2018 15:50, Vladimir Sementsov-Ogievskiy wrote:
Introduce latency histogram statics for block devices.
For each accounted operation type latency region [0, +inf) is
divided into subregions by several points. Then, calculate
hits for each subregion.
Signed-off-by: Vladimir Sementsov-Ogievsk
On 2 March 2018 at 18:54, Kevin Wolf wrote:
> The following changes since commit 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20180302' into staging (2018-03-02
> 14:37:10 +)
>
> are available in the git repository at:
where it is used.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
---
hw/block/nvme.h | 1 -
hw/block/nvme.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.h b/hw/block/nvme.h
index 8f3981121d..cabcf20c32 100644
--- a/hw/block/nvme.h
+++ b/hw/bl
On Mon, 03/05 11:51, Alberto Garcia wrote:
> On Mon 05 Mar 2018 10:40:06 AM CET, Stefan Hajnoczi wrote:
> > +A 'git-profile' utility was created to make above process less
> > +cumbersome, and is highly recommended for making regular
> > contributions,
>
> A 'git-profile' utility ? Did you want to
It eases code review, unit is explicit.
Patch generated using:
$ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
and modified manually.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alan Robinson
---
hw/block/xen_disk.c| 4 ++--
hw/xenpv/xen_domainbuil
On Thu, Feb 22, 2018 at 12:13:50PM +0100, Peter Lieven wrote:
> I stumbled across the MAX_INFLIGHT_IO field that was introduced in 2015 and
> was curious what was the reason
> to choose 512MB as readahead? The question is that I found that the source VM
> gets very unresponsive I/O wise
> while t
It eases code review, unit is explicit.
Patch generated using:
$ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
and modified manually.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/tc58128.c | 2 +-
hw/sh4/r2d.c | 2 +-
2 files changed, 2 insertions(+), 2
On Mon 05 Mar 2018 10:40:06 AM CET, Stefan Hajnoczi wrote:
> +A 'git-profile' utility was created to make above process less
> +cumbersome, and is highly recommended for making regular
> contributions,
A 'git-profile' utility ? Did you want to say 'git-publish' there?
Berto
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180305094006.21446-1-stefa...@redhat.com
Subject: [Qemu-devel] [PULL 0/6] Block patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE
From: Su Hang
Using `clang-format -i util/uri.c` first, then change back few code
manually, to make sure only whitespace involved.
Signed-off-by: Su Hang
Reviewed-by: Thomas Huth
Message-id: 1519533358-13759-2-git-send-email-suhan...@mails.ucas.ac.cn
Signed-off-by: Stefan Hajnoczi
---
util/u
From: Fam Zheng
Signed-off-by: Fam Zheng
Message-id: 20180226030326.20219-3-f...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
README | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/README b/README
index 2c8e1c8cc4..7833b97365 100644
--- a/RE
From: Fam Zheng
git-publish [1] is a convenient tool to send patches and has been
popular among QEMU developers. Recently it has been made available in
Fedora/Debian official repo.
One nice feature of the tool is a per-project configuration with
profiles, especially in which the cccmd option is
The following changes since commit 136c67e07869227b21b3f627316e03679ce7b738:
Merge remote-tracking branch
'remotes/bkoppelmann/tags/pull-tricore-2018-03-02' into staging (2018-03-02
16:56:20 +)
are available in the Git repository at:
git://github.com/stefanha/qemu.git tags/block-pull-r
From: Su Hang
For this patch, using curly braces to wrap `if` `while` `else` statements,
which only hold single statement. For example:
'''
if (cond)
statement;
'''
to
'''
if (cond) {
statement;
}
'''
And using tricks that compare the disassemblies before and after
code changes, to make
From: Thomas Huth
dev could be NULL if the PCI device can not be found due to some
reasons, so we must not dereference the pointer in this case.
Signed-off-by: Thomas Huth
Message-id: 1519713884-2346-1-git-send-email-th...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
tests/libqos/virtio-pci.
From: Su Hang
only remove brackets that wrap `return` statements' content.
use `perl -pi -e "s/return \((.*?)\);/return \1;/g" util/uri.c`
to remove pattern like this: "return (1);"
Signed-off-by: Su Hang
Reviewed-by: Thomas Huth
Message-id: 1519533358-13759-3-git-send-email-suhan...@mails.uc
43 matches
Mail list logo
